From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Junhao He <hejunhao3@huawei.com>
Cc: <will@kernel.org>, <linux-kernel@vger.kernel.org>,
<mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-doc@vger.kernel.org>, <linuxarm@huawei.com>,
<yangyicong@huawei.com>, <shenyang39@huawei.com>,
<prime.zeng@hisilicon.com>
Subject: Re: [PATCH v2 1/3] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver
Date: Wed, 31 May 2023 16:45:56 +0100 [thread overview]
Message-ID: <20230531164556.000027e9@Huawei.com> (raw)
In-Reply-To: <20230531104625.18296-2-hejunhao3@huawei.com>
On Wed, 31 May 2023 18:46:23 +0800
Junhao He <hejunhao3@huawei.com> wrote:
> Compared to the original PA device, H60PA offers higher bandwidth.
> The H60PA is a new device and we use HID to differentiate them.
>
> The events supported by PAv3 and PAv2 are different. They use the
> same HID. The PMU version register is used in the driver to
> distinguish different versions.
>
> For each H60PA PMU, except for the overflow interrupt register, other
> functions of the H60PA PMU are the same as the original PA PMU module.
> It has 8-programable counters and each counter is free-running.
> Interrupt is supported to handle counter (64-bits) overflow.
>
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
Hi,
I would have slightly preferred to see the refactoring done as a first
patch and then the new device supported added in a second, but as that
second patch would only be a few lines I don't mind that much.
The result looks fine to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Junhao He <hejunhao3@huawei.com>
Cc: <will@kernel.org>, <linux-kernel@vger.kernel.org>,
<mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-doc@vger.kernel.org>, <linuxarm@huawei.com>,
<yangyicong@huawei.com>, <shenyang39@huawei.com>,
<prime.zeng@hisilicon.com>
Subject: Re: [PATCH v2 1/3] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver
Date: Wed, 31 May 2023 16:45:56 +0100 [thread overview]
Message-ID: <20230531164556.000027e9@Huawei.com> (raw)
In-Reply-To: <20230531104625.18296-2-hejunhao3@huawei.com>
On Wed, 31 May 2023 18:46:23 +0800
Junhao He <hejunhao3@huawei.com> wrote:
> Compared to the original PA device, H60PA offers higher bandwidth.
> The H60PA is a new device and we use HID to differentiate them.
>
> The events supported by PAv3 and PAv2 are different. They use the
> same HID. The PMU version register is used in the driver to
> distinguish different versions.
>
> For each H60PA PMU, except for the overflow interrupt register, other
> functions of the H60PA PMU are the same as the original PA PMU module.
> It has 8-programable counters and each counter is free-running.
> Interrupt is supported to handle counter (64-bits) overflow.
>
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
Hi,
I would have slightly preferred to see the refactoring done as a first
patch and then the new device supported added in a second, but as that
second patch would only be a few lines I don't mind that much.
The result looks fine to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-31 15:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 10:46 [PATCH v2 0/3] Add support for HiSilicon SoC uncore PMU Junhao He
2023-05-31 10:46 ` Junhao He
2023-05-31 10:46 ` [PATCH v2 1/3] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver Junhao He
2023-05-31 10:46 ` Junhao He
2023-05-31 15:45 ` Jonathan Cameron [this message]
2023-05-31 15:45 ` Jonathan Cameron
2023-06-01 6:40 ` Yicong Yang
2023-06-01 6:40 ` Yicong Yang
2023-05-31 10:46 ` [PATCH v2 2/3] drivers/perf: hisi: Add support for HiSilicon UC " Junhao He
2023-05-31 10:46 ` Junhao He
2023-05-31 15:59 ` Jonathan Cameron
2023-05-31 15:59 ` Jonathan Cameron
2023-06-01 6:53 ` Yicong Yang
2023-06-01 6:53 ` Yicong Yang
2023-06-07 11:00 ` hejunhao
2023-06-07 11:00 ` hejunhao
2023-06-01 6:41 ` Yicong Yang
2023-06-01 6:41 ` Yicong Yang
2023-05-31 10:46 ` [PATCH v2 3/3] docs: perf: Add new description for HiSilicon UC PMU Junhao He
2023-05-31 10:46 ` Junhao He
2023-05-31 16:00 ` Jonathan Cameron
2023-05-31 16:00 ` Jonathan Cameron
2023-06-01 6:44 ` Yicong Yang
2023-06-01 6:44 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531164556.000027e9@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=hejunhao3@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=shenyang39@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.