From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>, <nm@ti.com>,
<kristo@kernel.org>, <ssantosh@kernel.org>,
<michal.simek@xilinx.com>, <aford173@gmail.com>,
<mike.looijmans@topic.nl>, <robert.hancock@calian.com>,
<shawn.guo@linaro.org>, <fabio.estevam@freescale.com>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/8] clk: vc5: check memory returned by kasprintf()
Date: Wed, 31 May 2023 18:32:56 +0200 [thread overview]
Message-ID: <20230531183256.48e1b893@booty> (raw)
In-Reply-To: <20230530093913.1656095-2-claudiu.beznea@microchip.com>
Hi Claudiu,
On Tue, 30 May 2023 12:39:06 +0300
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
> kasprintf() returns a pointer to dynamically allocated memory.
> Pointer could be NULL in case allocation fails. Check pointer validity.
> Identified with coccinelle (kmerr.cocci script).
>
> Fixes: f491276a5168 ("clk: vc5: Allow Versaclock driver to support multiple instances")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
I think this driver would benefit a bit of refactoring, moving all
those similar sections to a single function.
But for the time being your change is fine:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>, <nm@ti.com>,
<kristo@kernel.org>, <ssantosh@kernel.org>,
<michal.simek@xilinx.com>, <aford173@gmail.com>,
<mike.looijmans@topic.nl>, <robert.hancock@calian.com>,
<shawn.guo@linaro.org>, <fabio.estevam@freescale.com>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/8] clk: vc5: check memory returned by kasprintf()
Date: Wed, 31 May 2023 18:32:56 +0200 [thread overview]
Message-ID: <20230531183256.48e1b893@booty> (raw)
In-Reply-To: <20230530093913.1656095-2-claudiu.beznea@microchip.com>
Hi Claudiu,
On Tue, 30 May 2023 12:39:06 +0300
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:
> kasprintf() returns a pointer to dynamically allocated memory.
> Pointer could be NULL in case allocation fails. Check pointer validity.
> Identified with coccinelle (kmerr.cocci script).
>
> Fixes: f491276a5168 ("clk: vc5: Allow Versaclock driver to support multiple instances")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
I think this driver would benefit a bit of refactoring, moving all
those similar sections to a single function.
But for the time being your change is fine:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-31 16:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:39 [PATCH 0/8] clk: check memory returned by {devm_}kasprintf() Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-05-30 9:39 ` [PATCH 1/8] clk: vc5: check memory returned by kasprintf() Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-05-31 16:32 ` Luca Ceresoli [this message]
2023-05-31 16:32 ` Luca Ceresoli
2023-06-20 18:53 ` Stephen Boyd
2023-06-20 18:53 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 2/8] clk: cdce925: check return value of kasprintf() Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-06-20 18:54 ` Stephen Boyd
2023-06-20 18:54 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 3/8] clk: si5341: return error if one synth clock registration fails Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-06-20 18:54 ` Stephen Boyd
2023-06-20 18:54 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 4/8] clk: si5341: check return value of {devm_}kasprintf() Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-06-20 18:54 ` Stephen Boyd
2023-06-20 18:54 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 5/8] clk: si5341: free unused memory on probe failure Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-06-20 18:55 ` Stephen Boyd
2023-06-20 18:55 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 6/8] clk: keystone: sci-clk: check return value of kasprintf() Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-05-31 4:12 ` Tony Lindgren
2023-05-31 4:12 ` Tony Lindgren
2023-06-20 18:55 ` Stephen Boyd
2023-06-20 18:55 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 7/8] clk: ti: clkctrl: " Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-05-31 4:12 ` Tony Lindgren
2023-05-31 4:12 ` Tony Lindgren
2023-06-20 18:55 ` Stephen Boyd
2023-06-20 18:55 ` Stephen Boyd
2023-05-30 9:39 ` [PATCH 8/8] clk: clocking-wizard: check return value of devm_kasprintf() Claudiu Beznea
2023-05-30 9:39 ` Claudiu Beznea
2023-06-20 18:55 ` Stephen Boyd
2023-06-20 18:55 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531183256.48e1b893@booty \
--to=luca.ceresoli@bootlin.com \
--cc=aford173@gmail.com \
--cc=claudiu.beznea@microchip.com \
--cc=fabio.estevam@freescale.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mike.looijmans@topic.nl \
--cc=mturquette@baylibre.com \
--cc=nm@ti.com \
--cc=robert.hancock@calian.com \
--cc=sboyd@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.