Re: [PATCH RFC net-next v3 7/8] vsock: Add lockless sendmsg() support

[kernel test robot <lkp@intel.com>]

Hi Bobby,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on ed72bd5a6790a0c3747cb32b0427f921bd03bb71]

url:    https://github.com/intel-lab-lkp/linux/commits/Bobby-Eshleman/vsock-dgram-generalize-recvmsg-and-drop-transport-dgram_dequeue/20230531-084049
base:   ed72bd5a6790a0c3747cb32b0427f921bd03bb71
patch link:    https://lore.kernel.org/r/20230413-b4-vsock-dgram-v3-7-c2414413ef6a%40bytedance.com
patch subject: [PATCH RFC net-next v3 7/8] vsock: Add lockless sendmsg() support
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20230531/202305312309.o1HevXs3-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4e9bf74675652b253b0ba5d9a7c4a505f25fcc7e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Bobby-Eshleman/vsock-dgram-generalize-recvmsg-and-drop-transport-dgram_dequeue/20230531-084049
        git checkout 4e9bf74675652b253b0ba5d9a7c4a505f25fcc7e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash net/vmw_vsock/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305312309.o1HevXs3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/vmw_vsock/af_vsock.c:221:5: warning: no previous prototype for 'vsock_set_remote_info' [-Wmissing-prototypes]
     221 | int vsock_set_remote_info(struct vsock_sock *vsk,
         |     ^~~~~~~~~~~~~~~~~~~~~
   net/vmw_vsock/af_vsock.c:383:14: warning: no previous prototype for 'vsock_find_bound_socket_common' [-Wmissing-prototypes]
     383 | struct sock *vsock_find_bound_socket_common(struct sockaddr_vm *addr,
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/vmw_vsock/af_vsock.c:474:6: warning: no previous prototype for 'vsock_remove_dgram_bound' [-Wmissing-prototypes]
     474 | void vsock_remove_dgram_bound(struct vsock_sock *vsk)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   net/vmw_vsock/af_vsock.c:835:5: warning: no previous prototype for 'vsock_bind_common' [-Wmissing-prototypes]
     835 | int vsock_bind_common(struct vsock_sock *vsk,
         |     ^~~~~~~~~~~~~~~~~
   net/vmw_vsock/af_vsock.c:903:5: warning: no previous prototype for 'vsock_bind_stream' [-Wmissing-prototypes]
     903 | int vsock_bind_stream(struct vsock_sock *vsk,
         |     ^~~~~~~~~~~~~~~~~


vim +/vsock_set_remote_info +221 net/vmw_vsock/af_vsock.c

   219	
   220	/* The socket lock must be held by the caller */
 > 221	int vsock_set_remote_info(struct vsock_sock *vsk,
   222				  const struct vsock_transport *transport,
   223				  struct sockaddr_vm *addr)
   224	{
   225		struct vsock_remote_info *old, *new;
   226	
   227		if (addr || transport) {
   228			new = kmalloc(sizeof(*new), GFP_KERNEL);
   229			if (!new)
   230				return -ENOMEM;
   231	
   232			if (addr)
   233				memcpy(&new->addr, addr, sizeof(new->addr));
   234	
   235			if (transport)
   236				new->transport = transport;
   237		} else {
   238			new = NULL;
   239		}
   240	
   241		old = rcu_replace_pointer(vsk->remote_info, new, lockdep_sock_is_held(sk_vsock(vsk)));
   242		kfree_rcu(old, rcu);
   243	
   244		return 0;
   245	}
   246	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki