All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: James Clark <james.clark@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Coresight ML <coresight@lists.linaro.org>
Subject: Re: [PATCH v4 1/4] devres: Provide krealloc_array
Date: Thu, 1 Jun 2023 10:33:38 +0100	[thread overview]
Message-ID: <2023060104-removal-map-b194@gregkh> (raw)
In-Reply-To: <46bb773c-31a8-c57a-0cde-39c27d0a6e36@arm.com>

On Wed, May 31, 2023 at 11:44:55PM +0100, Suzuki K Poulose wrote:
> (Removed irrelevant recipients), +Cc: coresight ml
> 
> Hi Greg,
> 
> On 15/05/2023 12:55, Greg KH wrote:
> > On Mon, May 15, 2023 at 08:55:33AM +0100, James Clark wrote:
> > > 
> > > 
> > > On 13/05/2023 12:04, Greg KH wrote:
> > > > On Tue, May 09, 2023 at 10:49:38AM +0100, James Clark wrote:
> > > > > There is no krealloc_array equivalent in devres. Users would have to
> > > > > do their own multiplication overflow check so provide one.
> > > > > 
> > > > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > > Signed-off-by: James Clark <james.clark@arm.com>
> > > > > ---
> > > > >   Documentation/driver-api/driver-model/devres.rst |  1 +
> > > > >   include/linux/device.h                           | 11 +++++++++++
> > > > >   2 files changed, 12 insertions(+)
> 
> ...
> 
> > > Maybe something could be done with some macro magic, but it would
> > > probably end up being worse than just copying them and would affect the
> > > real ones as well. So yeah I can't think of any easy gains either.
> > 
> > Ok, that's good.  Given a lack of objections from others, I'll just take
> > this through my driver core tree in a few days.
> 
> Apologies for hijacking the thread. We have a series for CoreSight[1]
> that depends on this series, which I see that, is queued in your
> driver-core-next.
> 
> I would like to queue [1] for the next version (as there are other
> work that depend on this, e.g., [2]). Do you have any
> recommendations/comments on the proposal ? Are you able to share a
> stable branch which can be merged to coresight/next and queue the
> series ontop ? (PS: I haven't queued anything for coresight/next yet).

You can pull from my driver-core-next branch just fine and assume it
will be stable.  So just pull in that one commit and all should be good
in the future.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: James Clark <james.clark@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Coresight ML <coresight@lists.linaro.org>
Subject: Re: [PATCH v4 1/4] devres: Provide krealloc_array
Date: Thu, 1 Jun 2023 10:33:38 +0100	[thread overview]
Message-ID: <2023060104-removal-map-b194@gregkh> (raw)
In-Reply-To: <46bb773c-31a8-c57a-0cde-39c27d0a6e36@arm.com>

On Wed, May 31, 2023 at 11:44:55PM +0100, Suzuki K Poulose wrote:
> (Removed irrelevant recipients), +Cc: coresight ml
> 
> Hi Greg,
> 
> On 15/05/2023 12:55, Greg KH wrote:
> > On Mon, May 15, 2023 at 08:55:33AM +0100, James Clark wrote:
> > > 
> > > 
> > > On 13/05/2023 12:04, Greg KH wrote:
> > > > On Tue, May 09, 2023 at 10:49:38AM +0100, James Clark wrote:
> > > > > There is no krealloc_array equivalent in devres. Users would have to
> > > > > do their own multiplication overflow check so provide one.
> > > > > 
> > > > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > > Signed-off-by: James Clark <james.clark@arm.com>
> > > > > ---
> > > > >   Documentation/driver-api/driver-model/devres.rst |  1 +
> > > > >   include/linux/device.h                           | 11 +++++++++++
> > > > >   2 files changed, 12 insertions(+)
> 
> ...
> 
> > > Maybe something could be done with some macro magic, but it would
> > > probably end up being worse than just copying them and would affect the
> > > real ones as well. So yeah I can't think of any easy gains either.
> > 
> > Ok, that's good.  Given a lack of objections from others, I'll just take
> > this through my driver core tree in a few days.
> 
> Apologies for hijacking the thread. We have a series for CoreSight[1]
> that depends on this series, which I see that, is queued in your
> driver-core-next.
> 
> I would like to queue [1] for the next version (as there are other
> work that depend on this, e.g., [2]). Do you have any
> recommendations/comments on the proposal ? Are you able to share a
> stable branch which can be merged to coresight/next and queue the
> series ontop ? (PS: I haven't queued anything for coresight/next yet).

You can pull from my driver-core-next branch just fine and assume it
will be stable.  So just pull in that one commit and all should be good
in the future.

thanks,

greg k-h

  parent reply	other threads:[~2023-06-01  9:34 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  9:49 [PATCH v4 0/4] devres: Provide krealloc_array James Clark
2023-05-09  9:49 ` [PATCH v4 1/4] " James Clark
2023-05-13 11:04   ` Greg KH
2023-05-15  7:55     ` James Clark
2023-05-15 11:55       ` Greg KH
2023-05-15 11:55         ` Greg KH
2023-05-31 22:44         ` Suzuki K Poulose
2023-05-31 22:44           ` Suzuki K Poulose
2023-05-31 22:47           ` Suzuki K Poulose
2023-05-31 22:47             ` Suzuki K Poulose
2023-06-01  9:33           ` Greg KH [this message]
2023-06-01  9:33             ` Greg KH
2023-06-01  9:52             ` Suzuki K Poulose
2023-06-01  9:52               ` Suzuki K Poulose
2023-06-05 13:39               ` Suzuki K Poulose
2023-06-05 13:39                 ` Suzuki K Poulose
2023-06-05 15:20                 ` Greg KH
2023-06-05 15:20                   ` Greg KH
2023-06-05 15:59                   ` Suzuki K Poulose
2023-06-05 15:59                     ` Suzuki K Poulose
2023-05-09  9:49 ` [PATCH v4 2/4] hwmon: pmbus: Use devm_krealloc_array James Clark
2023-05-09  9:49 ` [PATCH v4 3/4] iio: adc: " James Clark
2023-05-09  9:49 ` [PATCH v4 4/4] serial: qcom_geni: Comment use of devm_krealloc rather than devm_krealloc_array James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023060104-removal-map-b194@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=coresight@lists.linaro.org \
    --cc=james.clark@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.