From: Kees Cook <keescook@chromium.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
ndesaulniers@google.com, linux-kernel@vger.kernel.org,
gustavoars@kernel.org, linux@leemhuis.info,
heiko.stuebner@vrull.eu, linux-hardening@vger.kernel.org,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
joanbrugueram@gmail.com, masahiroy@kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
ajones@ventanamicro.com, hi@alyssa.is
Subject: Re: [PATCH v2] riscv/purgatory: Do not use fortified string functions
Date: Thu, 1 Jun 2023 13:31:33 -0700 [thread overview]
Message-ID: <202306011331.880AF01743@keescook> (raw)
In-Reply-To: <mhng-8c6309b5-4ba9-4276-a8e6-2864426e77f0@palmer-ri-x1c9a>
On Thu, Jun 01, 2023 at 01:17:03PM -0700, Palmer Dabbelt wrote:
> On Thu, 01 Jun 2023 11:27:03 PDT (-0700), keescook@chromium.org wrote:
> > On Thu, 1 Jun 2023 09:00:28 -0700, Kees Cook wrote:
> > > With the addition of -fstrict-flex-arrays=3, struct sha256_state's
> > > trailing array is no longer ignored by CONFIG_FORTIFY_SOURCE:
> > >
> > > struct sha256_state {
> > > u32 state[SHA256_DIGEST_SIZE / 4];
> > > u64 count;
> > > u8 buf[SHA256_BLOCK_SIZE];
> > > };
> > >
> > > [...]
> >
> > Applied to for-next/hardening, thanks!
> >
> > [1/1] riscv/purgatory: Do not use fortified string functions
> > https://git.kernel.org/kees/c/ca2ca08f479d
>
> Sorry, I'd just applied this to riscv/fixes as well. I can drop it if you
> want? I was going to send a PR tomorrow, just LMK.
I'm fine either way. I was carrying each arch's fix just since it was
related to the -fstrict-flex-arrays=3 patch in the hardening tree.
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
ndesaulniers@google.com, linux-kernel@vger.kernel.org,
gustavoars@kernel.org, linux@leemhuis.info,
heiko.stuebner@vrull.eu, linux-hardening@vger.kernel.org,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
joanbrugueram@gmail.com, masahiroy@kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
ajones@ventanamicro.com, hi@alyssa.is
Subject: Re: [PATCH v2] riscv/purgatory: Do not use fortified string functions
Date: Thu, 1 Jun 2023 13:31:33 -0700 [thread overview]
Message-ID: <202306011331.880AF01743@keescook> (raw)
In-Reply-To: <mhng-8c6309b5-4ba9-4276-a8e6-2864426e77f0@palmer-ri-x1c9a>
On Thu, Jun 01, 2023 at 01:17:03PM -0700, Palmer Dabbelt wrote:
> On Thu, 01 Jun 2023 11:27:03 PDT (-0700), keescook@chromium.org wrote:
> > On Thu, 1 Jun 2023 09:00:28 -0700, Kees Cook wrote:
> > > With the addition of -fstrict-flex-arrays=3, struct sha256_state's
> > > trailing array is no longer ignored by CONFIG_FORTIFY_SOURCE:
> > >
> > > struct sha256_state {
> > > u32 state[SHA256_DIGEST_SIZE / 4];
> > > u64 count;
> > > u8 buf[SHA256_BLOCK_SIZE];
> > > };
> > >
> > > [...]
> >
> > Applied to for-next/hardening, thanks!
> >
> > [1/1] riscv/purgatory: Do not use fortified string functions
> > https://git.kernel.org/kees/c/ca2ca08f479d
>
> Sorry, I'd just applied this to riscv/fixes as well. I can drop it if you
> want? I was going to send a PR tomorrow, just LMK.
I'm fine either way. I was carrying each arch's fix just since it was
related to the -fstrict-flex-arrays=3 patch in the hardening tree.
--
Kees Cook
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-06-01 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 16:00 [PATCH v2] riscv/purgatory: Do not use fortified string functions Kees Cook
2023-06-01 16:00 ` Kees Cook
2023-06-01 17:34 ` Conor Dooley
2023-06-01 17:34 ` Conor Dooley
2023-06-01 18:27 ` Kees Cook
2023-06-01 18:27 ` Kees Cook
2023-06-01 20:17 ` Palmer Dabbelt
2023-06-01 20:17 ` Palmer Dabbelt
2023-06-01 20:31 ` Kees Cook [this message]
2023-06-01 20:31 ` Kees Cook
2023-06-01 21:04 ` Palmer Dabbelt
2023-06-01 21:04 ` Palmer Dabbelt
2023-06-01 20:20 ` patchwork-bot+linux-riscv
2023-06-01 20:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306011331.880AF01743@keescook \
--to=keescook@chromium.org \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=gustavoars@kernel.org \
--cc=heiko.stuebner@vrull.eu \
--cc=hi@alyssa.is \
--cc=joanbrugueram@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@leemhuis.info \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.