From: Philip Yang <Philip.Yang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Philip Yang <Philip.Yang@amd.com>,
Felix.Kuehling@amd.com, christian.koenig@amd.com
Subject: [PATCH 0/4] Page table fence
Date: Thu, 1 Jun 2023 15:31:13 -0400 [thread overview]
Message-ID: <20230601193117.13143-1-Philip.Yang@amd.com> (raw)
This patch series to fix GPU generate random no-retry fault on APU with
XNACK on.
If updating GPU page table to use PDE0 as PTE, for example unmap 2MB
align virtual address, then map same virtual address using transparent
2MB huge page, we free the PTE BO first and then flush TLB.
If XNACK ON, H/W may access the freed old PTE page before TLB is flushed.
On APU, the freed PTE BO system memory page maybe used and the content
is changed, this causes H/W enerates unexpected no-retry fault.
The fix is to add fence to the freed page table BO, and then signal the
fence after TLB is flushed to really free the page table BO page.
Philip Yang (4):
drm/amdgpu: Implement page table BO fence
drm/amdkfd: Signal page table fence after KFD flush tlb
drm/amdgpu: Signal page table fence after gfx vm flush
drm/amdgpu: Add fence to the freed page table BOs
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 45 +++++++++++++++++++++++
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 7 ++++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 33 +++++++++++------
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 +++
7 files changed, 86 insertions(+), 11 deletions(-)
--
2.35.1
next reply other threads:[~2023-06-01 19:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 19:31 Philip Yang [this message]
2023-06-01 19:31 ` [PATCH 1/4] drm/amdgpu: Implement page table BO fence Philip Yang
2023-06-01 20:12 ` Felix Kuehling
2023-06-02 11:54 ` Christian König
2023-06-01 19:31 ` [PATCH 2/4] drm/amdkfd: Signal page table fence after KFD flush tlb Philip Yang
2023-06-01 20:34 ` Felix Kuehling
2023-06-02 11:57 ` Christian König
2023-06-02 14:54 ` Felix Kuehling
2023-06-05 15:13 ` Shashank Sharma
2023-06-05 15:18 ` Christian König
2023-06-05 15:40 ` Shashank Sharma
2023-06-05 15:47 ` Christian König
2023-06-06 16:16 ` Philip Yang
2023-06-01 19:31 ` [PATCH 3/4] drm/amdgpu: Signal page table fence after gfx vm flush Philip Yang
2023-06-01 20:37 ` Felix Kuehling
2023-06-01 19:31 ` [PATCH 4/4] drm/amdgpu: Add fence to the freed page table BOs Philip Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601193117.13143-1-Philip.Yang@amd.com \
--to=philip.yang@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.