All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: "H . Nikolaus Schaller" <hns@goldelico.com>,
	linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, list@opendingux.net,
	Paul Cercueil <paul@crapouillou.net>
Subject: [PATCH 1/9] MIPS: DTS: CI20: Fix regulators
Date: Sun,  4 Jun 2023 16:56:34 +0200	[thread overview]
Message-ID: <20230604145642.200577-2-paul@crapouillou.net> (raw)
In-Reply-To: <20230604145642.200577-1-paul@crapouillou.net>

The regulators don't have any "reg" property, and therefore shouldn't
use an unit address in their node names. They also don't need to specify
the GPIO_ACTIVE_LOW flag, which will be ignored anyway, as they are
active-high.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 arch/mips/boot/dts/ingenic/ci20.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
index 239c4537484d..e76953dce2e7 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -67,14 +67,14 @@ led-3 {
 		};
 	};
 
-	eth0_power: fixedregulator@0 {
+	eth0_power: fixedregulator-0 {
 		compatible = "regulator-fixed";
 
 		regulator-name = "eth0_power";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 
-		gpio = <&gpb 25 GPIO_ACTIVE_LOW>;
+		gpio = <&gpb 25 0>;
 		enable-active-high;
 	};
 
@@ -97,23 +97,23 @@ ir: ir {
 		gpios = <&gpe 3 GPIO_ACTIVE_LOW>;
 	};
 
-	wlan0_power: fixedregulator@1 {
+	wlan0_power: fixedregulator-1 {
 		compatible = "regulator-fixed";
 
 		regulator-name = "wlan0_power";
 
-		gpio = <&gpb 19 GPIO_ACTIVE_LOW>;
+		gpio = <&gpb 19 0>;
 		enable-active-high;
 	};
 
-	otg_power: fixedregulator@2 {
+	otg_power: fixedregulator-2 {
 		compatible = "regulator-fixed";
 
 		regulator-name = "otg_power";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
 
-		gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
+		gpio = <&gpf 15 0>;
 		enable-active-high;
 	};
 };
-- 
2.39.2


  reply	other threads:[~2023-06-04 14:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 14:56 [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support Paul Cercueil
2023-06-04 14:56 ` Paul Cercueil [this message]
2023-06-04 14:56 ` [PATCH 2/9] MIPS: DTS: CI20: Fix ACT8600 regulator node names Paul Cercueil
2023-06-15  7:00   ` H. Nikolaus Schaller
2023-06-04 14:56 ` [PATCH 3/9] MIPS: DTS: CI20: Add parent supplies to ACT8600 regulators Paul Cercueil
2023-06-15  7:00   ` H. Nikolaus Schaller
2023-06-04 14:56 ` [PATCH 4/9] MIPS: DTS: CI20: Do not force-enable CIM and WiFi regulators Paul Cercueil
2023-06-04 14:56 ` [PATCH 5/9] MIPS: DTS: CI20: Misc. cleanups Paul Cercueil
2023-06-15  7:01   ` H. Nikolaus Schaller
2023-06-04 14:56 ` [PATCH 6/9] MIPS: DTS: CI20: Parent MSCMUX clock to MPLL Paul Cercueil
2023-06-04 14:56 ` [PATCH 7/9] MIPS: DTS: CI20: Enable support for WiFi / Bluetooth Paul Cercueil
2023-06-15  7:01   ` H. Nikolaus Schaller
2023-06-04 14:56 ` [PATCH 8/9] MIPS: configs: CI20: Regenerate defconfig Paul Cercueil
2023-06-04 14:56 ` [PATCH 9/9] MIPS: configs: CI20: Enable WiFi / Bluetooth Paul Cercueil
2023-06-09  8:23 ` [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support Thomas Bogendoerfer
2023-06-15  7:08   ` H. Nikolaus Schaller
2023-06-15  7:00 ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230604145642.200577-2-paul@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hns@goldelico.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=list@opendingux.net \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.