All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Liu Ying <victor.liu@nxp.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
Date: Tue, 6 Jun 2023 19:21:02 +0100	[thread overview]
Message-ID: <20230606-implement-canning-0353ca9afddb@spud> (raw)
In-Reply-To: <20230606144447.775942-1-alexander.stein@ew.tq-group.com>


[-- Attachment #1.1: Type: text/plain, Size: 1720 bytes --]

On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.

What does "allowed anyway" mean?
And following from that, why not modify the min/maxItems to suit
reality, rather than remove them. Is there enforcement from elsewhere?

> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

I suspect that meant that the property was in the dt but not in the
binding at the time of the conversion.

Cheers,
Conor.

> 
> Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> properties.
> 
>  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> index 786cfd71cb7eb..3c28ec50f0979 100644
> --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> @@ -32,15 +32,6 @@ properties:
>    clock-names:
>      const: phy_ref
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-parents:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    "#phy-cells":
>      const: 0
>  
> -- 
> 2.34.1
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Liu Ying <victor.liu@nxp.com>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties
Date: Tue, 6 Jun 2023 19:21:02 +0100	[thread overview]
Message-ID: <20230606-implement-canning-0353ca9afddb@spud> (raw)
In-Reply-To: <20230606144447.775942-1-alexander.stein@ew.tq-group.com>

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On Tue, Jun 06, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> These properties are allowed anyway and some SoC (e.g. imx8mq) configure
> more than just one clock using these properties.

What does "allowed anyway" mean?
And following from that, why not modify the min/maxItems to suit
reality, rather than remove them. Is there enforcement from elsewhere?

> Fixes: f9b0593dd4fc6 ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I can't reproduce the mentioned mis-matches in commit f9b0593dd4fc6
> ("dt-bindings: phy: Convert mixel,mipi-dsi-phy to json-schema").

I suspect that meant that the property was in the dt but not in the
binding at the time of the conversion.

Cheers,
Conor.

> 
> Since commit 62270eeb2b639 ("arm64: dts: imx8mq: Add clock parents for
> mipi dphy") imx8mq.dtsi configures several clocks using assigned-clocks*
> properties.
> 
>  .../devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml      | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> index 786cfd71cb7eb..3c28ec50f0979 100644
> --- a/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.yaml
> @@ -32,15 +32,6 @@ properties:
>    clock-names:
>      const: phy_ref
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-parents:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    "#phy-cells":
>      const: 0
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-06-06 18:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 14:44 [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: Remove assigned-clock* properties Alexander Stein
2023-06-06 14:44 ` Alexander Stein
2023-06-06 18:21 ` Conor Dooley [this message]
2023-06-06 18:21   ` Conor Dooley
2023-06-08  7:31   ` [PATCH 1/1] dt-bindings: phy: mixel, mipi-dsi-phy: " Alexander Stein
2023-06-08  7:31     ` Alexander Stein
2023-06-08  7:59     ` Conor Dooley
2023-06-08  7:59       ` Conor Dooley
2023-06-08  8:07       ` Alexander Stein
2023-06-08  8:07         ` Alexander Stein
2023-06-07  2:45 ` [PATCH 1/1] dt-bindings: phy: mixel,mipi-dsi-phy: " Ying Liu
2023-06-07  2:45   ` Ying Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230606-implement-canning-0353ca9afddb@spud \
    --to=conor@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=victor.liu@nxp.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.