* [rt-devel:linux-6.4.y-rt-rebase 46/79] kernel/printk/printk.c:3361:6: warning: no previous prototype for 'console_bkl_kthread_create'
@ 2023-06-05 20:31 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-06-05 20:31 UTC (permalink / raw)
To: John Ogness; +Cc: oe-kbuild-all, Sebastian Andrzej Siewior
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-6.4.y-rt-rebase
head: 0576a708b07124cac8205893c9ed734ee41f64a9
commit: 11258cd77d13c2c949b61c4dc60ccd0437a260af [46/79] printk: Add threaded printing support for BKL consoles.
config: sparc-randconfig-r035-20230605 (https://download.01.org/0day-ci/archive/20230606/202306060412.TopuoTat-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=11258cd77d13c2c949b61c4dc60ccd0437a260af
git remote add rt-devel https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
git fetch --no-tags rt-devel linux-6.4.y-rt-rebase
git checkout 11258cd77d13c2c949b61c4dc60ccd0437a260af
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash kernel/printk/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306060412.TopuoTat-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/printk/printk.c:3361:6: warning: no previous prototype for 'console_bkl_kthread_create' [-Wmissing-prototypes]
3361 | void console_bkl_kthread_create(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/console_bkl_kthread_create +3361 kernel/printk/printk.c
3360
> 3361 void console_bkl_kthread_create(void)
3362 {
3363 struct task_struct *kt;
3364 struct console *c;
3365
3366 lockdep_assert_held(&console_mutex);
3367
3368 if (!IS_ENABLED(CONFIG_PREEMPT_RT))
3369 return;
3370
3371 if (!printk_threads_enabled || console_bkl_kthread)
3372 return;
3373
3374 for_each_console(c) {
3375 if (c->flags & CON_BOOT)
3376 return;
3377 }
3378
3379 kt = kthread_run(console_bkl_kthread_func, NULL, "pr/bkl");
3380 if (IS_ERR(kt)) {
3381 pr_err("unable to start BKL printing thread\n");
3382 return;
3383 }
3384
3385 console_bkl_kthread = kt;
3386
3387 /*
3388 * It is important that console printing threads are scheduled
3389 * shortly after a printk call and with generous runtime budgets.
3390 */
3391 sched_set_normal(console_bkl_kthread, -20);
3392 }
3393
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [rt-devel:linux-6.4.y-rt-rebase 46/79] kernel/printk/printk.c:3361:6: warning: no previous prototype for 'console_bkl_kthread_create'
@ 2023-09-22 6:58 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-09-22 6:58 UTC (permalink / raw)
To: John Ogness; +Cc: oe-kbuild-all, Sebastian Andrzej Siewior
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-6.4.y-rt-rebase
head: fb7828286d1ee12dc132500e9fc84085ceadabc3
commit: 094c02761170c2bb60bfd8203fde8c553e30871c [46/79] printk: Add threaded printing support for BKL consoles.
config: csky-randconfig-001-20230922 (https://download.01.org/0day-ci/archive/20230922/202309221431.jWGSVvmz-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230922/202309221431.jWGSVvmz-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309221431.jWGSVvmz-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/printk/printk.c:3361:6: warning: no previous prototype for 'console_bkl_kthread_create' [-Wmissing-prototypes]
3361 | void console_bkl_kthread_create(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/console_bkl_kthread_create +3361 kernel/printk/printk.c
3360
> 3361 void console_bkl_kthread_create(void)
3362 {
3363 struct task_struct *kt;
3364 struct console *c;
3365
3366 lockdep_assert_held(&console_mutex);
3367
3368 if (!IS_ENABLED(CONFIG_PREEMPT_RT))
3369 return;
3370
3371 if (!printk_threads_enabled || console_bkl_kthread)
3372 return;
3373
3374 for_each_console(c) {
3375 if (c->flags & CON_BOOT)
3376 return;
3377 }
3378
3379 kt = kthread_run(console_bkl_kthread_func, NULL, "pr/bkl");
3380 if (IS_ERR(kt)) {
3381 pr_err("unable to start BKL printing thread\n");
3382 return;
3383 }
3384
3385 console_bkl_kthread = kt;
3386
3387 /*
3388 * It is important that console printing threads are scheduled
3389 * shortly after a printk call and with generous runtime budgets.
3390 */
3391 sched_set_normal(console_bkl_kthread, -20);
3392 }
3393
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-22 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 20:31 [rt-devel:linux-6.4.y-rt-rebase 46/79] kernel/printk/printk.c:3361:6: warning: no previous prototype for 'console_bkl_kthread_create' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-09-22 6:58 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.