All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: clean up __ice_aq_get_set_rss_lut()
Date: Wed, 7 Jun 2023 09:42:28 -0700	[thread overview]
Message-ID: <20230607094228.10f5b84a@kernel.org> (raw)
In-Reply-To: <ZIAzEh1Y++os19fl@corigine.com>

On Wed, 7 Jun 2023 09:34:42 +0200 Simon Horman wrote:
> > it's the same on gcc-13 on default (make M=...) settings, I think, I will
> > post next version that is passing that build, even if to make integration
> > with new gcc easier  
> 
> Thanks. TBH it does seem a bit silly to me.
> But GCC builds failing does seem to be a problem that warrants being addressed.

Isn't GCC right? There's no guarantee that the value of @type in real,
numerical sense falls within the set of values sanctioned by the enum.
It is C after all, so enums are just decorated ints, aren't they?
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
	Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next] ice: clean up __ice_aq_get_set_rss_lut()
Date: Wed, 7 Jun 2023 09:42:28 -0700	[thread overview]
Message-ID: <20230607094228.10f5b84a@kernel.org> (raw)
In-Reply-To: <ZIAzEh1Y++os19fl@corigine.com>

On Wed, 7 Jun 2023 09:34:42 +0200 Simon Horman wrote:
> > it's the same on gcc-13 on default (make M=...) settings, I think, I will
> > post next version that is passing that build, even if to make integration
> > with new gcc easier  
> 
> Thanks. TBH it does seem a bit silly to me.
> But GCC builds failing does seem to be a problem that warrants being addressed.

Isn't GCC right? There's no guarantee that the value of @type in real,
numerical sense falls within the set of values sanctioned by the enum.
It is C after all, so enums are just decorated ints, aren't they?

  reply	other threads:[~2023-06-07 16:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 11:11 [Intel-wired-lan] [PATCH iwl-next] ice: clean up __ice_aq_get_set_rss_lut() Przemek Kitszel
2023-06-06 11:11 ` Przemek Kitszel
2023-06-06 13:31 ` [Intel-wired-lan] " Alexander Lobakin
2023-06-06 13:31   ` Alexander Lobakin
2023-06-07 12:56   ` [Intel-wired-lan] " Przemek Kitszel
2023-06-07 12:56     ` Przemek Kitszel
2023-06-06 15:38 ` [Intel-wired-lan] " Simon Horman
2023-06-06 15:38   ` Simon Horman
2023-06-06 15:42   ` [Intel-wired-lan] " Alexander Lobakin
2023-06-06 15:42     ` Alexander Lobakin
2023-06-06 16:39     ` [Intel-wired-lan] " Simon Horman
2023-06-06 16:39       ` Simon Horman
2023-06-06 21:14       ` [Intel-wired-lan] " Przemek Kitszel
2023-06-06 21:14         ` Przemek Kitszel
2023-06-07  7:34         ` [Intel-wired-lan] " Simon Horman
2023-06-07  7:34           ` Simon Horman
2023-06-07 16:42           ` Jakub Kicinski [this message]
2023-06-07 16:42             ` Jakub Kicinski
2023-06-07 20:38             ` [Intel-wired-lan] " Simon Horman
2023-06-07 20:38               ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607094228.10f5b84a@kernel.org \
    --to=kuba@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.