* [PATCH v2] usb: musb-new: sunxi: remove unused define
@ 2023-06-08 18:45 Sam Edwards
2023-06-08 19:58 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Sam Edwards @ 2023-06-08 18:45 UTC (permalink / raw)
To: u-boot; +Cc: Andre Przywara, Jagan Teki, Marek Vasut, Sam Edwards
This is a remnant from when the USB controller driver managed
the reset signal itself. A patch from the very end of 2018 changed
this driver to delegate reset (and clock) management to the proper
control unit driver, but left this unused define behind.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Marek Vasut <marex@denx.de>
---
drivers/usb/musb-new/sunxi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
index 2b954601a0..85d815ad75 100644
--- a/drivers/usb/musb-new/sunxi.c
+++ b/drivers/usb/musb-new/sunxi.c
@@ -81,8 +81,6 @@
* From usbc/usbc.c
******************************************************************************/
-#define OFF_SUN6I_AHB_RESET0 0x2c0
-
struct sunxi_musb_config {
struct musb_hdrc_config *config;
bool has_sram;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] usb: musb-new: sunxi: remove unused define
2023-06-08 18:45 [PATCH v2] usb: musb-new: sunxi: remove unused define Sam Edwards
@ 2023-06-08 19:58 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2023-06-08 19:58 UTC (permalink / raw)
To: Sam Edwards, u-boot; +Cc: Andre Przywara, Jagan Teki
On 6/8/23 20:45, Sam Edwards wrote:
> This is a remnant from when the USB controller driver managed
> the reset signal itself. A patch from the very end of 2018 changed
> this driver to delegate reset (and clock) management to the proper
> control unit driver, but left this unused define behind.
>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/usb/musb-new/sunxi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
> index 2b954601a0..85d815ad75 100644
> --- a/drivers/usb/musb-new/sunxi.c
> +++ b/drivers/usb/musb-new/sunxi.c
> @@ -81,8 +81,6 @@
> * From usbc/usbc.c
> ******************************************************************************/
>
> -#define OFF_SUN6I_AHB_RESET0 0x2c0
> -
> struct sunxi_musb_config {
> struct musb_hdrc_config *config;
> bool has_sram;
Applied to usb/master, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-09 1:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-08 18:45 [PATCH v2] usb: musb-new: sunxi: remove unused define Sam Edwards
2023-06-08 19:58 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.