All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Claudiu.Beznea@microchip.com, devicetree@vger.kernel.org,
	alexandre.belloni@bootlin.com, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
	conor+dt@kernel.org, conor@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de,
	wim@linux-watchdog.org, sebastian.reichel@collabora.com,
	linux@roeck-us.net
Subject: Re: [PATCH 3/5] dt-bindings: timer: microchip,sam9x60-pit64b: convert to yaml
Date: Thu, 8 Jun 2023 14:17:07 -0600	[thread overview]
Message-ID: <20230608201707.GA3359628-robh@kernel.org> (raw)
In-Reply-To: <20230526-unsubtle-chowtime-ce329d7e5627@wendy>

On Fri, May 26, 2023 at 08:55:39AM +0100, Conor Dooley wrote:
> On Fri, May 26, 2023 at 06:41:39AM +0000, Claudiu.Beznea@microchip.com wrote:
> > On 26.05.2023 09:23, Conor Dooley wrote:
> > > On Fri, May 26, 2023 at 04:47:28AM +0000, Claudiu.Beznea@microchip.com wrote:
> > >> On 25.05.2023 20:14, Conor Dooley wrote:
> > >>>> Convert Microchip PIT64B to YAML. Along with it clock-names binding has
> > >>>> been added as the driver needs it to get PIT64B clocks.
> > >>> I don't think both of these PIT things need to have different binding
> > >>> files. 90% of it is the same, just the clock-names/number - so you can
> > >>
> > >> But these are different hardware blocks with different functionalities and
> > >> different drivers.
> > > 
> > > Having different drivers doesn't preclude having them in the same
> > > binding provided the function/description etc are more or less
> > > identical. I was confused by:
> > > 
> > > +description:
> > > +  The 64-bit periodic interval timer provides the operating system scheduler
> > > +  interrupt. It is designed to offer maximum accuracy and efficient management,
> > > +  even for systems with long response times.
> > > 
> > > +description:
> > > +  Atmel periodic interval timer provides the operating system’s scheduler
> > > +  interrupt. It is designed to offer maximum accuracy and efficient management,
> > > +  even for systems with long response time.
> > > 
> > > Those seemed like they do the same thing to me!
> > 
> > They do the same thing, they are timers... But the way they do it (from
> > hardware perspective) is totally different. With this would you still
> > prefer to have them merged?
> 
> Yeah, one binding would be my preference.

I'd probably just leave them separate if they're pretty much unrelated.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Claudiu.Beznea@microchip.com, devicetree@vger.kernel.org,
	alexandre.belloni@bootlin.com, linux-watchdog@vger.kernel.org,
	linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
	conor+dt@kernel.org, conor@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, tglx@linutronix.de,
	wim@linux-watchdog.org, sebastian.reichel@collabora.com,
	linux@roeck-us.net
Subject: Re: [PATCH 3/5] dt-bindings: timer: microchip,sam9x60-pit64b: convert to yaml
Date: Thu, 8 Jun 2023 14:17:07 -0600	[thread overview]
Message-ID: <20230608201707.GA3359628-robh@kernel.org> (raw)
In-Reply-To: <20230526-unsubtle-chowtime-ce329d7e5627@wendy>

On Fri, May 26, 2023 at 08:55:39AM +0100, Conor Dooley wrote:
> On Fri, May 26, 2023 at 06:41:39AM +0000, Claudiu.Beznea@microchip.com wrote:
> > On 26.05.2023 09:23, Conor Dooley wrote:
> > > On Fri, May 26, 2023 at 04:47:28AM +0000, Claudiu.Beznea@microchip.com wrote:
> > >> On 25.05.2023 20:14, Conor Dooley wrote:
> > >>>> Convert Microchip PIT64B to YAML. Along with it clock-names binding has
> > >>>> been added as the driver needs it to get PIT64B clocks.
> > >>> I don't think both of these PIT things need to have different binding
> > >>> files. 90% of it is the same, just the clock-names/number - so you can
> > >>
> > >> But these are different hardware blocks with different functionalities and
> > >> different drivers.
> > > 
> > > Having different drivers doesn't preclude having them in the same
> > > binding provided the function/description etc are more or less
> > > identical. I was confused by:
> > > 
> > > +description:
> > > +  The 64-bit periodic interval timer provides the operating system scheduler
> > > +  interrupt. It is designed to offer maximum accuracy and efficient management,
> > > +  even for systems with long response times.
> > > 
> > > +description:
> > > +  Atmel periodic interval timer provides the operating system’s scheduler
> > > +  interrupt. It is designed to offer maximum accuracy and efficient management,
> > > +  even for systems with long response time.
> > > 
> > > Those seemed like they do the same thing to me!
> > 
> > They do the same thing, they are timers... But the way they do it (from
> > hardware perspective) is totally different. With this would you still
> > prefer to have them merged?
> 
> Yeah, one binding would be my preference.

I'd probably just leave them separate if they're pretty much unrelated.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-08 20:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 12:55 [PATCH 0/5] dt-bindings: timer: AT91 convert to YAML Claudiu Beznea
2023-05-25 12:55 ` Claudiu Beznea
2023-05-25 12:55 ` [PATCH 1/5] dt-bindings: timer: atmel,at91sam9260-pit: convert to yaml Claudiu Beznea
2023-05-25 12:55   ` Claudiu Beznea
2023-05-25 17:10   ` Conor Dooley
2023-05-25 17:10     ` Conor Dooley
2023-05-26  4:45     ` Claudiu.Beznea
2023-05-26  4:45       ` Claudiu.Beznea
2023-05-26  1:43   ` Rob Herring
2023-05-26  1:43     ` Rob Herring
2023-05-25 12:55 ` [PATCH 2/5] ARM: dts: at91: sama7g5: keep only microchip,sam9x60-pit64b compatible for pit64b Claudiu Beznea
2023-05-25 12:55   ` Claudiu Beznea
2023-05-25 12:56 ` [PATCH 3/5] dt-bindings: timer: microchip,sam9x60-pit64b: convert to yaml Claudiu Beznea
2023-05-25 12:56   ` Claudiu Beznea
2023-05-25 17:14   ` Conor Dooley
2023-05-25 17:14     ` Conor Dooley
2023-05-26  4:47     ` Claudiu.Beznea
2023-05-26  4:47       ` Claudiu.Beznea
2023-05-26  6:23       ` Conor Dooley
2023-05-26  6:23         ` Conor Dooley
2023-05-26  6:41         ` Claudiu.Beznea
2023-05-26  6:41           ` Claudiu.Beznea
2023-05-26  7:55           ` Conor Dooley
2023-05-26  7:55             ` Conor Dooley
2023-06-08 20:17             ` Rob Herring [this message]
2023-06-08 20:17               ` Rob Herring
2026-01-02 16:03               ` Nicolas Ferre
2026-01-02 16:26                 ` Conor Dooley
2026-01-08  9:17                 ` Claudiu Beznea
2023-05-25 12:56 ` [PATCH 4/5] dt-bindings: watchdog: atmel,at91rm9200-wdt: " Claudiu Beznea
2023-05-25 12:56   ` Claudiu Beznea
2023-05-25 17:15   ` Conor Dooley
2023-05-25 17:15     ` Conor Dooley
2023-05-26  1:43   ` Rob Herring
2023-05-26  1:43     ` Rob Herring
2023-05-25 12:56 ` [PATCH 5/5] dt-bindings: timer: atmel,at91rm9200-st: " Claudiu Beznea
2023-05-25 12:56   ` Claudiu Beznea
2023-05-25 17:27   ` Conor Dooley
2023-05-25 17:27     ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608201707.GA3359628-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=sebastian.reichel@collabora.com \
    --cc=tglx@linutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.