All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	pavel@ucw.cz, sean.wang@mediatek.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Date: Fri, 9 Jun 2023 07:42:20 +0100	[thread overview]
Message-ID: <20230609064220.GF3635807@google.com> (raw)
In-Reply-To: <75d78713-fc8f-24a9-a422-2b4d57c5d488@linaro.org>

On Fri, 02 Jun 2023, Krzysztof Kozlowski wrote:

> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
> > Some PMICs have a separated WLED string output: add a property
> > `mediatek,is-wled` to indicate which LED string is a WLED.
> > 
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > index 052dccb8f2ce..904b2222a5fe 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > @@ -30,6 +30,7 @@ Optional properties for the LED child node:
> >  - label : See Documentation/devicetree/bindings/leds/common.txt
> >  - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
> >  - default-state: See Documentation/devicetree/bindings/leds/common.txt
> > +- mediatek,is-wled: LED string is connected to WLED output
> 
> Why would it matter to what the output is connected to?

Skipping this one.  Please resolve and resend.

-- 
Lee Jones [李琼斯]

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	pavel@ucw.cz, sean.wang@mediatek.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@collabora.com
Subject: Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output
Date: Fri, 9 Jun 2023 07:42:20 +0100	[thread overview]
Message-ID: <20230609064220.GF3635807@google.com> (raw)
In-Reply-To: <75d78713-fc8f-24a9-a422-2b4d57c5d488@linaro.org>

On Fri, 02 Jun 2023, Krzysztof Kozlowski wrote:

> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
> > Some PMICs have a separated WLED string output: add a property
> > `mediatek,is-wled` to indicate which LED string is a WLED.
> > 
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > index 052dccb8f2ce..904b2222a5fe 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > @@ -30,6 +30,7 @@ Optional properties for the LED child node:
> >  - label : See Documentation/devicetree/bindings/leds/common.txt
> >  - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
> >  - default-state: See Documentation/devicetree/bindings/leds/common.txt
> > +- mediatek,is-wled: LED string is connected to WLED output
> 
> Why would it matter to what the output is connected to?

Skipping this one.  Please resolve and resend.

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-09  6:42 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 11:08 [PATCH v3 0/8] Add support for MT6331 and MT6332 LEDs AngeloGioacchino Del Regno
2023-06-01 11:08 ` AngeloGioacchino Del Regno
2023-06-01 11:08 ` [PATCH v3 1/8] dt-bindings: leds: leds-mt6323: Document mt6331 compatible AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:40   ` Lee Jones
2023-06-09  6:40     ` Lee Jones
2023-06-01 11:08 ` [PATCH v3 2/8] dt-bindings: leds: leds-mt6323: Document mt6332 compatible AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:41   ` Lee Jones
2023-06-09  6:41     ` Lee Jones
2023-06-01 11:08 ` [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-02  8:32   ` Krzysztof Kozlowski
2023-06-02  8:32     ` Krzysztof Kozlowski
2023-06-09  6:42     ` Lee Jones [this message]
2023-06-09  6:42       ` Lee Jones
2023-06-09  7:51     ` AngeloGioacchino Del Regno
2023-06-09  7:51       ` AngeloGioacchino Del Regno
2023-06-13  6:59       ` Krzysztof Kozlowski
2023-06-13  6:59         ` Krzysztof Kozlowski
2023-06-14  8:33         ` AngeloGioacchino Del Regno
2023-06-14  8:33           ` AngeloGioacchino Del Regno
2023-06-01 11:08 ` [PATCH v3 4/8] leds: leds-mt6323: Specify registers and specs in platform data AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:42   ` Lee Jones
2023-06-09  6:42     ` Lee Jones
2023-06-01 11:08 ` [PATCH v3 5/8] leds: leds-mt6323: Drop MT6323_ prefix from macros and defines AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:43   ` Lee Jones
2023-06-09  6:43     ` Lee Jones
2023-06-01 11:08 ` [PATCH v3 6/8] leds: leds-mt6323: Open code and drop MT6323_CAL_HW_DUTY macro AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:43   ` Lee Jones
2023-06-09  6:43     ` Lee Jones
2023-06-01 11:08 ` [PATCH v3 7/8] leds: leds-mt6323: Add support for MT6331 leds AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:44   ` Lee Jones
2023-06-09  6:44     ` Lee Jones
2023-06-01 11:08 ` [PATCH v3 8/8] leds: leds-mt6323: Add support for WLEDs and MT6332 AngeloGioacchino Del Regno
2023-06-01 11:08   ` AngeloGioacchino Del Regno
2023-06-09  6:44   ` Lee Jones
2023-06-09  6:44     ` Lee Jones
2023-06-21 21:31   ` Nathan Chancellor
2023-06-21 21:31     ` Nathan Chancellor
2023-06-22  9:10     ` AngeloGioacchino Del Regno
2023-06-22  9:10       ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609064220.GF3635807@google.com \
    --to=lee@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.