From: Shawn Guo <shawnguo@kernel.org>
To: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH] arm64: dts: imx8mm-venice: Fix GSC vdd_bat data size.
Date: Fri, 9 Jun 2023 22:18:40 +0800 [thread overview]
Message-ID: <20230609141840.GX4199@dragon> (raw)
In-Reply-To: <20230605090442.11316-1-nicolas.cavallari@green-communications.fr>
On Mon, Jun 05, 2023 at 11:04:42AM +0200, Nicolas Cavallari wrote:
> On these boards, vdd_bat is 16bit, not 24bit. Reading them as 24bit
> values yield garbage values because of the additional byte, which is a
> configurable fan trippoint[1].
>
> So set their mode to mode_voltage_16bit = 3 instead of
> mode_voltage_24bit = 1.
>
> [1]: http://trac.gateworks.com/wiki/gsc#SystemTemperatureandVoltageMonitor
>
> Only tested on GW7100.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH] arm64: dts: imx8mm-venice: Fix GSC vdd_bat data size.
Date: Fri, 9 Jun 2023 22:18:40 +0800 [thread overview]
Message-ID: <20230609141840.GX4199@dragon> (raw)
In-Reply-To: <20230605090442.11316-1-nicolas.cavallari@green-communications.fr>
On Mon, Jun 05, 2023 at 11:04:42AM +0200, Nicolas Cavallari wrote:
> On these boards, vdd_bat is 16bit, not 24bit. Reading them as 24bit
> values yield garbage values because of the additional byte, which is a
> configurable fan trippoint[1].
>
> So set their mode to mode_voltage_16bit = 3 instead of
> mode_voltage_24bit = 1.
>
> [1]: http://trac.gateworks.com/wiki/gsc#SystemTemperatureandVoltageMonitor
>
> Only tested on GW7100.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Applied, thanks!
next prev parent reply other threads:[~2023-06-09 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 9:04 [PATCH] arm64: dts: imx8mm-venice: Fix GSC vdd_bat data size Nicolas Cavallari
2023-06-05 9:04 ` Nicolas Cavallari
2023-06-05 23:42 ` Tim Harvey
2023-06-05 23:42 ` Tim Harvey
2023-06-09 14:18 ` Shawn Guo [this message]
2023-06-09 14:18 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609141840.GX4199@dragon \
--to=shawnguo@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=nicolas.cavallari@green-communications.fr \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.