* [obsolete] mm-vmscan-move-shrinker_debugfs_remove-before-synchronize_srcu.patch removed from -mm tree
@ 2023-06-09 19:25 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2023-06-09 19:25 UTC (permalink / raw)
To: mm-commits, roman.gushchin, zhengqi.arch, akpm
The quilt patch titled
Subject: mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu()
has been removed from the -mm tree. Its filename was
mm-vmscan-move-shrinker_debugfs_remove-before-synchronize_srcu.patch
This patch was dropped because it is obsolete
------------------------------------------------------
From: Qi Zheng <zhengqi.arch@bytedance.com>
Subject: mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu()
Date: Thu, 1 Jun 2023 13:27:14 +0000
The debugfs_remove_recursive() will wait for debugfs_file_put() to return,
so there is no need to put it after synchronize_srcu() to wait for the rcu
read-side critical section to exit.
Just move it before synchronize_srcu(), which is also convenient to put
the heavy synchronize_srcu() in the delayed work later.
Link: https://lkml.kernel.org/r/20230601132714.2540707-1-qi.zheng@linux.dev
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmscan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/mm/vmscan.c~mm-vmscan-move-shrinker_debugfs_remove-before-synchronize_srcu
+++ a/mm/vmscan.c
@@ -818,11 +818,11 @@ void unregister_shrinker(struct shrinker
debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id);
mutex_unlock(&shrinker_mutex);
+ shrinker_debugfs_remove(debugfs_entry, debugfs_id);
+
atomic_inc(&shrinker_srcu_generation);
synchronize_srcu(&shrinker_srcu);
- shrinker_debugfs_remove(debugfs_entry, debugfs_id);
-
kfree(shrinker->nr_deferred);
shrinker->nr_deferred = NULL;
}
_
Patches currently in -mm which might be from zhengqi.arch@bytedance.com are
revert-mm-shrinkers-convert-shrinker_rwsem-to-mutex.patch
revert-mm-vmscan-remove-shrinker_rwsem-from-synchronize_shrinkers.patch
revert-mm-vmscan-hold-write-lock-to-reparent-shrinker-nr_deferred.patch
revert-mm-shrinkers-make-count-and-scan-in-shrinker-debugfs-lockless.patch
revert-mm-vmscan-add-shrinker_srcu_generation.patch
revert-mm-vmscan-make-memcg-slab-shrink-lockless.patch
revert-mm-vmscan-make-global-slab-shrink-lockless.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-09 19:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-09 19:25 [obsolete] mm-vmscan-move-shrinker_debugfs_remove-before-synchronize_srcu.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.