All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Detlev Casanova <detlev.casanova@collabora.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v4 3/3] net: phy: realtek: Disable clock on suspend
Date: Sat, 10 Jun 2023 01:41:58 +0800	[thread overview]
Message-ID: <202306100152.2hG4J7Ds-lkp@intel.com> (raw)
In-Reply-To: <20230605154010.49611-4-detlev.casanova@collabora.com>

Hi Detlev,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on net/main linus/master v6.4-rc5]
[cannot apply to net-next/main next-20230609]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Detlev-Casanova/net-phy-realtek-Add-optional-external-PHY-clock/20230605-234223
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230605154010.49611-4-detlev.casanova%40collabora.com
patch subject: [PATCH v4 3/3] net: phy: realtek: Disable clock on suspend
config: i386-debian-10.3 (https://download.01.org/0day-ci/archive/20230610/202306100152.2hG4J7Ds-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
        git remote add robh https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
        git fetch robh for-next
        git checkout robh/for-next
        b4 shazam https://lore.kernel.org/r/20230605154010.49611-4-detlev.casanova@collabora.com
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306100152.2hG4J7Ds-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/phy/realtek.c: In function 'rtl821x_suspend':
>> drivers/net/phy/realtek.c:434:22: error: 'struct phy_device' has no member named 'wol_enabled'; did you mean 'eee_enabled'?
     434 |         if (!phydev->wol_enabled) {
         |                      ^~~~~~~~~~~
         |                      eee_enabled
   drivers/net/phy/realtek.c: In function 'rtl821x_resume':
   drivers/net/phy/realtek.c:451:22: error: 'struct phy_device' has no member named 'wol_enabled'; did you mean 'eee_enabled'?
     451 |         if (!phydev->wol_enabled)
         |                      ^~~~~~~~~~~
         |                      eee_enabled
   drivers/net/phy/realtek.c: At top level:
>> drivers/net/phy/realtek.c:962:35: error: 'PHY_ALWAYS_CALL_SUSPEND' undeclared here (not in a function)
     962 |                 .flags          = PHY_ALWAYS_CALL_SUSPEND,
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~


vim +434 drivers/net/phy/realtek.c

   428	
   429	static int rtl821x_suspend(struct phy_device *phydev)
   430	{
   431		struct rtl821x_priv *priv = phydev->priv;
   432		int ret = 0;
   433	
 > 434		if (!phydev->wol_enabled) {
   435			ret = genphy_suspend(phydev);
   436	
   437			if (ret)
   438				return ret;
   439	
   440			clk_disable_unprepare(priv->clk);
   441		}
   442	
   443		return ret;
   444	}
   445	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2023-06-09 17:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 15:40 [PATCH v4 0/3] net: phy: realtek: Support external PHY clock Detlev Casanova
2023-06-05 15:40 ` [PATCH v4 1/3] net: phy: realtek: Add optional " Detlev Casanova
2023-06-05 15:40 ` [PATCH v4 2/3] dt-bindings: net: phy: Document support for external PHY clk Detlev Casanova
2023-06-05 15:40 ` [PATCH v4 3/3] net: phy: realtek: Disable clock on suspend Detlev Casanova
2023-06-09 17:41   ` kernel test robot [this message]
2023-06-12 14:07     ` Detlev Casanova
2023-06-05 20:33 ` [PATCH v4 0/3] net: phy: realtek: Support external PHY clock Heiner Kallweit
2023-06-07  9:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202306100152.2hG4J7Ds-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=detlev.casanova@collabora.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.