Re: [PATCH v4 3/3] net: phy: realtek: Disable clock on suspend

[Detlev Casanova <detlev.casanova@collabora.com>]

On Friday, June 9, 2023 1:41:58 P.M. EDT kernel test robot wrote:
> Hi Detlev,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on net/main linus/master v6.4-rc5]
> [cannot apply to net-next/main next-20230609]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]

Hi,

Yes, it is applied on the wrong tree, the correct tree should be net-next 
(git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git). I didn't 
know about the --base argument, I will use that in the future., thanks !

Detlev.

> url:   
> https://github.com/intel-lab-lkp/linux/commits/Detlev-Casanova/net-phy-real
> tek-Add-optional-external-PHY-clock/20230605-234223 base:  
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link:   
> https://lore.kernel.org/r/20230605154010.49611-4-detlev.casanova%40collabor
> a.com patch subject: [PATCH v4 3/3] net: phy: realtek: Disable clock on
> suspend config: i386-debian-10.3
> (https://download.01.org/0day-ci/archive/20230610/202306100152.2hG4J7Ds-lkp
> @intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build):
>         git remote add robh
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git git fetch
> robh for-next
>         git checkout robh/for-next
>         b4 shazam
> https://lore.kernel.org/r/20230605154010.49611-4-detlev.casanova@collabora.
> com # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 olddefconfig
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version
> of the same patch/commit), kindly add following tags
> 
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes:
> | https://lore.kernel.org/oe-kbuild-all/202306100152.2hG4J7Ds-lkp@intel.com
> | /
> All errors (new ones prefixed by >>):
> 
>    drivers/net/phy/realtek.c: In function 'rtl821x_suspend':
> >> drivers/net/phy/realtek.c:434:22: error: 'struct phy_device' has no
> >> member named 'wol_enabled'; did you mean 'eee_enabled'?
>      434 |         if (!phydev->wol_enabled) {
> 
>          |                      ^~~~~~~~~~~
>          |                      eee_enabled
> 
>    drivers/net/phy/realtek.c: In function 'rtl821x_resume':
>    drivers/net/phy/realtek.c:451:22: error: 'struct phy_device' has no
> member named 'wol_enabled'; did you mean 'eee_enabled'? 451 |         if
> (!phydev->wol_enabled)
> 
>          |                      ^~~~~~~~~~~
>          |                      eee_enabled
> 
>    drivers/net/phy/realtek.c: At top level:
> >> drivers/net/phy/realtek.c:962:35: error: 'PHY_ALWAYS_CALL_SUSPEND'
> >> undeclared here (not in a function)
>      962 |                 .flags          = PHY_ALWAYS_CALL_SUSPEND,
> 
>          |                                   ^~~~~~~~~~~~~~~~~~~~~~~
> 
> vim +434 drivers/net/phy/realtek.c
> 
>    428
>    429	static int rtl821x_suspend(struct phy_device *phydev)
>    430	{
>    431		struct rtl821x_priv *priv = phydev->priv;
>    432		int ret = 0;
>    433
> 
>  > 434		if (!phydev->wol_enabled) {
> 
>    435			ret = genphy_suspend(phydev);
>    436
>    437			if (ret)
>    438				return ret;
>    439
>    440			clk_disable_unprepare(priv->clk);
>    441		}
>    442
>    443		return ret;
>    444	}
>    445