* [robh:dt/header-cleanups 20/20] drivers/gpu/drm/panel/panel-novatek-nt36523.c:752:34: error: array type has incomplete element type 'struct of_device_id'
@ 2023-06-10 0:34 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-06-10 0:34 UTC (permalink / raw)
To: Rob Herring; +Cc: oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dt/header-cleanups
head: 3118a5812ec5b3b83ca38f2d1c4162ccda268c0d
commit: 3118a5812ec5b3b83ca38f2d1c4162ccda268c0d [20/20] of: header cleanups
config: openrisc-randconfig-r033-20230609 (https://download.01.org/0day-ci/archive/20230610/202306100855.MvyZ80Sp-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?id=3118a5812ec5b3b83ca38f2d1c4162ccda268c0d
git remote add robh https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
git fetch --no-tags robh dt/header-cleanups
git checkout 3118a5812ec5b3b83ca38f2d1c4162ccda268c0d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/gpu/drm/panel/
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306100855.MvyZ80Sp-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/gpu/drm/panel/panel-novatek-nt36523.c: In function 'nt36523_probe':
>> drivers/gpu/drm/panel/panel-novatek-nt36523.c:703:23: error: implicit declaration of function 'of_device_get_match_data' [-Werror=implicit-function-declaration]
703 | pinfo->desc = of_device_get_match_data(dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/panel/panel-novatek-nt36523.c:703:21: warning: assignment to 'const struct panel_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
703 | pinfo->desc = of_device_get_match_data(dev);
| ^
>> drivers/gpu/drm/panel/panel-novatek-nt36523.c:718:17: error: implicit declaration of function 'of_node_put' [-Werror=implicit-function-declaration]
718 | of_node_put(dsi1);
| ^~~~~~~~~~~
drivers/gpu/drm/panel/panel-novatek-nt36523.c: At top level:
>> drivers/gpu/drm/panel/panel-novatek-nt36523.c:752:34: error: array type has incomplete element type 'struct of_device_id'
752 | static const struct of_device_id nt36523_of_match[] = {
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-novatek-nt36523.c:752:34: warning: 'nt36523_of_match' defined but not used [-Wunused-variable]
cc1: some warnings being treated as errors
vim +752 drivers/gpu/drm/panel/panel-novatek-nt36523.c
0993234a00451e Jianhua Lu 2023-03-13 681
0993234a00451e Jianhua Lu 2023-03-13 682 static int nt36523_probe(struct mipi_dsi_device *dsi)
0993234a00451e Jianhua Lu 2023-03-13 683 {
0993234a00451e Jianhua Lu 2023-03-13 684 struct device *dev = &dsi->dev;
0993234a00451e Jianhua Lu 2023-03-13 685 struct device_node *dsi1;
0993234a00451e Jianhua Lu 2023-03-13 686 struct mipi_dsi_host *dsi1_host;
0993234a00451e Jianhua Lu 2023-03-13 687 struct panel_info *pinfo;
0993234a00451e Jianhua Lu 2023-03-13 688 const struct mipi_dsi_device_info *info;
0993234a00451e Jianhua Lu 2023-03-13 689 int i, ret;
0993234a00451e Jianhua Lu 2023-03-13 690
0993234a00451e Jianhua Lu 2023-03-13 691 pinfo = devm_kzalloc(dev, sizeof(*pinfo), GFP_KERNEL);
0993234a00451e Jianhua Lu 2023-03-13 692 if (!pinfo)
0993234a00451e Jianhua Lu 2023-03-13 693 return -ENOMEM;
0993234a00451e Jianhua Lu 2023-03-13 694
0993234a00451e Jianhua Lu 2023-03-13 695 pinfo->vddio = devm_regulator_get(dev, "vddio");
0993234a00451e Jianhua Lu 2023-03-13 696 if (IS_ERR(pinfo->vddio))
0993234a00451e Jianhua Lu 2023-03-13 697 return dev_err_probe(dev, PTR_ERR(pinfo->vddio), "failed to get vddio regulator\n");
0993234a00451e Jianhua Lu 2023-03-13 698
0993234a00451e Jianhua Lu 2023-03-13 699 pinfo->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
0993234a00451e Jianhua Lu 2023-03-13 700 if (IS_ERR(pinfo->reset_gpio))
0993234a00451e Jianhua Lu 2023-03-13 701 return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio), "failed to get reset gpio\n");
0993234a00451e Jianhua Lu 2023-03-13 702
0993234a00451e Jianhua Lu 2023-03-13 @703 pinfo->desc = of_device_get_match_data(dev);
0993234a00451e Jianhua Lu 2023-03-13 704 if (!pinfo->desc)
0993234a00451e Jianhua Lu 2023-03-13 705 return -ENODEV;
0993234a00451e Jianhua Lu 2023-03-13 706
0993234a00451e Jianhua Lu 2023-03-13 707 /* If the panel is dual dsi, register DSI1 */
0993234a00451e Jianhua Lu 2023-03-13 708 if (pinfo->desc->is_dual_dsi) {
0993234a00451e Jianhua Lu 2023-03-13 709 info = &pinfo->desc->dsi_info;
0993234a00451e Jianhua Lu 2023-03-13 710
0993234a00451e Jianhua Lu 2023-03-13 711 dsi1 = of_graph_get_remote_node(dsi->dev.of_node, 1, -1);
0993234a00451e Jianhua Lu 2023-03-13 712 if (!dsi1) {
0993234a00451e Jianhua Lu 2023-03-13 713 dev_err(dev, "cannot get secondary DSI node.\n");
0993234a00451e Jianhua Lu 2023-03-13 714 return -ENODEV;
0993234a00451e Jianhua Lu 2023-03-13 715 }
0993234a00451e Jianhua Lu 2023-03-13 716
0993234a00451e Jianhua Lu 2023-03-13 717 dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
0993234a00451e Jianhua Lu 2023-03-13 @718 of_node_put(dsi1);
0993234a00451e Jianhua Lu 2023-03-13 719 if (!dsi1_host)
0993234a00451e Jianhua Lu 2023-03-13 720 return dev_err_probe(dev, -EPROBE_DEFER, "cannot get secondary DSI host\n");
0993234a00451e Jianhua Lu 2023-03-13 721
0993234a00451e Jianhua Lu 2023-03-13 722 pinfo->dsi[1] = mipi_dsi_device_register_full(dsi1_host, info);
0993234a00451e Jianhua Lu 2023-03-13 723 if (!pinfo->dsi[1]) {
0993234a00451e Jianhua Lu 2023-03-13 724 dev_err(dev, "cannot get secondary DSI device\n");
0993234a00451e Jianhua Lu 2023-03-13 725 return -ENODEV;
0993234a00451e Jianhua Lu 2023-03-13 726 }
0993234a00451e Jianhua Lu 2023-03-13 727 }
0993234a00451e Jianhua Lu 2023-03-13 728
0993234a00451e Jianhua Lu 2023-03-13 729 pinfo->dsi[0] = dsi;
0993234a00451e Jianhua Lu 2023-03-13 730 mipi_dsi_set_drvdata(dsi, pinfo);
0993234a00451e Jianhua Lu 2023-03-13 731 drm_panel_init(&pinfo->panel, dev, &nt36523_panel_funcs, DRM_MODE_CONNECTOR_DSI);
0993234a00451e Jianhua Lu 2023-03-13 732
0993234a00451e Jianhua Lu 2023-03-13 733 ret = drm_panel_of_backlight(&pinfo->panel);
0993234a00451e Jianhua Lu 2023-03-13 734 if (ret)
0993234a00451e Jianhua Lu 2023-03-13 735 return dev_err_probe(dev, ret, "failed to get backlight\n");
0993234a00451e Jianhua Lu 2023-03-13 736
0993234a00451e Jianhua Lu 2023-03-13 737 drm_panel_add(&pinfo->panel);
0993234a00451e Jianhua Lu 2023-03-13 738
0993234a00451e Jianhua Lu 2023-03-13 739 for (i = 0; i < DSI_NUM_MIN + pinfo->desc->is_dual_dsi; i++) {
0993234a00451e Jianhua Lu 2023-03-13 740 pinfo->dsi[i]->lanes = pinfo->desc->lanes;
0993234a00451e Jianhua Lu 2023-03-13 741 pinfo->dsi[i]->format = pinfo->desc->format;
0993234a00451e Jianhua Lu 2023-03-13 742 pinfo->dsi[i]->mode_flags = pinfo->desc->mode_flags;
0993234a00451e Jianhua Lu 2023-03-13 743
0993234a00451e Jianhua Lu 2023-03-13 744 ret = mipi_dsi_attach(pinfo->dsi[i]);
0993234a00451e Jianhua Lu 2023-03-13 745 if (ret < 0)
0993234a00451e Jianhua Lu 2023-03-13 746 return dev_err_probe(dev, ret, "cannot attach to DSI%d host.\n", i);
0993234a00451e Jianhua Lu 2023-03-13 747 }
0993234a00451e Jianhua Lu 2023-03-13 748
0993234a00451e Jianhua Lu 2023-03-13 749 return 0;
0993234a00451e Jianhua Lu 2023-03-13 750 }
0993234a00451e Jianhua Lu 2023-03-13 751
0993234a00451e Jianhua Lu 2023-03-13 @752 static const struct of_device_id nt36523_of_match[] = {
0993234a00451e Jianhua Lu 2023-03-13 753 {
0993234a00451e Jianhua Lu 2023-03-13 754 .compatible = "xiaomi,elish-boe-nt36523",
0993234a00451e Jianhua Lu 2023-03-13 755 .data = &elish_boe_desc,
0993234a00451e Jianhua Lu 2023-03-13 756 },
0993234a00451e Jianhua Lu 2023-03-13 757 {
0993234a00451e Jianhua Lu 2023-03-13 758 .compatible = "xiaomi,elish-csot-nt36523",
0993234a00451e Jianhua Lu 2023-03-13 759 .data = &elish_csot_desc,
0993234a00451e Jianhua Lu 2023-03-13 760 },
0993234a00451e Jianhua Lu 2023-03-13 761 {},
0993234a00451e Jianhua Lu 2023-03-13 762 };
0993234a00451e Jianhua Lu 2023-03-13 763 MODULE_DEVICE_TABLE(of, nt36523_of_match);
0993234a00451e Jianhua Lu 2023-03-13 764
:::::: The code at line 752 was first introduced by commit
:::::: 0993234a00451e0a5c3e47d8b0f2e01dac6cedbf drm/panel: Add driver for Novatek NT36523
:::::: TO: Jianhua Lu <lujianhua000@gmail.com>
:::::: CC: Neil Armstrong <neil.armstrong@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-10 0:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-10 0:34 [robh:dt/header-cleanups 20/20] drivers/gpu/drm/panel/panel-novatek-nt36523.c:752:34: error: array type has incomplete element type 'struct of_device_id' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.