From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Parav Pandit <parav@nvidia.com>, Jason Wang <jasowang@redhat.com>
Subject: [virtio-comment] Re: About custom device counter
Date: Mon, 12 Jun 2023 02:25:42 -0400 [thread overview]
Message-ID: <20230612022526-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1686550355.2503424-1-xuanzhuo@linux.alibaba.com>
On Mon, Jun 12, 2023 at 02:12:35PM +0800, Xuan Zhuo wrote:
> We hope to support device custom counter. That is, virtio spec provides a
> channel for driver and device, and both key and value are provided by device.
>
> We discussed this issue earlier, and after some internal practice, I think it is
> still necessary to discuss this again.
>
> It is very important, each cloud vendor will always have some special counters,
> these counters may not exist in another vendor. At the same time, if we have
> to discuss it in the spec every time we add a counter, or add a feature, I
> think it is very inconvenient. Manufacturers may add some new counters at any
> time based on some new requirements. Some counters may also be removed at any
> time.
>
> Of course I know that doing this might hurt migration. But what I want to say is,
> why does it affect live migration? These counters we plan to give to users
> through ethtool -S, and some changes have taken place in the ethtool counters
> output by users. Does this have any practical impact? Or do we directly use
> some other output in a way, we can clearly tell the user that these counters
> may change during the migration process. For example, the driver is migrated
> to some new devices. These devices support some new counters. I think users
> should be able to see these new counters. These new counters may be the
> purpose of the migration.
>
> We don't need to support live migration at this point.
>
> Thanks.
Why not just document the thing?
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org,
Parav Pandit <parav@nvidia.com>, Jason Wang <jasowang@redhat.com>
Subject: [virtio-dev] Re: About custom device counter
Date: Mon, 12 Jun 2023 02:25:42 -0400 [thread overview]
Message-ID: <20230612022526-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1686550355.2503424-1-xuanzhuo@linux.alibaba.com>
On Mon, Jun 12, 2023 at 02:12:35PM +0800, Xuan Zhuo wrote:
> We hope to support device custom counter. That is, virtio spec provides a
> channel for driver and device, and both key and value are provided by device.
>
> We discussed this issue earlier, and after some internal practice, I think it is
> still necessary to discuss this again.
>
> It is very important, each cloud vendor will always have some special counters,
> these counters may not exist in another vendor. At the same time, if we have
> to discuss it in the spec every time we add a counter, or add a feature, I
> think it is very inconvenient. Manufacturers may add some new counters at any
> time based on some new requirements. Some counters may also be removed at any
> time.
>
> Of course I know that doing this might hurt migration. But what I want to say is,
> why does it affect live migration? These counters we plan to give to users
> through ethtool -S, and some changes have taken place in the ethtool counters
> output by users. Does this have any practical impact? Or do we directly use
> some other output in a way, we can clearly tell the user that these counters
> may change during the migration process. For example, the driver is migrated
> to some new devices. These devices support some new counters. I think users
> should be able to see these new counters. These new counters may be the
> purpose of the migration.
>
> We don't need to support live migration at this point.
>
> Thanks.
Why not just document the thing?
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-06-12 6:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 6:12 [virtio-comment] About custom device counter Xuan Zhuo
2023-06-12 6:12 ` [virtio-dev] " Xuan Zhuo
2023-06-12 6:25 ` Michael S. Tsirkin [this message]
2023-06-12 6:25 ` [virtio-dev] " Michael S. Tsirkin
2023-06-12 11:27 ` [virtio-comment] " Xuan Zhuo
2023-06-12 11:27 ` [virtio-dev] " Xuan Zhuo
2023-06-13 9:02 ` Michael S. Tsirkin
2023-06-13 9:02 ` [virtio-dev] " Michael S. Tsirkin
2023-06-15 6:23 ` Xuan Zhuo
2023-06-15 6:23 ` [virtio-dev] " Xuan Zhuo
2023-06-16 0:57 ` Jason Wang
2023-06-16 0:57 ` [virtio-dev] " Jason Wang
2023-06-16 1:36 ` Xuan Zhuo
2023-06-16 1:36 ` [virtio-dev] " Xuan Zhuo
2023-06-16 14:42 ` Michael S. Tsirkin
2023-06-16 14:42 ` [virtio-dev] " Michael S. Tsirkin
2023-06-16 14:13 ` Michael S. Tsirkin
2023-06-16 14:13 ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 1:44 ` Xuan Zhuo
2023-06-19 1:44 ` [virtio-dev] " Xuan Zhuo
2023-06-19 12:33 ` Parav Pandit
2023-06-19 12:33 ` [virtio-dev] " Parav Pandit
2023-06-19 14:20 ` Michael S. Tsirkin
2023-06-19 14:20 ` [virtio-dev] " Michael S. Tsirkin
2023-06-19 20:43 ` Parav Pandit
2023-06-19 20:43 ` [virtio-dev] " Parav Pandit
2023-06-20 2:45 ` Xuan Zhuo
2023-06-20 2:45 ` [virtio-dev] " Xuan Zhuo
2023-06-19 14:25 ` Michael S. Tsirkin
2023-06-19 14:25 ` [virtio-dev] " Michael S. Tsirkin
2023-06-20 2:55 ` Xuan Zhuo
2023-06-20 2:55 ` [virtio-dev] " Xuan Zhuo
2023-06-13 1:57 ` [virtio-comment] " Parav Pandit
2023-06-13 1:57 ` [virtio-dev] " Parav Pandit
2023-06-15 6:35 ` [virtio-comment] " Xuan Zhuo
2023-06-15 6:35 ` [virtio-dev] " Xuan Zhuo
2023-06-19 20:40 ` [virtio-comment] " Parav Pandit
2023-06-19 20:40 ` [virtio-dev] " Parav Pandit
2023-06-20 2:39 ` [virtio-comment] " Xuan Zhuo
2023-06-20 2:39 ` [virtio-dev] " Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230612022526-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.