[Intel-wired-lan] [PATCH] net/e1000: Fix single statement blocks warning

[Intel-wired-lan] [PATCH] net/e1000: Fix single statement blocks warning

[Tree Davies]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-net-e1000-Fix-single-statement-blocks-warning.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From e92897ab5e93b8827d1654a0171bc53ab478ce49 Mon Sep 17 00:00:00 2001
From: Tree Davies <tdavies@darkphysics.net>
Date: Sun, 11 Jun 2023 14:41:31 -0700
Subject: [PATCH] net/e1000: Fix single statement blocks warning

This patch fixes checkpatch.pl warning of type:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index da6e303ad99b..accc2bd7c35c 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -259,9 +259,8 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
 
 	err = request_irq(adapter->pdev->irq, handler, irq_flags, netdev->name,
 			  netdev);
-	if (err) {
+	if (err)
 		e_err(probe, "Unable to allocate interrupt Error: %d\n", err);
-	}
 
 	return err;
 }
-- 
2.30.2


[-- Attachment #3: Type: text/plain, Size: 162 bytes --]

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[PATCH] net/e1000: Fix single statement blocks warning

[Tree Davies]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-net-e1000-Fix-single-statement-blocks-warning.patch --]
[-- Type: text/x-diff, Size: 1040 bytes --]

From e92897ab5e93b8827d1654a0171bc53ab478ce49 Mon Sep 17 00:00:00 2001
From: Tree Davies <tdavies@darkphysics.net>
Date: Sun, 11 Jun 2023 14:41:31 -0700
Subject: [PATCH] net/e1000: Fix single statement blocks warning

This patch fixes checkpatch.pl warning of type:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/net/ethernet/intel/e1000/e1000_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index da6e303ad99b..accc2bd7c35c 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -259,9 +259,8 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
 
 	err = request_irq(adapter->pdev->irq, handler, irq_flags, netdev->name,
 			  netdev);
-	if (err) {
+	if (err)
 		e_err(probe, "Unable to allocate interrupt Error: %d\n", err);
-	}
 
 	return err;
 }
-- 
2.30.2

Re: [Intel-wired-lan] [PATCH] net/e1000: Fix single statement blocks warning

[Jakub Kicinski]

On Sun, 11 Jun 2023 15:21:36 -0700 Tree Davies wrote:
> This patch fixes checkpatch.pl warning of type:
> WARNING: braces {} are not necessary for single statement blocks

We don't accept pure checkpatch "fixes" in networking, sorry.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [PATCH] net/e1000: Fix single statement blocks warning

[Jakub Kicinski]

On Sun, 11 Jun 2023 15:21:36 -0700 Tree Davies wrote:
> This patch fixes checkpatch.pl warning of type:
> WARNING: braces {} are not necessary for single statement blocks

We don't accept pure checkpatch "fixes" in networking, sorry.