All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 0/2] mtd: spi-nor: Support for another sst flash
Date: Mon, 12 Jun 2023 19:06:26 +0200	[thread overview]
Message-ID: <20230612190626.7a6ee8d6@xps-13> (raw)
In-Reply-To: <b5c403ad-f8d2-5f00-e345-ef412a706544@linaro.org>

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:03:55 +0100:

> On 6/9/23 15:43, Miquel Raynal wrote:
> > Hello Tudor,  
> 
> Hi, Miquel!
> 
> > 
> > Here are a couple of patches adding support for the sst26vf032b spi-nor,
> > nothing specific here. I hope I ran all the required tests correctly,
> > otherwise let me know.  
> 
> The tests are fine, thanks. I think it's debatable whether we include
> the output of the tests in the commit message or in the comments section
> below the --- line, but I'm fine either way.

I have a slight preference to have them in the commit log, this way
they are part of the git history and easier to find. But I agree, since
we now have well tracked mailing lists, my concerns might slowly go
away.

> I had some comments for the patches, I'll let you read them.

Yep, I'll make additional tests and see what I can come up with.

> Cheers,
> ta
> > 
> > Cheers,
> > Miquèl
> > 
> > Miquel Raynal (2):
> >   dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
> >   mtd: spi-nor: Add support for sst26vf032b flash
> > 
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
> >  drivers/mtd/spi-nor/sst.c                                | 4 ++++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >   


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Michael Walle <michael@walle.cc>,
	linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 0/2] mtd: spi-nor: Support for another sst flash
Date: Mon, 12 Jun 2023 19:06:26 +0200	[thread overview]
Message-ID: <20230612190626.7a6ee8d6@xps-13> (raw)
In-Reply-To: <b5c403ad-f8d2-5f00-e345-ef412a706544@linaro.org>

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 12 Jun 2023 11:03:55 +0100:

> On 6/9/23 15:43, Miquel Raynal wrote:
> > Hello Tudor,  
> 
> Hi, Miquel!
> 
> > 
> > Here are a couple of patches adding support for the sst26vf032b spi-nor,
> > nothing specific here. I hope I ran all the required tests correctly,
> > otherwise let me know.  
> 
> The tests are fine, thanks. I think it's debatable whether we include
> the output of the tests in the commit message or in the comments section
> below the --- line, but I'm fine either way.

I have a slight preference to have them in the commit log, this way
they are part of the git history and easier to find. But I agree, since
we now have well tracked mailing lists, my concerns might slowly go
away.

> I had some comments for the patches, I'll let you read them.

Yep, I'll make additional tests and see what I can come up with.

> Cheers,
> ta
> > 
> > Cheers,
> > Miquèl
> > 
> > Miquel Raynal (2):
> >   dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series
> >   mtd: spi-nor: Add support for sst26vf032b flash
> > 
> >  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
> >  drivers/mtd/spi-nor/sst.c                                | 4 ++++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >   


Thanks,
Miquèl

  reply	other threads:[~2023-06-12 17:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 14:43 [PATCH 0/2] mtd: spi-nor: Support for another sst flash Miquel Raynal
2023-06-09 14:43 ` Miquel Raynal
2023-06-09 14:43 ` [PATCH 1/2] dt-bindings: mtd: spi-nor: Document sst26vf0xxb flash series Miquel Raynal
2023-06-09 14:43   ` Miquel Raynal
2023-06-12 10:00   ` Tudor Ambarus
2023-06-12 10:00     ` Tudor Ambarus
2023-06-15 14:42     ` Miquel Raynal
2023-06-15 14:42       ` Miquel Raynal
2023-06-09 14:43 ` [PATCH 2/2] mtd: spi-nor: Add support for sst26vf032b flash Miquel Raynal
2023-06-09 14:43   ` Miquel Raynal
2023-06-12  9:57   ` Tudor Ambarus
2023-06-12  9:57     ` Tudor Ambarus
2023-06-13 13:34   ` Michael Walle
2023-06-13 13:34     ` Michael Walle
2023-06-14  6:56     ` Tudor Ambarus
2023-06-14  6:56       ` Tudor Ambarus
2023-06-14  7:04       ` Michael Walle
2023-06-14  7:04         ` Michael Walle
2023-06-14  7:13         ` Tudor Ambarus
2023-06-14  7:13           ` Tudor Ambarus
2023-06-14  7:25           ` Michael Walle
2023-06-14  7:25             ` Michael Walle
2023-06-12 10:03 ` [PATCH 0/2] mtd: spi-nor: Support for another sst flash Tudor Ambarus
2023-06-12 10:03   ` Tudor Ambarus
2023-06-12 17:06   ` Miquel Raynal [this message]
2023-06-12 17:06     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612190626.7a6ee8d6@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.