All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "jim.tsai" <Wei-chin.Tsai@mediatek.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	wsd_upstream@mediatek.com, mel.lee@mediatek.com,
	ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions
Date: Mon, 12 Jun 2023 18:37:02 +0200	[thread overview]
Message-ID: <2023061226-repugnant-upstate-a2b4@gregkh> (raw)
In-Reply-To: <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com>

On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> +static void class_create_release(struct class *cls)
> +{
> +	/*do nothing because the mbraink class is not from malloc*/
> +}

Then the code is totally broken and wrong :(

Please just use the misc device api instead, it is much simpler and
doesn't have these types of errors.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "jim.tsai" <Wei-chin.Tsai@mediatek.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	wsd_upstream@mediatek.com, mel.lee@mediatek.com,
	ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/1] process: export symbols for fork/exit tracing functions
Date: Mon, 12 Jun 2023 18:37:02 +0200	[thread overview]
Message-ID: <2023061226-repugnant-upstate-a2b4@gregkh> (raw)
In-Reply-To: <20230612151545.17810-1-Wei-chin.Tsai@mediatek.com>

On Mon, Jun 12, 2023 at 11:15:41PM +0800, jim.tsai wrote:
> +static void class_create_release(struct class *cls)
> +{
> +	/*do nothing because the mbraink class is not from malloc*/
> +}

Then the code is totally broken and wrong :(

Please just use the misc device api instead, it is much simpler and
doesn't have these types of errors.

thanks,

greg k-h

  parent reply	other threads:[~2023-06-12 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 15:15 [PATCH v1 1/1] process: export symbols for fork/exit tracing functions jim.tsai
2023-06-12 16:35 ` Greg Kroah-Hartman
2023-06-12 16:35   ` Greg Kroah-Hartman
2023-06-12 16:35 ` Greg Kroah-Hartman
2023-06-12 16:35   ` Greg Kroah-Hartman
2023-06-12 16:37 ` Greg Kroah-Hartman [this message]
2023-06-12 16:37   ` Greg Kroah-Hartman
2023-06-13  9:12   ` Wei-chin Tsai (蔡維晉)
2023-06-13  9:18     ` gregkh
2023-06-13  9:18       ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023061226-repugnant-upstate-a2b4@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Wei-chin.Tsai@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=ivan.tseng@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mel.lee@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.