All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	p.zabel@pengutronix.de, jirislaby@kernel.org,
	tmaimon77@gmail.com, catalin.marinas@arm.com, will@kernel.org,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, arnd@arndb.de, soc@kernel.org,
	schung@nuvoton.com, mjchen@nuvoton.com,
	Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v14 1/1] tty: serial: Add Nuvoton ma35d1 serial driver support
Date: Tue, 13 Jun 2023 12:29:36 +0200	[thread overview]
Message-ID: <2023061325-distant-gaffe-8871@gregkh> (raw)
In-Reply-To: <20230612025355.547871-2-ychuang570808@gmail.com>

On Mon, Jun 12, 2023 at 02:53:55AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
> 
> This adds UART and console driver for Nuvoton ma35d1 Soc.
> It supports full-duplex communication, FIFO control, and
> hardware flow control.

You don't specify here what your tty device name is going to be, why?

It's not written anywhere, is that intentional?

Same for your tty major/minor, what numbers are you using that might
also be in use by a different device in the system?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
	p.zabel@pengutronix.de, jirislaby@kernel.org,
	tmaimon77@gmail.com, catalin.marinas@arm.com, will@kernel.org,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, arnd@arndb.de, soc@kernel.org,
	schung@nuvoton.com, mjchen@nuvoton.com,
	Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v14 1/1] tty: serial: Add Nuvoton ma35d1 serial driver support
Date: Tue, 13 Jun 2023 12:29:36 +0200	[thread overview]
Message-ID: <2023061325-distant-gaffe-8871@gregkh> (raw)
In-Reply-To: <20230612025355.547871-2-ychuang570808@gmail.com>

On Mon, Jun 12, 2023 at 02:53:55AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
> 
> This adds UART and console driver for Nuvoton ma35d1 Soc.
> It supports full-duplex communication, FIFO control, and
> hardware flow control.

You don't specify here what your tty device name is going to be, why?

It's not written anywhere, is that intentional?

Same for your tty major/minor, what numbers are you using that might
also be in use by a different device in the system?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-06-13 10:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12  2:53 [PATCH v14 0/1] Introduce Nuvoton ma35d1 SoC Jacky Huang
2023-06-12  2:53 ` [PATCH v14 1/1] tty: serial: Add Nuvoton ma35d1 serial driver support Jacky Huang
2023-06-13  9:36   ` Ilpo Järvinen
2023-06-13  9:36     ` Ilpo Järvinen
2023-06-13 10:28   ` Greg KH
2023-06-13 10:28     ` Greg KH
2023-06-13 10:58     ` Jacky Huang
2023-06-13 10:58       ` Jacky Huang
2023-06-13 14:49       ` Greg KH
2023-06-13 14:49         ` Greg KH
2023-06-13 15:44         ` Arnd Bergmann
2023-06-13 15:44           ` Arnd Bergmann
2023-06-14  4:57           ` Jiri Slaby
2023-06-14  4:57             ` Jiri Slaby
2023-06-15 10:19           ` Greg Kroah-Hartman
2023-06-15 10:19             ` Greg Kroah-Hartman
2023-06-15 10:46             ` Jacky Huang
2023-06-15 10:46               ` Jacky Huang
2023-06-15 11:11               ` Greg Kroah-Hartman
2023-06-15 11:11                 ` Greg Kroah-Hartman
2023-06-15 14:01             ` Arnd Bergmann
2023-06-15 14:01               ` Arnd Bergmann
2023-06-15 15:00               ` Greg Kroah-Hartman
2023-06-15 15:00                 ` Greg Kroah-Hartman
2023-06-15 16:11                 ` Arnd Bergmann
2023-06-15 16:11                   ` Arnd Bergmann
2023-06-13 10:29   ` Greg KH [this message]
2023-06-13 10:29     ` Greg KH
2023-06-13 11:03     ` Jacky Huang
2023-06-13 11:03       ` Jacky Huang
2023-06-13 14:48       ` Greg KH
2023-06-13 14:48         ` Greg KH
2023-06-14  1:18         ` Jacky Huang
2023-06-14  1:18           ` Jacky Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023061325-distant-gaffe-8871@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jirislaby@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mjchen@nuvoton.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=schung@nuvoton.com \
    --cc=soc@kernel.org \
    --cc=tmaimon77@gmail.com \
    --cc=will@kernel.org \
    --cc=ychuang3@nuvoton.com \
    --cc=ychuang570808@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.