From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<richardbgobert@gmail.com>
Subject: Re: [PATCH net-next] gro: move the tc_ext comparison to a helper
Date: Wed, 14 Jun 2023 10:55:16 -0700 [thread overview]
Message-ID: <20230614105516.3cd35d0c@kernel.org> (raw)
In-Reply-To: <81d765b3-8545-8791-4d1e-3b0f0dba39c0@huawei.com>
On Wed, 14 Jun 2023 20:58:53 +0800 Yunsheng Lin wrote:
> > +static void gro_list_prepare_tc_ext(const struct sk_buff *skb,
> > + const struct sk_buff *p,
> > + unsigned long *diffs)
>
> Isn't it more common to do something like below?
>
> static unsigned long gro_list_prepare_tc_ext(const struct sk_buff *skb,
> const struct sk_buff *p,
> unsigned long diffs)
>
> Is it because the resulting machine code is bigger for the above
> case?
Not really, just laziness - the above is more typing.
I guess avoiding output args is worth while, so between this and
Simon's comment - let me respin.
--
pw-bot: cr
prev parent reply other threads:[~2023-06-14 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 20:51 [PATCH net-next] gro: move the tc_ext comparison to a helper Jakub Kicinski
2023-06-14 12:23 ` Simon Horman
2023-06-14 17:44 ` Jakub Kicinski
2023-06-14 18:06 ` Simon Horman
2023-06-14 12:58 ` Yunsheng Lin
2023-06-14 17:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614105516.3cd35d0c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.