From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, richardbgobert@gmail.com
Subject: Re: [PATCH net-next] gro: move the tc_ext comparison to a helper
Date: Wed, 14 Jun 2023 20:06:00 +0200 [thread overview]
Message-ID: <ZIoBiOQIODCLFYgq@corigine.com> (raw)
In-Reply-To: <20230614104449.2aa6ac41@kernel.org>
On Wed, Jun 14, 2023 at 10:44:49AM -0700, Jakub Kicinski wrote:
> On Wed, 14 Jun 2023 14:23:21 +0200 Simon Horman wrote:
> > I like your patch, and I think it is a good improvement,
> > but I find the patch description slightly confusing.
> >
> > In my understanding of things this patch is doing two things:
> >
> > 1) Moving code into a helper
> > 2) Eliminating a check on CONFIG_SKB_EXTENSIONS,
> > presumably because it is selected by NET_TC_SKB_EXT.
>
> Ah, I thought removing the check for CONFIG_SKB_EXTENSIONS
> is not worth mentioning. The double ifdefs I was talking about
> was the fact that we need an ifdef both around the variable
> declarations and the comparisons themselves.
Ok, now I understand. Looks good :)
next prev parent reply other threads:[~2023-06-14 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 20:51 [PATCH net-next] gro: move the tc_ext comparison to a helper Jakub Kicinski
2023-06-14 12:23 ` Simon Horman
2023-06-14 17:44 ` Jakub Kicinski
2023-06-14 18:06 ` Simon Horman [this message]
2023-06-14 12:58 ` Yunsheng Lin
2023-06-14 17:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIoBiOQIODCLFYgq@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.