From: Jakub Kicinski <kuba@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [PATCH net-next] eth: fs_enet: fix print format for resource size
Date: Wed, 14 Jun 2023 21:22:59 -0700 [thread overview]
Message-ID: <20230614212259.1e19900c@kernel.org> (raw)
In-Reply-To: <4ebd2741-1788-dc05-2d04-448f3fea17ab@infradead.org>
On Wed, 14 Jun 2023 21:02:33 -0700 Randy Dunlap wrote:
> On 6/14/23 20:52, Jakub Kicinski wrote:
> > Randy forwarded report from Stephen that on PowerPC:
>
> Stephen forwarded report from Randy?
>
> netdev & pantelis were cc-ed...
Ah, I misread, you were reporting to Stephen the status for the latest
linux-next!
https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/
Seems obvious in hindsight, sorry. I'll reword when applying.
> > drivers/net/ethernet/freescale/fs_enet/mii-fec.c: In function 'fs_enet_mdio_probe':
> > drivers/net/ethernet/freescale/fs_enet/mii-fec.c:130:50: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
> > 130 | snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
> > | ~^ ~~~~~~~~~
> > | | |
> > | | resource_size_t {aka long long unsigned int}
> > | unsigned int
> > | %llx
> >
> > Use the right print format.
> >
> > Untested, I can't repro this warning myself. With or without
> > the patch mpc512x_defconfig builds just fine.
> >
> > Link: https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > ---
> > CC: Randy Dunlap <rdunlap@infradead.org>
> > CC: pantelis.antoniou@gmail.com
> > CC: linuxppc-dev@lists.ozlabs.org
>
> I'm using gcc-12.2.0.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thank you! GCC 11.1 here, FWIW.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, pantelis.antoniou@gmail.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next] eth: fs_enet: fix print format for resource size
Date: Wed, 14 Jun 2023 21:22:59 -0700 [thread overview]
Message-ID: <20230614212259.1e19900c@kernel.org> (raw)
In-Reply-To: <4ebd2741-1788-dc05-2d04-448f3fea17ab@infradead.org>
On Wed, 14 Jun 2023 21:02:33 -0700 Randy Dunlap wrote:
> On 6/14/23 20:52, Jakub Kicinski wrote:
> > Randy forwarded report from Stephen that on PowerPC:
>
> Stephen forwarded report from Randy?
>
> netdev & pantelis were cc-ed...
Ah, I misread, you were reporting to Stephen the status for the latest
linux-next!
https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/
Seems obvious in hindsight, sorry. I'll reword when applying.
> > drivers/net/ethernet/freescale/fs_enet/mii-fec.c: In function 'fs_enet_mdio_probe':
> > drivers/net/ethernet/freescale/fs_enet/mii-fec.c:130:50: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
> > 130 | snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
> > | ~^ ~~~~~~~~~
> > | | |
> > | | resource_size_t {aka long long unsigned int}
> > | unsigned int
> > | %llx
> >
> > Use the right print format.
> >
> > Untested, I can't repro this warning myself. With or without
> > the patch mpc512x_defconfig builds just fine.
> >
> > Link: https://lore.kernel.org/all/8f9f8d38-d9c7-9f1b-feb0-103d76902d14@infradead.org/
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > ---
> > CC: Randy Dunlap <rdunlap@infradead.org>
> > CC: pantelis.antoniou@gmail.com
> > CC: linuxppc-dev@lists.ozlabs.org
>
> I'm using gcc-12.2.0.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thank you! GCC 11.1 here, FWIW.
next prev parent reply other threads:[~2023-06-15 4:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 3:52 [PATCH net-next] eth: fs_enet: fix print format for resource size Jakub Kicinski
2023-06-15 3:52 ` Jakub Kicinski
2023-06-15 4:02 ` Randy Dunlap
2023-06-15 4:02 ` Randy Dunlap
2023-06-15 4:22 ` Jakub Kicinski [this message]
2023-06-15 4:22 ` Jakub Kicinski
2023-06-16 6:00 ` patchwork-bot+netdevbpf
2023-06-16 6:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614212259.1e19900c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.