All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v2] drm/i915/display/lspcon: Increase LSPCON mode settle timeout
@ 2023-06-14 23:54 ` Pablo Ceballos
  0 siblings, 0 replies; 12+ messages in thread
From: Pablo Ceballos @ 2023-06-14 23:54 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter
  Cc: intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi, Sam Ravnborg,
	Pablo Ceballos

This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled",
followed by link training errors. Intel engineers recommended increasing
this timeout and that does resolve the issue.

On some CometLake-based device designs the Parade PS175 takes more than
400ms to settle in PCON mode. 100 reboot trials on one device resulted
in a median settle time of 440ms and a maximum of 444ms. Even after
increasing the timeout to 500ms, 2% of devices still had this error. So
this increases the timeout to 800ms.

Signed-off-by: Pablo Ceballos <pceballos@google.com>
---

Changelog since v1:
- Added more details in the commit message

 drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index bb3b5355a0d9..d7299fdc43ad 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -167,7 +167,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
 	drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
 		    lspcon_mode_name(mode));
 
-	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
+	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
 	if (current_mode != mode)
 		drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
 
-- 
2.41.0.162.gfafddb0af9-goog


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-07-10  4:03 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-14 23:54 [Intel-gfx] [PATCH v2] drm/i915/display/lspcon: Increase LSPCON mode settle timeout Pablo Ceballos
2023-06-14 23:54 ` Pablo Ceballos
2023-06-14 23:54 ` Pablo Ceballos
2023-06-15  4:35 ` [Intel-gfx] " Nautiyal, Ankit K
2023-06-15  4:35   ` Nautiyal, Ankit K
2023-07-07 19:34   ` Pablo Ceballos
2023-07-07 19:34     ` Pablo Ceballos
2023-07-07 19:34     ` Pablo Ceballos
2023-07-10  4:02     ` Nautiyal, Ankit K
2023-07-10  4:02       ` Nautiyal, Ankit K
2023-07-10  4:02       ` Nautiyal, Ankit K
2023-06-15  7:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev3) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.