From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Eric DeVolder <eric.devolder@oracle.com>,
linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
chenhuacai@kernel.org, geert@linux-m68k.org,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, ysato@users.osdn.me, dalias@libc.org,
glaubitz@physik.fu-berlin.de, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
86@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org, linus.walleij@linaro.org,
thunder.leizhen@huawei.com, hpa@zytor.com, kernel@xen0n.name,
ardb@kernel.org, tsi@tuyoix.net, agordeev@linux.ibm.com,
paulmck@kernel.org, bhe@redhat.com, masahiroy@kernel.org,
konrad.wilk@oracle.com, sebastian.reichel@collabora.com,
samitolvanen@google.com, ojeda@kernel.org,
juerg.haefliger@canonical.com, borntraeger@linux.ibm.com,
frederic@kernel.org, arnd@arndb.de, mhiramat@kernel.org,
aou@eecs.berkeley.edu, keescook@chromium.org, gor@linux.ibm.com,
anshuman.khandual@arm.com, hca@linux.ibm.com, xin3.li@intel.com,
npiggin@gmail.com, rmk+kernel@armlinux.org.uk,
paul.walmsley@sifive.com, boris.ostrovsky@oracle.com,
ziy@nvidia.com, hbathini@linux.ibm.com,
gregkh@linuxfoundation.org, kirill.shutemov@linux.intel.com,
ndesaulniers@google.com, sourabhjain@linux.ibm.com,
palmer@dabbelt.com, svens@linux.ibm.com, tj@kernel.org,
akpm@linux-foundation.org, rppt@kernel.org
Subject: Re: [PATCH v1 10/21] powerpc/kexec: refactor for kernel/Kconfig.kexec
Date: Thu, 15 Jun 2023 11:19:52 -0500 [thread overview]
Message-ID: <20230615161952.GD19790@gate.crashing.org> (raw)
In-Reply-To: <87fs6tflfi.fsf@mail.lhotse>
On Thu, Jun 15, 2023 at 01:34:25PM +1000, Michael Ellerman wrote:
> Eric DeVolder <eric.devolder@oracle.com> writes:
> > -config KEXEC_FILE
> > - bool "kexec file based system call"
> > - select KEXEC_CORE
> > - select HAVE_IMA_KEXEC if IMA
> > - select KEXEC_ELF
> > - depends on PPC64
> > - depends on CRYPTO=y
> > - depends on CRYPTO_SHA256=y
> ...
> > +
> > +config ARCH_HAS_KEXEC_FILE
> > + def_bool PPC64 && CRYPTO && CRYPTO_SHA256
>
> The =y's got lost here.
>
> I think they were both meaningful, because both options are tristate. So
> this previously required them to be built-in (=y), whereas after your
> patch it will allow them to be modules.
>
> I don't know for sure that those options need to be built-in, but that's
> what the code does now, so this patch shouldn't change it, at least
> without an explanation.
This patch shouldn't change it at all, period. If you want to change it
(and that sounds like a good idea, if it is possible anyway), that
should be a separate patch.
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Eric DeVolder <eric.devolder@oracle.com>,
linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
chenhuacai@kernel.org, geert@linux-m68k.org,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, ysato@users.osdn.me, dalias@libc.org,
glaubitz@physik.fu-berlin.de, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
86@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org, linus.walleij@linaro.org,
thunder.leizhen@huawei.com, hpa@zytor.com, kernel@xen0n.name,
ardb@kernel.org, tsi@tuyoix.net, agordeev@linux.ibm.com,
paulmck@kernel.org, bhe@redhat.com, masahiroy@kernel.org,
konrad.wilk@oracle.com, sebastian.reichel@collabora.com,
samitolvanen@google.com, ojeda@kernel.org,
juerg.haefliger@canonical.com, borntraeger@linux.ibm.com,
frederic@kernel.org, arnd@arndb.de, mhiramat@kernel.org,
aou@eecs.berkeley.edu, keescook@chromium.org, gor@linux.ibm.com,
anshuman.khandual@arm.com, hca@linux.ibm.com, xin3.li@intel.com,
npiggin@gmail.com, rmk+kernel@armlinux.org.uk,
paul.walmsley@sifive.com, boris.ostrovsky@oracle.com,
ziy@nvidia.com, hbathini@linux.ibm.com,
gregkh@linuxfoundation.org, kirill.shutemov@linux.intel.com,
ndesaulniers@google.com, sourabhjain@linux.ibm.com,
palmer@dabbelt.com, svens@linux.ibm.com, tj@kernel.org,
akpm@linux-foundation.org, rppt@kernel.org
Subject: Re: [PATCH v1 10/21] powerpc/kexec: refactor for kernel/Kconfig.kexec
Date: Thu, 15 Jun 2023 11:19:52 -0500 [thread overview]
Message-ID: <20230615161952.GD19790@gate.crashing.org> (raw)
In-Reply-To: <87fs6tflfi.fsf@mail.lhotse>
On Thu, Jun 15, 2023 at 01:34:25PM +1000, Michael Ellerman wrote:
> Eric DeVolder <eric.devolder@oracle.com> writes:
> > -config KEXEC_FILE
> > - bool "kexec file based system call"
> > - select KEXEC_CORE
> > - select HAVE_IMA_KEXEC if IMA
> > - select KEXEC_ELF
> > - depends on PPC64
> > - depends on CRYPTO=y
> > - depends on CRYPTO_SHA256=y
> ...
> > +
> > +config ARCH_HAS_KEXEC_FILE
> > + def_bool PPC64 && CRYPTO && CRYPTO_SHA256
>
> The =y's got lost here.
>
> I think they were both meaningful, because both options are tristate. So
> this previously required them to be built-in (=y), whereas after your
> patch it will allow them to be modules.
>
> I don't know for sure that those options need to be built-in, but that's
> what the code does now, so this patch shouldn't change it, at least
> without an explanation.
This patch shouldn't change it at all, period. If you want to change it
(and that sounds like a good idea, if it is possible anyway), that
should be a separate patch.
Segher
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-m68k@vger.kernel.org, chenhuacai@kernel.org,
linux-ia64@vger.kernel.org, anshuman.khandual@arm.com,
linux-sh@vger.kernel.org, peterz@infradead.org,
catalin.marinas@arm.com, linus.walleij@linaro.org,
dave.hansen@linux.intel.com, linux-mips@vger.kernel.org,
James.Bottomley@HansenPartnership.com, dalias@libc.org,
hpa@zytor.com, linux-riscv@lists.infradead.org,
Eric DeVolder <eric.devolder@oracle.com>,
will@kernel.org, kernel@xen0n.name, tsi@tuyoix.net,
linux-s390@vger.kernel.org, agordeev@linux.ibm.com,
arnd@arndb.de, bhe@redhat.com, deller@gmx.de,
ysato@users.osdn.me, linux@armlinux.org.uk, ardb@kernel.org,
86@kernel.org, mingo@redhat.com, geert@linux-m68k.org,
hbathini@linux.ibm.com, samitolvanen@google.com,
ojeda@kernel.org, paul.walmsley@sifive.com,
borntraeger@linux.ibm.com, hca@linux.ibm.com,
svens@linux.ibm.com, gor@linux.ibm.com,
thunder.leizhen@huawei.com, aou@eecs.berkeley.edu,
keescook@chromium.org, paulmck@kernel.org,
konrad.wilk@oracle.com, frederic@kernel.org, xin3.li@intel.com,
npiggin@gmail.com, rmk+kernel@armlinux.org.uk, bp@alien8.de,
rppt@kernel.org, loongarch@lists.linux.dev,
glaubitz@physik.fu-berlin.de, tglx@linutronix.de, ziy@nvidia.com,
palmer@dabbelt.com, linux-arm-kernel@lists.infradead.org,
boris.ostrovsky@oracle.com, tsbogend@alpha.franken.de,
sebastian.reichel@collabora.com, linux-parisc@vger.kernel.org,
gregkh@linuxfoundation.org, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, sourabhjain@linux.ibm.com,
juerg.haefliger@canonical.com, mhiramat@kernel.org,
tj@kernel.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, masahiroy@kernel.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v1 10/21] powerpc/kexec: refactor for kernel/Kconfig.kexec
Date: Thu, 15 Jun 2023 11:19:52 -0500 [thread overview]
Message-ID: <20230615161952.GD19790@gate.crashing.org> (raw)
In-Reply-To: <87fs6tflfi.fsf@mail.lhotse>
On Thu, Jun 15, 2023 at 01:34:25PM +1000, Michael Ellerman wrote:
> Eric DeVolder <eric.devolder@oracle.com> writes:
> > -config KEXEC_FILE
> > - bool "kexec file based system call"
> > - select KEXEC_CORE
> > - select HAVE_IMA_KEXEC if IMA
> > - select KEXEC_ELF
> > - depends on PPC64
> > - depends on CRYPTO=y
> > - depends on CRYPTO_SHA256=y
> ...
> > +
> > +config ARCH_HAS_KEXEC_FILE
> > + def_bool PPC64 && CRYPTO && CRYPTO_SHA256
>
> The =y's got lost here.
>
> I think they were both meaningful, because both options are tristate. So
> this previously required them to be built-in (=y), whereas after your
> patch it will allow them to be modules.
>
> I don't know for sure that those options need to be built-in, but that's
> what the code does now, so this patch shouldn't change it, at least
> without an explanation.
This patch shouldn't change it at all, period. If you want to change it
(and that sounds like a good idea, if it is possible anyway), that
should be a separate patch.
Segher
next prev parent reply other threads:[~2023-06-15 18:40 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 17:27 [PATCH v1 00/21] refactor Kconfig to consolidate KEXEC and CRASH options Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 01/21] kexec: consolidate kexec and crash options into kernel/Kconfig.kexec Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-14 1:19 ` Leizhen (ThunderTown)
2023-06-14 1:19 ` Leizhen (ThunderTown)
2023-06-14 1:19 ` Leizhen (ThunderTown)
2023-06-14 11:54 ` Eric DeVolder
2023-06-14 11:54 ` Eric DeVolder
2023-06-14 11:54 ` Eric DeVolder
2023-06-14 15:24 ` Alexander Gordeev
2023-06-14 15:24 ` Alexander Gordeev
2023-06-14 15:24 ` Alexander Gordeev
2023-06-14 22:11 ` Eric DeVolder
2023-06-14 22:11 ` Eric DeVolder
2023-06-14 22:11 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 02/21] x86/kexec: refactor for kernel/Kconfig.kexec Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 03/21] arm/kexec: " Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 04/21] ia64/kexec: " Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 05/21] arm64/kexec: " Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-14 1:22 ` Leizhen (ThunderTown)
2023-06-14 1:22 ` Leizhen (ThunderTown)
2023-06-14 1:22 ` Leizhen (ThunderTown)
2023-06-14 11:57 ` Eric DeVolder
2023-06-14 11:57 ` Eric DeVolder
2023-06-14 11:57 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 06/21] loongarch/kexec: " Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` [PATCH v1 07/21] m68k/kexec: " Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 17:27 ` Eric DeVolder
2023-06-12 19:38 ` Geert Uytterhoeven
2023-06-12 19:38 ` Geert Uytterhoeven
2023-06-12 19:38 ` Geert Uytterhoeven
2023-06-14 11:58 ` Eric DeVolder
2023-06-14 11:58 ` Eric DeVolder
2023-06-14 11:58 ` Eric DeVolder
2023-06-12 17:28 ` [PATCH v1 08/21] mips/kexec: " Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` [PATCH v1 09/21] parisc/kexec: " Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` [PATCH v1 10/21] powerpc/kexec: " Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-15 3:34 ` Michael Ellerman
2023-06-15 3:34 ` Michael Ellerman
2023-06-15 3:34 ` Michael Ellerman
2023-06-15 16:17 ` Eric DeVolder
2023-06-15 16:17 ` Eric DeVolder
2023-06-15 16:17 ` Eric DeVolder
2023-06-15 16:19 ` Segher Boessenkool [this message]
2023-06-15 16:19 ` Segher Boessenkool
2023-06-15 16:19 ` Segher Boessenkool
2023-06-12 17:28 ` [PATCH v1 11/21] riscv/kexec: " Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` [PATCH v1 12/21] s390/kexec: " Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` [PATCH v1 13/21] sh/kexec: " Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:28 ` Eric DeVolder
2023-06-12 17:32 ` [PATCH v1 00/21] refactor Kconfig to consolidate KEXEC and CRASH options Eric DeVolder
2023-06-12 17:32 ` Eric DeVolder
2023-06-12 17:32 ` Eric DeVolder
2023-06-13 20:21 ` Kees Cook
2023-06-13 20:21 ` Kees Cook
2023-06-13 20:21 ` Kees Cook
2023-06-14 12:01 ` Eric DeVolder
2023-06-14 12:01 ` Eric DeVolder
2023-06-14 12:01 ` Eric DeVolder
2023-06-15 3:26 ` Michael Ellerman
2023-06-15 3:26 ` Michael Ellerman
2023-06-15 3:26 ` Michael Ellerman
2023-06-15 16:18 ` Eric DeVolder
2023-06-15 16:18 ` Eric DeVolder
2023-06-15 16:18 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615161952.GD19790@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=86@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=eric.devolder@oracle.com \
--cc=frederic@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=juerg.haefliger@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel@xen0n.name \
--cc=kirill.shutemov@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=sebastian.reichel@collabora.com \
--cc=sourabhjain@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=tj@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=tsi@tuyoix.net \
--cc=will@kernel.org \
--cc=xin3.li@intel.com \
--cc=ysato@users.osdn.me \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.