All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Maxime Ripard <mripard@kernel.org>,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 3/7] drm/panel: sitronix-st7789v: Specify the expected bus format
Date: Fri, 16 Jun 2023 11:56:11 +0200	[thread overview]
Message-ID: <20230616115611.77b8aff9@xps-13> (raw)
In-Reply-To: <20230610201246.GD1041001@ravnborg.org>

Hi Sam,

sam@ravnborg.org wrote on Sat, 10 Jun 2023 22:12:46 +0200:

> On Fri, Jun 09, 2023 at 04:59:47PM +0200, Miquel Raynal wrote:
> > The LCD controller supports RGB444, RGB565 and RGB888. The value that is
> > written in the COLMOD register indicates using RGB888, so let's clearly
> > specify the in-use bus format.  
> 
> Confused.
> MEDIA_BUS_FMT_RGB666_1X18 assumes 6 bits per color.
> But RGB888 is 8 bits per color.
> 
> Something that I have forgotten, or is this inconsistent?

That is a typo indeed, I meant RBG666.

Thanks, Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Maxime Ripard <mripard@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH 3/7] drm/panel: sitronix-st7789v: Specify the expected bus format
Date: Fri, 16 Jun 2023 11:56:11 +0200	[thread overview]
Message-ID: <20230616115611.77b8aff9@xps-13> (raw)
In-Reply-To: <20230610201246.GD1041001@ravnborg.org>

Hi Sam,

sam@ravnborg.org wrote on Sat, 10 Jun 2023 22:12:46 +0200:

> On Fri, Jun 09, 2023 at 04:59:47PM +0200, Miquel Raynal wrote:
> > The LCD controller supports RGB444, RGB565 and RGB888. The value that is
> > written in the COLMOD register indicates using RGB888, so let's clearly
> > specify the in-use bus format.  
> 
> Confused.
> MEDIA_BUS_FMT_RGB666_1X18 assumes 6 bits per color.
> But RGB888 is 8 bits per color.
> 
> Something that I have forgotten, or is this inconsistent?

That is a typo indeed, I meant RBG666.

Thanks, Miquèl

  reply	other threads:[~2023-06-16  9:56 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 14:59 [PATCH 0/7] drm/panel: sitronix-st7789v: Support ET028013DMA panel Miquel Raynal
2023-06-09 14:59 ` Miquel Raynal
2023-06-09 14:59 ` [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings Miquel Raynal
2023-06-09 14:59   ` Miquel Raynal
2023-06-10 20:06   ` Sam Ravnborg
2023-06-10 20:06     ` Sam Ravnborg
2023-06-13  6:15   ` Michael Riesch
2023-06-13  6:15     ` Michael Riesch
2023-06-13  6:56     ` Miquel Raynal
2023-06-13  6:56       ` Miquel Raynal
2023-06-14 23:22       ` Sebastian Reichel
2023-06-14 23:22         ` Sebastian Reichel
2023-06-15  5:43         ` Sam Ravnborg
2023-06-15  5:43           ` Sam Ravnborg
2023-06-15 12:58           ` Sebastian Reichel
2023-06-15 12:58             ` Sebastian Reichel
2023-06-09 14:59 ` [PATCH 2/7] drm/panel: sitronix-st7789v: Use 9 bits per spi word by default Miquel Raynal
2023-06-09 14:59   ` Miquel Raynal
2023-06-10 20:09   ` Sam Ravnborg
2023-06-10 20:09     ` Sam Ravnborg
2023-06-09 14:59 ` [PATCH 3/7] drm/panel: sitronix-st7789v: Specify the expected bus format Miquel Raynal
2023-06-09 14:59   ` Miquel Raynal
2023-06-10 20:12   ` Sam Ravnborg
2023-06-10 20:12     ` Sam Ravnborg
2023-06-16  9:56     ` Miquel Raynal [this message]
2023-06-16  9:56       ` Miquel Raynal
2023-06-12  8:44   ` Maxime Ripard
2023-06-12  8:44     ` Maxime Ripard
2023-06-09 14:59 ` [PATCH 4/7] drm/panel: sitronix-st7789v: Use platform data Miquel Raynal
2023-06-09 14:59   ` Miquel Raynal
2023-06-10 20:15   ` Sam Ravnborg
2023-06-10 20:15     ` Sam Ravnborg
2023-06-09 14:59 ` [PATCH 5/7] dt-bindings: display: st7789v: Add the edt,et028013dma panel compatible Miquel Raynal
2023-06-09 14:59   ` [PATCH 5/7] dt-bindings: display: st7789v: Add the edt, et028013dma " Miquel Raynal
2023-06-09 14:59 ` [PATCH 6/7] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support Miquel Raynal
2023-06-09 14:59   ` Miquel Raynal
2023-06-10 20:22   ` Sam Ravnborg
2023-06-10 20:22     ` Sam Ravnborg
2023-06-12  8:51   ` Maxime Ripard
2023-06-12  8:51     ` Maxime Ripard
2023-06-16 10:01     ` Miquel Raynal
2023-06-16 10:01       ` Miquel Raynal
2023-06-09 14:59 ` [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID Miquel Raynal
2023-06-09 14:59   ` Miquel Raynal
2023-06-10 20:45   ` Sam Ravnborg
2023-06-10 20:45     ` Sam Ravnborg
2023-06-14 23:27     ` Sebastian Reichel
2023-06-14 23:27       ` Sebastian Reichel
2023-06-16 10:13       ` Miquel Raynal
2023-06-16 10:13         ` Miquel Raynal
2023-06-16 13:38         ` Sebastian Reichel
2023-06-16 13:38           ` Sebastian Reichel
2023-06-13  6:25   ` Michael Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230616115611.77b8aff9@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk+dt@kernel.org \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.