[PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

[PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

[Thomas Zimmermann]

The callback struct drm_driver.gem_prime_mmap as been removed in
commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap").
Do not assign to it. The assigned function, drm_gem_prime_mmap(), is
now the default for the operation, so there is no change in functionality.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 43613569801b6..07e16ad465d06 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -2879,7 +2879,6 @@ const struct drm_driver amdgpu_partition_driver = {
 	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
 	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
 	.gem_prime_import = amdgpu_gem_prime_import,
-	.gem_prime_mmap = drm_gem_prime_mmap,
 
 	.name = DRIVER_NAME,
 	.desc = DRIVER_DESC,
-- 
2.41.0

Re: [PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

[Christian König]

Am 19.06.23 um 16:11 schrieb Thomas Zimmermann:
> The callback struct drm_driver.gem_prime_mmap as been removed in
> commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap").
> Do not assign to it. The assigned function, drm_gem_prime_mmap(), is
> now the default for the operation, so there is no change in functionality.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 43613569801b6..07e16ad465d06 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -2879,7 +2879,6 @@ const struct drm_driver amdgpu_partition_driver = {
>   	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>   	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>   	.gem_prime_import = amdgpu_gem_prime_import,
> -	.gem_prime_mmap = drm_gem_prime_mmap,
>   
>   	.name = DRIVER_NAME,
>   	.desc = DRIVER_DESC,

Re: [PATCH] drm/amdgpu: Remove struct drm_driver.gem_prime_mmap

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 2021 bytes --]

Hi Christian

Am 19.06.23 um 16:13 schrieb Christian König:
> 
> 
> Am 19.06.23 um 16:11 schrieb Thomas Zimmermann:
>> The callback struct drm_driver.gem_prime_mmap as been removed in
>> commit 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap").
>> Do not assign to it. The assigned function, drm_gem_prime_mmap(), is
>> now the default for the operation, so there is no change in 
>> functionality.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Fixes: 0adec22702d4 ("drm: Remove struct drm_driver.gem_prime_mmap")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: "Christian König" <christian.koenig@amd.com>
>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
> 
> Reviewed-by: Christian König <christian.koenig@amd.com>

Thanks for the quick response. I'll add the patch to drm-misc-next 
immediately, to make the tree's amdgpu build again.

Best regards
Thomas

> 
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 43613569801b6..07e16ad465d06 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -2879,7 +2879,6 @@ const struct drm_driver amdgpu_partition_driver = {
>>       .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>>       .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>>       .gem_prime_import = amdgpu_gem_prime_import,
>> -    .gem_prime_mmap = drm_gem_prime_mmap,
>>       .name = DRIVER_NAME,
>>       .desc = DRIVER_DESC,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]