All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
	intel-wired-lan@lists.osuosl.org, magnus.karlsson@intel.com,
	michal.swiatkowski@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: add missing napi deletion
Date: Tue, 20 Jun 2023 09:53:35 -0700	[thread overview]
Message-ID: <20230620095335.43504612@kernel.org> (raw)
In-Reply-To: <20230620082454.377001-1-maciej.fijalkowski@intel.com>

On Tue, 20 Jun 2023 10:24:54 +0200 Maciej Fijalkowski wrote:
> Error path from ice_probe() is missing ice_napi_del() calls, add it to
> ice_deinit_eth() as ice_init_eth() was the one to add napi instances. It
> is also a good habit to delete napis when removing driver and this also
> addresses that. FWIW ice_napi_del() had no callsites.
> 
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Is there user visible impact? I agree that it's a good habit, but
since unregister cleans up NAPI instances automatically the patch
is not necessarily a fix.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	anthony.l.nguyen@intel.com, magnus.karlsson@intel.com,
	michal.swiatkowski@intel.com
Subject: Re: [PATCH iwl-net] ice: add missing napi deletion
Date: Tue, 20 Jun 2023 09:53:35 -0700	[thread overview]
Message-ID: <20230620095335.43504612@kernel.org> (raw)
In-Reply-To: <20230620082454.377001-1-maciej.fijalkowski@intel.com>

On Tue, 20 Jun 2023 10:24:54 +0200 Maciej Fijalkowski wrote:
> Error path from ice_probe() is missing ice_napi_del() calls, add it to
> ice_deinit_eth() as ice_init_eth() was the one to add napi instances. It
> is also a good habit to delete napis when removing driver and this also
> addresses that. FWIW ice_napi_del() had no callsites.
> 
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Is there user visible impact? I agree that it's a good habit, but
since unregister cleans up NAPI instances automatically the patch
is not necessarily a fix.

  parent reply	other threads:[~2023-06-20 16:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  8:24 [Intel-wired-lan] [PATCH iwl-net] ice: add missing napi deletion Maciej Fijalkowski
2023-06-20  8:24 ` Maciej Fijalkowski
2023-06-20  9:58 ` [Intel-wired-lan] " Przemek Kitszel
2023-06-20  9:58   ` Przemek Kitszel
2023-06-20 16:53 ` Jakub Kicinski [this message]
2023-06-20 16:53   ` Jakub Kicinski
2023-06-20 17:22   ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-20 17:22     ` Maciej Fijalkowski
2023-06-20 17:49     ` [Intel-wired-lan] " Jakub Kicinski
2023-06-20 17:49       ` Jakub Kicinski
2023-06-21 11:43       ` [Intel-wired-lan] " Maciej Fijalkowski
2023-06-21 11:43         ` Maciej Fijalkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620095335.43504612@kernel.org \
    --to=kuba@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=michal.swiatkowski@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.