* [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS @ 2023-06-20 17:09 Ryan Eatmon 2023-06-20 18:05 ` Denys Dmytriyenko 0 siblings, 1 reply; 7+ messages in thread From: Ryan Eatmon @ 2023-06-20 17:09 UTC (permalink / raw) To: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe we forgot to add it as a dependency. Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc index 18984e80..1f0c1ee8 100644 --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc @@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" + +# Add run-time dependency for TI ETH firmware to the rootfs +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" -- 2.17.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS 2023-06-20 17:09 [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS Ryan Eatmon @ 2023-06-20 18:05 ` Denys Dmytriyenko 2023-06-20 19:17 ` Ryan Eatmon 0 siblings, 1 reply; 7+ messages in thread From: Denys Dmytriyenko @ 2023-06-20 18:05 UTC (permalink / raw) To: reatmon; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti On Tue, Jun 20, 2023 at 12:09:25PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe > we forgot to add it as a dependency. > > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > index 18984e80..1f0c1ee8 100644 > --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > @@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" > RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" > + > +# Add run-time dependency for TI ETH firmware to the rootfs > +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" Though, ETH FW is only enabled on j721e, j7200 and j784s4: https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9 ETH_FW_LIST = "" ETH_FW_LIST:j721e = "${ETH_FW}" ETH_FW_LIST:j7200 = "${ETH_FW}" ETH_FW_LIST:j721s2 = "" ETH_FW_LIST:j784s4 = "${ETH_FW}" ETH_FW_LIST:am65xx = "" ETH_FW_LIST:am64xx = "" ETH_FW_LIST:am62xx = "" ETH_FW_LIST:am62axx = "" Other platforms generate an empty package w/o the binary in it. So I guess for simpler dependency pulling it for all K3 platforms is an option? On one hand it makes kernel dependencies simpler, but executes build/packaging process for the firmware that ends up being no-op and produce an empty output... Similar question for DM FW? E.g.: https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a DM_FW_LIST = "" DM_FW_LIST:j721e = "${DM_FIRMWARE}" DM_FW_LIST:j7200 = "${DM_FIRMWARE}" DM_FW_LIST:j721s2 = "${DM_FIRMWARE}" DM_FW_LIST:j784s4 = "${DM_FIRMWARE}" DM_FW_LIST:am65xx = "" DM_FW_LIST:am64xx = "" DM_FW_LIST:am62xx = "${DM_FIRMWARE}" DM_FW_LIST:am62axx = "${DM_FIRMWARE}" -- Denys ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS 2023-06-20 18:05 ` Denys Dmytriyenko @ 2023-06-20 19:17 ` Ryan Eatmon 2023-06-20 20:06 ` Andrew Davis 0 siblings, 1 reply; 7+ messages in thread From: Ryan Eatmon @ 2023-06-20 19:17 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti On 6/20/2023 1:05 PM, Denys Dmytriyenko wrote: > On Tue, Jun 20, 2023 at 12:09:25PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe >> we forgot to add it as a dependency. >> >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >> index 18984e80..1f0c1ee8 100644 >> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >> @@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" >> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" >> + >> +# Add run-time dependency for TI ETH firmware to the rootfs >> +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" > > Though, ETH FW is only enabled on j721e, j7200 and j784s4: > > https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9 > > ETH_FW_LIST = "" > ETH_FW_LIST:j721e = "${ETH_FW}" > ETH_FW_LIST:j7200 = "${ETH_FW}" > ETH_FW_LIST:j721s2 = "" > ETH_FW_LIST:j784s4 = "${ETH_FW}" > ETH_FW_LIST:am65xx = "" > ETH_FW_LIST:am64xx = "" > ETH_FW_LIST:am62xx = "" > ETH_FW_LIST:am62axx = "" > > Other platforms generate an empty package w/o the binary in it. So I guess for > simpler dependency pulling it for all K3 platforms is an option? On one hand > it makes kernel dependencies simpler, but executes build/packaging process for > the firmware that ends up being no-op and produce an empty output... Andrew and I talked about. It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing... This is sort of a holdover from the ti-rtos-firmware way of doing things. Let me think about it... > Similar question for DM FW? E.g.: > > https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a > > DM_FW_LIST = "" > DM_FW_LIST:j721e = "${DM_FIRMWARE}" > DM_FW_LIST:j7200 = "${DM_FIRMWARE}" > DM_FW_LIST:j721s2 = "${DM_FIRMWARE}" > DM_FW_LIST:j784s4 = "${DM_FIRMWARE}" > DM_FW_LIST:am65xx = "" > DM_FW_LIST:am64xx = "" > DM_FW_LIST:am62xx = "${DM_FIRMWARE}" > DM_FW_LIST:am62axx = "${DM_FIRMWARE}" > -- Ryan Eatmon reatmon@ti.com ----------------------------------------- Texas Instruments, Inc. - LCPD - MGTS ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS 2023-06-20 19:17 ` Ryan Eatmon @ 2023-06-20 20:06 ` Andrew Davis 2023-06-20 20:39 ` Denys Dmytriyenko 0 siblings, 1 reply; 7+ messages in thread From: Andrew Davis @ 2023-06-20 20:06 UTC (permalink / raw) To: reatmon, Denys Dmytriyenko; +Cc: Praneeth Bajjuri, Denys Dmytriyenko, meta-ti On 6/20/23 2:17 PM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > On 6/20/2023 1:05 PM, Denys Dmytriyenko wrote: >> On Tue, Jun 20, 2023 at 12:09:25PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >>> When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe >>> we forgot to add it as a dependency. >>> >>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>> --- >>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>> index 18984e80..1f0c1ee8 100644 >>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>> @@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" >>> + >>> +# Add run-time dependency for TI ETH firmware to the rootfs >>> +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" >> >> Though, ETH FW is only enabled on j721e, j7200 and j784s4: >> >> https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9 >> >> ETH_FW_LIST = "" >> ETH_FW_LIST:j721e = "${ETH_FW}" >> ETH_FW_LIST:j7200 = "${ETH_FW}" >> ETH_FW_LIST:j721s2 = "" >> ETH_FW_LIST:j784s4 = "${ETH_FW}" >> ETH_FW_LIST:am65xx = "" >> ETH_FW_LIST:am64xx = "" >> ETH_FW_LIST:am62xx = "" >> ETH_FW_LIST:am62axx = "" >> >> Other platforms generate an empty package w/o the binary in it. So I guess for >> simpler dependency pulling it for all K3 platforms is an option? On one hand >> it makes kernel dependencies simpler, but executes build/packaging process for >> the firmware that ends up being no-op and produce an empty output... > > Andrew and I talked about. It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing... > > This is sort of a holdover from the ti-rtos-firmware way of doing things. > > Let me think about it... > Another thing we may want to do is not have this recipe be device specific, it is just a small firmware, no good reason to only deploy one per device. I'd say we ship all unconditionally in this package, then it won't have to be re-built for each device either. Andrew >> Similar question for DM FW? E.g.: >> >> https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a >> >> DM_FW_LIST = "" >> DM_FW_LIST:j721e = "${DM_FIRMWARE}" >> DM_FW_LIST:j7200 = "${DM_FIRMWARE}" >> DM_FW_LIST:j721s2 = "${DM_FIRMWARE}" >> DM_FW_LIST:j784s4 = "${DM_FIRMWARE}" >> DM_FW_LIST:am65xx = "" >> DM_FW_LIST:am64xx = "" >> DM_FW_LIST:am62xx = "${DM_FIRMWARE}" >> DM_FW_LIST:am62axx = "${DM_FIRMWARE}" >> > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#16746): https://lists.yoctoproject.org/g/meta-ti/message/16746 > Mute This Topic: https://lists.yoctoproject.org/mt/99648797/3619733 > Group Owner: meta-ti+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/leave/6695306/3619733/2033773410/xyzzy [afd@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS 2023-06-20 20:06 ` Andrew Davis @ 2023-06-20 20:39 ` Denys Dmytriyenko 2023-06-20 20:42 ` Andrew Davis 0 siblings, 1 reply; 7+ messages in thread From: Denys Dmytriyenko @ 2023-06-20 20:39 UTC (permalink / raw) To: Andrew Davis; +Cc: reatmon, Praneeth Bajjuri, Denys Dmytriyenko, meta-ti On Tue, Jun 20, 2023 at 03:06:01PM -0500, Andrew Davis wrote: > On 6/20/23 2:17 PM, Ryan Eatmon via lists.yoctoproject.org wrote: > > > > > >On 6/20/2023 1:05 PM, Denys Dmytriyenko wrote: > >>On Tue, Jun 20, 2023 at 12:09:25PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >>>When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe > >>>we forgot to add it as a dependency. > >>> > >>>Signed-off-by: Ryan Eatmon <reatmon@ti.com> > >>>--- > >>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ > >>> 1 file changed, 3 insertions(+) > >>> > >>>diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>index 18984e80..1f0c1ee8 100644 > >>>--- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>+++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" > >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" > >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" > >>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" > >>>+ > >>>+# Add run-time dependency for TI ETH firmware to the rootfs > >>>+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" > >> > >>Though, ETH FW is only enabled on j721e, j7200 and j784s4: > >> > >>https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9 > >> > >>ETH_FW_LIST = "" > >>ETH_FW_LIST:j721e = "${ETH_FW}" > >>ETH_FW_LIST:j7200 = "${ETH_FW}" > >>ETH_FW_LIST:j721s2 = "" > >>ETH_FW_LIST:j784s4 = "${ETH_FW}" > >>ETH_FW_LIST:am65xx = "" > >>ETH_FW_LIST:am64xx = "" > >>ETH_FW_LIST:am62xx = "" > >>ETH_FW_LIST:am62axx = "" > >> > >>Other platforms generate an empty package w/o the binary in it. So I guess for > >>simpler dependency pulling it for all K3 platforms is an option? On one hand > >>it makes kernel dependencies simpler, but executes build/packaging process for > >>the firmware that ends up being no-op and produce an empty output... > > > >Andrew and I talked about. It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing... > > > >This is sort of a holdover from the ti-rtos-firmware way of doing things. > > > >Let me think about it... > > > > Another thing we may want to do is not have this recipe be device specific, > it is just a small firmware, no good reason to only deploy one per device. > I'd say we ship all unconditionally in this package, then it won't have to > be re-built for each device either. Is the binary identical between the platforms? > Andrew > > >>Similar question for DM FW? E.g.: > >> > >>https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a > >> > >>DM_FW_LIST = "" > >>DM_FW_LIST:j721e = "${DM_FIRMWARE}" > >>DM_FW_LIST:j7200 = "${DM_FIRMWARE}" > >>DM_FW_LIST:j721s2 = "${DM_FIRMWARE}" > >>DM_FW_LIST:j784s4 = "${DM_FIRMWARE}" > >>DM_FW_LIST:am65xx = "" > >>DM_FW_LIST:am64xx = "" > >>DM_FW_LIST:am62xx = "${DM_FIRMWARE}" > >>DM_FW_LIST:am62axx = "${DM_FIRMWARE}" ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS 2023-06-20 20:39 ` Denys Dmytriyenko @ 2023-06-20 20:42 ` Andrew Davis 2023-06-20 20:58 ` Denys Dmytriyenko 0 siblings, 1 reply; 7+ messages in thread From: Andrew Davis @ 2023-06-20 20:42 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: reatmon, Praneeth Bajjuri, Denys Dmytriyenko, meta-ti On 6/20/23 3:39 PM, Denys Dmytriyenko wrote: > On Tue, Jun 20, 2023 at 03:06:01PM -0500, Andrew Davis wrote: >> On 6/20/23 2:17 PM, Ryan Eatmon via lists.yoctoproject.org wrote: >>> >>> >>> On 6/20/2023 1:05 PM, Denys Dmytriyenko wrote: >>>> On Tue, Jun 20, 2023 at 12:09:25PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >>>>> When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe >>>>> we forgot to add it as a dependency. >>>>> >>>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>>>> --- >>>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>> index 18984e80..1f0c1ee8 100644 >>>>> --- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>> +++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc >>>>> @@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" >>>>> + >>>>> +# Add run-time dependency for TI ETH firmware to the rootfs >>>>> +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" >>>> >>>> Though, ETH FW is only enabled on j721e, j7200 and j784s4: >>>> >>>> https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9 >>>> >>>> ETH_FW_LIST = "" >>>> ETH_FW_LIST:j721e = "${ETH_FW}" >>>> ETH_FW_LIST:j7200 = "${ETH_FW}" >>>> ETH_FW_LIST:j721s2 = "" >>>> ETH_FW_LIST:j784s4 = "${ETH_FW}" >>>> ETH_FW_LIST:am65xx = "" >>>> ETH_FW_LIST:am64xx = "" >>>> ETH_FW_LIST:am62xx = "" >>>> ETH_FW_LIST:am62axx = "" >>>> >>>> Other platforms generate an empty package w/o the binary in it. So I guess for >>>> simpler dependency pulling it for all K3 platforms is an option? On one hand >>>> it makes kernel dependencies simpler, but executes build/packaging process for >>>> the firmware that ends up being no-op and produce an empty output... >>> >>> Andrew and I talked about. It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing... >>> >>> This is sort of a holdover from the ti-rtos-firmware way of doing things. >>> >>> Let me think about it... >>> >> >> Another thing we may want to do is not have this recipe be device specific, >> it is just a small firmware, no good reason to only deploy one per device. >> I'd say we ship all unconditionally in this package, then it won't have to >> be re-built for each device either. > > Is the binary identical between the platforms? > No, but the binaries are named differently for each platform, so they do not conflict. Same as most other firmware packages, ship all the related firmware in the same package, and let the kernel pick the firmware it actually needs based on name for the platform currently running. Andrew > >> Andrew >> >>>> Similar question for DM FW? E.g.: >>>> >>>> https://git.yoctoproject.org/meta-ti/commit/?id=b21d29d94694ac49b97a1f4ba428c7d8cd6fb64a >>>> >>>> DM_FW_LIST = "" >>>> DM_FW_LIST:j721e = "${DM_FIRMWARE}" >>>> DM_FW_LIST:j7200 = "${DM_FIRMWARE}" >>>> DM_FW_LIST:j721s2 = "${DM_FIRMWARE}" >>>> DM_FW_LIST:j784s4 = "${DM_FIRMWARE}" >>>> DM_FW_LIST:am65xx = "" >>>> DM_FW_LIST:am64xx = "" >>>> DM_FW_LIST:am62xx = "${DM_FIRMWARE}" >>>> DM_FW_LIST:am62axx = "${DM_FIRMWARE}" ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS 2023-06-20 20:42 ` Andrew Davis @ 2023-06-20 20:58 ` Denys Dmytriyenko 0 siblings, 0 replies; 7+ messages in thread From: Denys Dmytriyenko @ 2023-06-20 20:58 UTC (permalink / raw) To: Andrew Davis; +Cc: reatmon, Praneeth Bajjuri, Denys Dmytriyenko, meta-ti On Tue, Jun 20, 2023 at 03:42:29PM -0500, Andrew Davis wrote: > On 6/20/23 3:39 PM, Denys Dmytriyenko wrote: > >On Tue, Jun 20, 2023 at 03:06:01PM -0500, Andrew Davis wrote: > >>On 6/20/23 2:17 PM, Ryan Eatmon via lists.yoctoproject.org wrote: > >>> > >>> > >>>On 6/20/2023 1:05 PM, Denys Dmytriyenko wrote: > >>>>On Tue, Jun 20, 2023 at 12:09:25PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >>>>>When the ti-eth-fw recipe was split out from the ti-rtos-firmware recipe > >>>>>we forgot to add it as a dependency. > >>>>> > >>>>>Signed-off-by: Ryan Eatmon <reatmon@ti.com> > >>>>>--- > >>>>> meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc | 3 +++ > >>>>> 1 file changed, 3 insertions(+) > >>>>> > >>>>>diff --git a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>>>index 18984e80..1f0c1ee8 100644 > >>>>>--- a/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>>>+++ b/meta-ti-bsp/recipes-kernel/linux/kernel-rdepends.inc > >>>>>@@ -31,3 +31,6 @@ RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721e = " vxd-dec-fw" > >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j721s2 = " cnm-wave-fw" > >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:j784s4 = " cnm-wave-fw" > >>>>> RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:am62axx = " cnm-wave-fw" > >>>>>+ > >>>>>+# Add run-time dependency for TI ETH firmware to the rootfs > >>>>>+RDEPENDS:${KERNEL_PACKAGE_NAME}-base:append:k3 = " ti-eth-fw" > >>>> > >>>>Though, ETH FW is only enabled on j721e, j7200 and j784s4: > >>>> > >>>>https://git.yoctoproject.org/meta-ti/commit/?id=91e5a1ca6541012e3d4285479ecf5a9f353307f9 > >>>> > >>>>ETH_FW_LIST = "" > >>>>ETH_FW_LIST:j721e = "${ETH_FW}" > >>>>ETH_FW_LIST:j7200 = "${ETH_FW}" > >>>>ETH_FW_LIST:j721s2 = "" > >>>>ETH_FW_LIST:j784s4 = "${ETH_FW}" > >>>>ETH_FW_LIST:am65xx = "" > >>>>ETH_FW_LIST:am64xx = "" > >>>>ETH_FW_LIST:am62xx = "" > >>>>ETH_FW_LIST:am62axx = "" > >>>> > >>>>Other platforms generate an empty package w/o the binary in it. So I guess for > >>>>simpler dependency pulling it for all K3 platforms is an option? On one hand > >>>>it makes kernel dependencies simpler, but executes build/packaging process for > >>>>the firmware that ends up being no-op and produce an empty output... > >>> > >>>Andrew and I talked about. It seems annoying to have to update two files to add a platform, BUT doing it this way does mean we execute the recipe when the recipe does nothing... > >>> > >>>This is sort of a holdover from the ti-rtos-firmware way of doing things. > >>> > >>>Let me think about it... > >>> > >> > >>Another thing we may want to do is not have this recipe be device specific, > >>it is just a small firmware, no good reason to only deploy one per device. > >>I'd say we ship all unconditionally in this package, then it won't have to > >>be re-built for each device either. > > > >Is the binary identical between the platforms? > > > > No, but the binaries are named differently for each platform, so they do not conflict. > Same as most other firmware packages, ship all the related firmware in the same package, > and let the kernel pick the firmware it actually needs based on name for the platform > currently running. Ah, I see. Yeah, that could work. -- Denys ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-20 20:58 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-20 17:09 [meta-ti][master/kirkstone][PATCH] kernel-rdepends: Add ti-eth-fw as an RDEPENDS Ryan Eatmon 2023-06-20 18:05 ` Denys Dmytriyenko 2023-06-20 19:17 ` Ryan Eatmon 2023-06-20 20:06 ` Andrew Davis 2023-06-20 20:39 ` Denys Dmytriyenko 2023-06-20 20:42 ` Andrew Davis 2023-06-20 20:58 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.