All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	soc@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	schung@nuvoton.com, Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of string for parent clock
Date: Wed, 21 Jun 2023 14:51:44 +0200	[thread overview]
Message-ID: <2023062103-obtuse-parasitic-e675@gregkh> (raw)
In-Reply-To: <20230621031605.234149-3-ychuang570808@gmail.com>

On Wed, Jun 21, 2023 at 03:16:05AM +0000, Jacky Huang wrote:
>  
> -	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0,
> -					 26, 1, axiclk_sel_clks,
> -					 ARRAY_SIZE(axiclk_sel_clks));
> -	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux", clk_base + REG_CLK_CLKSEL0,
> -					  2, 1, sysclk0_sel_clks,
> -					  ARRAY_SIZE(sysclk0_sel_clks));
> -	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0,
> -					  4, 1, sysclk1_sel_clks,
> -					  ARRAY_SIZE(sysclk1_sel_clks));
> +	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0, 26, 1,
> +					 axiclk_sel_clks, ARRAY_SIZE(axiclk_sel_clks));
> +
> +	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux",
> +					  clk_base + REG_CLK_CLKSEL0, 2, 1,
> +					  sysclk0_sel_clks, ARRAY_SIZE(sysclk0_sel_clks));
> +
> +	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0, 4, 1,
> +					  sysclk1_sel_clks, ARRAY_SIZE(sysclk1_sel_clks));
> +

No need to reformat lines that are not actually changing anything, as
this makes the patch harder to review for real changes in it :(

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jacky Huang <ychuang570808@gmail.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	soc@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	schung@nuvoton.com, Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of string for parent clock
Date: Wed, 21 Jun 2023 14:51:44 +0200	[thread overview]
Message-ID: <2023062103-obtuse-parasitic-e675@gregkh> (raw)
In-Reply-To: <20230621031605.234149-3-ychuang570808@gmail.com>

On Wed, Jun 21, 2023 at 03:16:05AM +0000, Jacky Huang wrote:
>  
> -	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0,
> -					 26, 1, axiclk_sel_clks,
> -					 ARRAY_SIZE(axiclk_sel_clks));
> -	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux", clk_base + REG_CLK_CLKSEL0,
> -					  2, 1, sysclk0_sel_clks,
> -					  ARRAY_SIZE(sysclk0_sel_clks));
> -	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0,
> -					  4, 1, sysclk1_sel_clks,
> -					  ARRAY_SIZE(sysclk1_sel_clks));
> +	hws[AXICLK_MUX] = ma35d1_clk_mux(dev, "axiclk_mux", clk_base + REG_CLK_CLKDIV0, 26, 1,
> +					 axiclk_sel_clks, ARRAY_SIZE(axiclk_sel_clks));
> +
> +	hws[SYSCLK0_MUX] = ma35d1_clk_mux(dev, "sysclk0_mux",
> +					  clk_base + REG_CLK_CLKSEL0, 2, 1,
> +					  sysclk0_sel_clks, ARRAY_SIZE(sysclk0_sel_clks));
> +
> +	hws[SYSCLK1_MUX] = ma35d1_clk_mux(dev, "sysclk1_mux", clk_base + REG_CLK_CLKSEL0, 4, 1,
> +					  sysclk1_sel_clks, ARRAY_SIZE(sysclk1_sel_clks));
> +

No need to reformat lines that are not actually changing anything, as
this makes the patch harder to review for real changes in it :(

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-21 12:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  3:16 [PATCH v2 0/2] clk: nuvoton: Use clk_parent_data instead and add a header file Jacky Huang
2023-06-21  3:16 ` Jacky Huang
2023-06-21  3:16 ` [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions Jacky Huang
2023-06-21  3:16   ` Jacky Huang
2023-06-21 14:22   ` Arnd Bergmann
2023-06-21 14:22     ` Arnd Bergmann
2023-06-22  1:42     ` Jacky Huang
2023-06-22  1:42       ` Jacky Huang
2023-06-22 10:10       ` Arnd Bergmann
2023-06-22 10:10         ` Arnd Bergmann
2023-06-21  3:16 ` [PATCH v2 2/2] clk: nuvoton: Use clk_parent_data instead of string for parent clock Jacky Huang
2023-06-21  3:16   ` Jacky Huang
2023-06-21 12:51   ` Greg KH [this message]
2023-06-21 12:51     ` Greg KH
2023-06-22  1:46     ` Jacky Huang
2023-06-22  1:46       ` Jacky Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023062103-obtuse-parasitic-e675@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=schung@nuvoton.com \
    --cc=soc@kernel.org \
    --cc=ychuang3@nuvoton.com \
    --cc=ychuang570808@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.