All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v2 2/3] spi: atmel: Prevent false timeouts on long transfers
Date: Thu, 22 Jun 2023 10:25:18 +0200	[thread overview]
Message-ID: <20230622102518.0dd4c268@xps-13> (raw)
In-Reply-To: <9988258d-5797-402a-9d92-c7c9e1afa73c@sirena.org.uk>

Hi Mark,

broonie@kernel.org wrote on Wed, 21 Jun 2023 15:59:34 +0100:

> On Mon, Jun 19, 2023 at 05:53:48PM +0200, Miquel Raynal wrote:
> > A slow SPI bus clocks at ~20MHz, which means it would transfer about
> > 2500 bytes per second with a single data line. Big transfers, like when
> > dealing with flashes can easily reach a few MiB. The current DMA timeout
> > is set to 1 second, which means any working transfer of about 4MiB will
> > always be cancelled.  
> 
> This breaks the build:
> 
> /build/stage/linux/drivers/spi/spi-atmel.c: In function ‘atmel_spi_one_transfer’
> :
> /build/stage/linux/drivers/spi/spi-atmel.c:1338:76: error: ‘master’ undeclared (
> first use in this function)
>  1338 |                 dma_timeout = msecs_to_jiffies(spi_controller_xfer_timeo
> ut(master, xfer));
>       |                                                                         
>    ^~~~~~
> /build/stage/linux/drivers/spi/spi-atmel.c:1338:76: note: each undeclared identi
> fier is reported only once for each function it appears in

I am testing on a customer board which currently runs on 6.1, I lacked
398b6b310ec8 ("spi: atmel: switch to use modern name"). I'll send an update.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Samuel Holland <samuel@sholland.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-spi@vger.kernel.org,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@lists.linux.dev,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] spi: atmel: Prevent false timeouts on long transfers
Date: Thu, 22 Jun 2023 10:25:18 +0200	[thread overview]
Message-ID: <20230622102518.0dd4c268@xps-13> (raw)
In-Reply-To: <9988258d-5797-402a-9d92-c7c9e1afa73c@sirena.org.uk>

Hi Mark,

broonie@kernel.org wrote on Wed, 21 Jun 2023 15:59:34 +0100:

> On Mon, Jun 19, 2023 at 05:53:48PM +0200, Miquel Raynal wrote:
> > A slow SPI bus clocks at ~20MHz, which means it would transfer about
> > 2500 bytes per second with a single data line. Big transfers, like when
> > dealing with flashes can easily reach a few MiB. The current DMA timeout
> > is set to 1 second, which means any working transfer of about 4MiB will
> > always be cancelled.  
> 
> This breaks the build:
> 
> /build/stage/linux/drivers/spi/spi-atmel.c: In function ‘atmel_spi_one_transfer’
> :
> /build/stage/linux/drivers/spi/spi-atmel.c:1338:76: error: ‘master’ undeclared (
> first use in this function)
>  1338 |                 dma_timeout = msecs_to_jiffies(spi_controller_xfer_timeo
> ut(master, xfer));
>       |                                                                         
>    ^~~~~~
> /build/stage/linux/drivers/spi/spi-atmel.c:1338:76: note: each undeclared identi
> fier is reported only once for each function it appears in

I am testing on a customer board which currently runs on 6.1, I lacked
398b6b310ec8 ("spi: atmel: switch to use modern name"). I'll send an update.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-06-22  8:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 15:53 [PATCH v2 0/3] spi: Helper for deriving timeout values Miquel Raynal
2023-06-19 15:53 ` Miquel Raynal
2023-06-19 15:53 ` [PATCH v2 1/3] spi: Create a helper to derive adaptive timeouts Miquel Raynal
2023-06-19 15:53   ` Miquel Raynal
2023-06-19 15:53 ` [PATCH v2 2/3] spi: atmel: Prevent false timeouts on long transfers Miquel Raynal
2023-06-19 15:53   ` Miquel Raynal
2023-06-21 14:59   ` Mark Brown
2023-06-21 14:59     ` Mark Brown
2023-06-22  8:25     ` Miquel Raynal [this message]
2023-06-22  8:25       ` Miquel Raynal
2023-06-19 15:53 ` [PATCH v2 3/3] spi: sun6i: Use the new helper to derive the xfer timeout value Miquel Raynal
2023-06-19 15:53   ` Miquel Raynal
2023-06-21 15:51   ` Jernej Škrabec
2023-06-21 15:51     ` Jernej Škrabec
2023-06-26 16:47 ` [PATCH v2 0/3] spi: Helper for deriving timeout values Mark Brown
2023-06-26 16:47   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622102518.0dd4c268@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea@microchip.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=nicolas.ferre@microchip.com \
    --cc=samuel@sholland.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.