From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ming Lei <ming.lei@redhat.com>, Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH v4 4/7] block: One requeue list per hctx
Date: Fri, 23 Jun 2023 07:48:23 +0200 [thread overview]
Message-ID: <20230623054823.GD9085@lst.de> (raw)
In-Reply-To: <20230621201237.796902-5-bvanassche@acm.org>
> void blk_mq_kick_requeue_list(struct request_queue *q)
> {
> - kblockd_mod_delayed_work_on(WORK_CPU_UNBOUND, &q->requeue_work, 0);
> + struct blk_mq_hw_ctx *hctx;
> + unsigned long i;
> +
> + queue_for_each_hw_ctx(q, hctx, i)
> + kblockd_mod_delayed_work_on(WORK_CPU_UNBOUND,
> + &hctx->requeue_work, 0);
> }
> EXPORT_SYMBOL(blk_mq_kick_requeue_list);
>
> void blk_mq_delay_kick_requeue_list(struct request_queue *q,
> unsigned long msecs)
> {
> - kblockd_mod_delayed_work_on(WORK_CPU_UNBOUND, &q->requeue_work,
> - msecs_to_jiffies(msecs));
> + struct blk_mq_hw_ctx *hctx;
> + unsigned long i;
> +
> + queue_for_each_hw_ctx(q, hctx, i)
> + kblockd_mod_delayed_work_on(WORK_CPU_UNBOUND,
> + &hctx->requeue_work,
> + msecs_to_jiffies(msecs));
> }
I'd iplement blk_mq_kick_requeue_list as a wrapper around
blk_mq_delay_kick_requeue_list that passes a 0 msec argument.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-23 5:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 20:12 [PATCH v4 0/7] Submit zoned writes in order Bart Van Assche
2023-06-21 20:12 ` [PATCH v4 1/7] block: Rename a local variable in blk_mq_requeue_work() Bart Van Assche
2023-06-22 1:15 ` Damien Le Moal
2023-06-21 20:12 ` [PATCH v4 2/7] block: Simplify blk_mq_requeue_work() Bart Van Assche
2023-06-22 1:16 ` Damien Le Moal
2023-06-23 5:45 ` Christoph Hellwig
2023-06-21 20:12 ` [PATCH v4 3/7] block: Send requeued requests to the I/O scheduler Bart Van Assche
2023-06-22 1:19 ` Damien Le Moal
2023-06-22 17:23 ` Bart Van Assche
2023-06-22 21:50 ` Damien Le Moal
2023-06-21 20:12 ` [PATCH v4 4/7] block: One requeue list per hctx Bart Van Assche
2023-06-23 5:48 ` Christoph Hellwig [this message]
2023-06-26 8:09 ` Ming Lei
2023-06-26 16:54 ` Bart Van Assche
2023-06-27 1:06 ` Ming Lei
2023-06-21 20:12 ` [PATCH v4 5/7] block: Preserve the order of requeued requests Bart Van Assche
2023-06-23 5:50 ` Christoph Hellwig
2023-06-23 20:08 ` Bart Van Assche
2023-06-26 8:01 ` Christoph Hellwig
2023-06-26 8:16 ` Ming Lei
2023-06-21 20:12 ` [dm-devel] [PATCH v4 6/7] dm: Inline __dm_mq_kick_requeue_list() Bart Van Assche
2023-06-21 20:12 ` Bart Van Assche
2023-06-21 20:12 ` [dm-devel] [PATCH v4 7/7] block: Inline blk_mq_{, delay_}kick_requeue_list() Bart Van Assche
2023-06-21 20:12 ` [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Bart Van Assche
2023-06-22 7:31 ` [dm-devel] [PATCH v4 7/7] block: Inline blk_mq_{, delay_}kick_requeue_list() Roger Pau Monné
2023-06-22 7:31 ` [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Roger Pau Monné
2023-06-23 5:52 ` [dm-devel] [PATCH v4 7/7] block: Inline blk_mq_{, delay_}kick_requeue_list() Christoph Hellwig
2023-06-23 5:52 ` [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623054823.GD9085@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.