From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>,
Mike Snitzer <snitzer@kernel.org>, Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Damien Le Moal <dlemoal@kernel.org>,
Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>
Subject: [dm-devel] [PATCH v4 6/7] dm: Inline __dm_mq_kick_requeue_list()
Date: Wed, 21 Jun 2023 13:12:33 -0700 [thread overview]
Message-ID: <20230621201237.796902-7-bvanassche@acm.org> (raw)
In-Reply-To: <20230621201237.796902-1-bvanassche@acm.org>
Since commit 52d7f1b5c2f3 ("blk-mq: Avoid that requeueing starts stopped
queues") the function __dm_mq_kick_requeue_list() is too short to keep it
as a separate function. Hence, inline this function.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/md/dm-rq.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index f7e9a3632eb3..bbe1e2ea0aa4 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -168,21 +168,16 @@ static void dm_end_request(struct request *clone, blk_status_t error)
rq_completed(md);
}
-static void __dm_mq_kick_requeue_list(struct request_queue *q, unsigned long msecs)
-{
- blk_mq_delay_kick_requeue_list(q, msecs);
-}
-
void dm_mq_kick_requeue_list(struct mapped_device *md)
{
- __dm_mq_kick_requeue_list(md->queue, 0);
+ blk_mq_kick_requeue_list(md->queue);
}
EXPORT_SYMBOL(dm_mq_kick_requeue_list);
static void dm_mq_delay_requeue_request(struct request *rq, unsigned long msecs)
{
blk_mq_requeue_request(rq, false);
- __dm_mq_kick_requeue_list(rq->q, msecs);
+ blk_mq_delay_kick_requeue_list(rq->q, msecs);
}
static void dm_requeue_original_request(struct dm_rq_target_io *tio, bool delay_requeue)
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <dlemoal@kernel.org>,
Ming Lei <ming.lei@redhat.com>, Mike Snitzer <snitzer@kernel.org>,
Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com
Subject: [PATCH v4 6/7] dm: Inline __dm_mq_kick_requeue_list()
Date: Wed, 21 Jun 2023 13:12:33 -0700 [thread overview]
Message-ID: <20230621201237.796902-7-bvanassche@acm.org> (raw)
In-Reply-To: <20230621201237.796902-1-bvanassche@acm.org>
Since commit 52d7f1b5c2f3 ("blk-mq: Avoid that requeueing starts stopped
queues") the function __dm_mq_kick_requeue_list() is too short to keep it
as a separate function. Hence, inline this function.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/md/dm-rq.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index f7e9a3632eb3..bbe1e2ea0aa4 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -168,21 +168,16 @@ static void dm_end_request(struct request *clone, blk_status_t error)
rq_completed(md);
}
-static void __dm_mq_kick_requeue_list(struct request_queue *q, unsigned long msecs)
-{
- blk_mq_delay_kick_requeue_list(q, msecs);
-}
-
void dm_mq_kick_requeue_list(struct mapped_device *md)
{
- __dm_mq_kick_requeue_list(md->queue, 0);
+ blk_mq_kick_requeue_list(md->queue);
}
EXPORT_SYMBOL(dm_mq_kick_requeue_list);
static void dm_mq_delay_requeue_request(struct request *rq, unsigned long msecs)
{
blk_mq_requeue_request(rq, false);
- __dm_mq_kick_requeue_list(rq->q, msecs);
+ blk_mq_delay_kick_requeue_list(rq->q, msecs);
}
static void dm_requeue_original_request(struct dm_rq_target_io *tio, bool delay_requeue)
next prev parent reply other threads:[~2023-06-21 20:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 20:12 [PATCH v4 0/7] Submit zoned writes in order Bart Van Assche
2023-06-21 20:12 ` [PATCH v4 1/7] block: Rename a local variable in blk_mq_requeue_work() Bart Van Assche
2023-06-22 1:15 ` Damien Le Moal
2023-06-21 20:12 ` [PATCH v4 2/7] block: Simplify blk_mq_requeue_work() Bart Van Assche
2023-06-22 1:16 ` Damien Le Moal
2023-06-23 5:45 ` Christoph Hellwig
2023-06-21 20:12 ` [PATCH v4 3/7] block: Send requeued requests to the I/O scheduler Bart Van Assche
2023-06-22 1:19 ` Damien Le Moal
2023-06-22 17:23 ` Bart Van Assche
2023-06-22 21:50 ` Damien Le Moal
2023-06-21 20:12 ` [PATCH v4 4/7] block: One requeue list per hctx Bart Van Assche
2023-06-23 5:48 ` Christoph Hellwig
2023-06-26 8:09 ` Ming Lei
2023-06-26 16:54 ` Bart Van Assche
2023-06-27 1:06 ` Ming Lei
2023-06-21 20:12 ` [PATCH v4 5/7] block: Preserve the order of requeued requests Bart Van Assche
2023-06-23 5:50 ` Christoph Hellwig
2023-06-23 20:08 ` Bart Van Assche
2023-06-26 8:01 ` Christoph Hellwig
2023-06-26 8:16 ` Ming Lei
2023-06-21 20:12 ` Bart Van Assche [this message]
2023-06-21 20:12 ` [PATCH v4 6/7] dm: Inline __dm_mq_kick_requeue_list() Bart Van Assche
2023-06-21 20:12 ` [dm-devel] [PATCH v4 7/7] block: Inline blk_mq_{, delay_}kick_requeue_list() Bart Van Assche
2023-06-21 20:12 ` [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Bart Van Assche
2023-06-22 7:31 ` [dm-devel] [PATCH v4 7/7] block: Inline blk_mq_{, delay_}kick_requeue_list() Roger Pau Monné
2023-06-22 7:31 ` [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Roger Pau Monné
2023-06-23 5:52 ` [dm-devel] [PATCH v4 7/7] block: Inline blk_mq_{, delay_}kick_requeue_list() Christoph Hellwig
2023-06-23 5:52 ` [PATCH v4 7/7] block: Inline blk_mq_{,delay_}kick_requeue_list() Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621201237.796902-7-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.