From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Thomas Huth <thuth@redhat.com>
Cc: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>,
Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing
Date: Fri, 23 Jun 2023 14:20:30 +0100 [thread overview]
Message-ID: <20230623142030.00001c15@Huawei.com> (raw)
In-Reply-To: <20230622114132.372898-1-thuth@redhat.com>
On Thu, 22 Jun 2023 13:41:32 +0200
Thomas Huth <thuth@redhat.com> wrote:
> It's good style to clean up temporary directories when they
> are not needed anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> tests/qtest/cxl-test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c
> index edcad4a0ce..a600331843 100644
> --- a/tests/qtest/cxl-test.c
> +++ b/tests/qtest/cxl-test.c
> @@ -124,6 +124,7 @@ static void cxl_t3d_deprecated(void)
>
> qtest_start(cmdline->str);
> qtest_end();
> + rmdir(tmpfs);
> }
>
> static void cxl_t3d_persistent(void)
> @@ -138,6 +139,7 @@ static void cxl_t3d_persistent(void)
>
> qtest_start(cmdline->str);
> qtest_end();
> + rmdir(tmpfs);
> }
>
> static void cxl_t3d_volatile(void)
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Thomas Huth <thuth@redhat.com>
Cc: <qemu-devel@nongnu.org>, <qemu-trivial@nongnu.org>,
Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing
Date: Fri, 23 Jun 2023 14:20:30 +0100 [thread overview]
Message-ID: <20230623142030.00001c15@Huawei.com> (raw)
In-Reply-To: <20230622114132.372898-1-thuth@redhat.com>
On Thu, 22 Jun 2023 13:41:32 +0200
Thomas Huth <thuth@redhat.com> wrote:
> It's good style to clean up temporary directories when they
> are not needed anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> tests/qtest/cxl-test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c
> index edcad4a0ce..a600331843 100644
> --- a/tests/qtest/cxl-test.c
> +++ b/tests/qtest/cxl-test.c
> @@ -124,6 +124,7 @@ static void cxl_t3d_deprecated(void)
>
> qtest_start(cmdline->str);
> qtest_end();
> + rmdir(tmpfs);
> }
>
> static void cxl_t3d_persistent(void)
> @@ -138,6 +139,7 @@ static void cxl_t3d_persistent(void)
>
> qtest_start(cmdline->str);
> qtest_end();
> + rmdir(tmpfs);
> }
>
> static void cxl_t3d_volatile(void)
next prev parent reply other threads:[~2023-06-23 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 11:41 [PATCH] tests/qtest/cxl-test: Clean up temporary directories after testing Thomas Huth
2023-06-23 13:20 ` Jonathan Cameron [this message]
2023-06-23 13:20 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623142030.00001c15@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=fan.ni@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.