From: "Cédric Le Goater" <clg@kaod.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PULL 02/30] ppc/pnv/pci: Clean up error messages
Date: Mon, 26 Jun 2023 07:56:19 +0200 [thread overview]
Message-ID: <20230626055647.1147743-3-clg@kaod.org> (raw)
In-Reply-To: <20230626055647.1147743-1-clg@kaod.org>
From: Joel Stanley <joel@jms.id.au>
The phb error macros add a newline for you, so remove the second one to
avoid double whitespace.
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/pci-host/pnv_phb4.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 542f9e293221..6232cbeee161 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -133,13 +133,13 @@ static void pnv_phb4_rc_config_write(PnvPHB4 *phb, unsigned off,
PCIDevice *pdev;
if (size != 4) {
- phb_error(phb, "rc_config_write invalid size %d\n", size);
+ phb_error(phb, "rc_config_write invalid size %d", size);
return;
}
pdev = pci_find_device(pci->bus, 0, 0);
if (!pdev) {
- phb_error(phb, "rc_config_write device not found\n");
+ phb_error(phb, "rc_config_write device not found");
return;
}
@@ -155,13 +155,13 @@ static uint64_t pnv_phb4_rc_config_read(PnvPHB4 *phb, unsigned off,
uint64_t val;
if (size != 4) {
- phb_error(phb, "rc_config_read invalid size %d\n", size);
+ phb_error(phb, "rc_config_read invalid size %d", size);
return ~0ull;
}
pdev = pci_find_device(pci->bus, 0, 0);
if (!pdev) {
- phb_error(phb, "rc_config_read device not found\n");
+ phb_error(phb, "rc_config_read device not found");
return ~0ull;
}
@@ -1039,19 +1039,19 @@ static void pnv_pec_stk_nest_xscom_write(void *opaque, hwaddr addr,
if (phb->nest_regs[PEC_NEST_STK_BAR_EN] &
(PEC_NEST_STK_BAR_EN_MMIO0 |
PEC_NEST_STK_BAR_EN_MMIO1)) {
- phb_pec_error(pec, "Changing enabled BAR unsupported\n");
+ phb_pec_error(pec, "Changing enabled BAR unsupported");
}
phb->nest_regs[reg] = val & 0xffffffffff000000ull;
break;
case PEC_NEST_STK_PHB_REGS_BAR:
if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_PHB) {
- phb_pec_error(pec, "Changing enabled BAR unsupported\n");
+ phb_pec_error(pec, "Changing enabled BAR unsupported");
}
phb->nest_regs[reg] = val & 0xffffffffffc00000ull;
break;
case PEC_NEST_STK_INT_BAR:
if (phb->nest_regs[PEC_NEST_STK_BAR_EN] & PEC_NEST_STK_BAR_EN_INT) {
- phb_pec_error(pec, "Changing enabled BAR unsupported\n");
+ phb_pec_error(pec, "Changing enabled BAR unsupported");
}
phb->nest_regs[reg] = val & 0xfffffff000000000ull;
break;
--
2.41.0
next prev parent reply other threads:[~2023-06-26 5:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 5:56 [PULL 00/30] ppc queue Cédric Le Goater
2023-06-26 5:56 ` [PULL 01/30] target/ppc: gdbstub init spr gdb_id for all CPUs Cédric Le Goater
2023-06-26 5:56 ` Cédric Le Goater [this message]
2023-06-26 5:56 ` [PULL 03/30] MAINTAINERS: Add reviewers for PowerNV baremetal emulation Cédric Le Goater
2023-06-26 5:56 ` [PULL 04/30] MAINTAINERS: Add reviewer for PowerPC TCG CPUs Cédric Le Goater
2023-06-26 5:56 ` [PULL 05/30] MAINTAINERS: Add reviewer for XIVE Cédric Le Goater
2023-06-26 5:56 ` [PULL 06/30] ppc/prep: Report an error when run with KVM Cédric Le Goater
2023-06-26 5:56 ` [PULL 07/30] ppc/bamboo: " Cédric Le Goater
2023-06-26 5:56 ` [PULL 08/30] ppc/pnv: Rephrase " Cédric Le Goater
2023-06-26 5:56 ` [PULL 09/30] target/ppc: Fix timer register accessors when !KVM Cédric Le Goater
2023-06-26 5:56 ` [PULL 10/30] ppc/spapr: H_ENTER_NESTED should restore host XER ca field Cédric Le Goater
2023-06-26 12:26 ` Michael Tokarev
2023-06-26 21:45 ` Cédric Le Goater
2023-06-26 23:15 ` Nicholas Piggin
2023-06-26 5:56 ` [PULL 11/30] ppc/spapr: Add a nested state struct Cédric Le Goater
2023-06-26 5:56 ` [PULL 12/30] ppc/spapr: load and store l2 state with helper functions Cédric Le Goater
2023-06-26 5:56 ` [PULL 13/30] ppc/spapr: Move spapr nested HV to a new file Cédric Le Goater
2023-06-26 5:56 ` [PULL 14/30] target/ppc: Fix instruction loading endianness in alignment interrupt Cédric Le Goater
2023-06-26 5:56 ` [PULL 15/30] target/ppc: Change partition-scope translate interface Cédric Le Goater
2023-06-26 5:56 ` [PULL 16/30] target/ppc: Add SRR1 prefix indication to interrupt handlers Cédric Le Goater
2023-06-26 5:56 ` [PULL 17/30] target/ppc: Implement HEIR SPR Cédric Le Goater
2023-06-26 5:56 ` [PULL 18/30] target/ppc: Add ISA v3.1 LEV indication in SRR1 for system call interrupts Cédric Le Goater
2023-06-26 5:56 ` [PULL 19/30] target/ppc: Better CTRL SPR implementation Cédric Le Goater
2023-06-26 5:56 ` [PULL 20/30] target/ppc: Fix sc instruction handling of LEV field Cédric Le Goater
2023-06-26 5:56 ` [PULL 21/30] target/ppc: Add initial flags and helpers for SMT support Cédric Le Goater
2023-06-26 5:56 ` [PULL 22/30] target/ppc: Add support for SMT CTRL register Cédric Le Goater
2023-06-26 5:56 ` [PULL 23/30] target/ppc: Add msgsnd/p and DPDES SMT support Cédric Le Goater
2023-06-26 5:56 ` [PULL 24/30] hw/ppc/spapr: Test whether TCG is enabled with tcg_enabled() Cédric Le Goater
2023-06-26 5:56 ` [PULL 25/30] spapr: TCG allow up to 8-thread SMT on POWER8 and newer CPUs Cédric Le Goater
2023-06-26 5:56 ` [PULL 26/30] tests/avocado: boot ppc64 pseries to Linux VFS mount Cédric Le Goater
2023-06-26 5:56 ` [PULL 27/30] tests/avocado: Add ppc64 pseries multiprocessor boot tests Cédric Le Goater
2023-06-26 5:56 ` [PULL 28/30] pnv/xive2: Add a get_config() method on the presenter class Cédric Le Goater
2023-06-26 5:56 ` [PULL 29/30] pnv/xive2: Check TIMA special ops against a dedicated array for P10 Cédric Le Goater
2023-06-26 5:56 ` [PULL 30/30] tests/avocado: ppc test VOF bios Linux boot Cédric Le Goater
2023-06-26 8:37 ` [PULL 00/30] ppc queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626055647.1147743-3-clg@kaod.org \
--to=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=joel@jms.id.au \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.