* [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
@ 2023-06-16 12:20 Juerg Haefliger
2023-06-28 6:47 ` Greg KH
2023-06-28 9:50 ` [PATCH v2] " Juerg Haefliger
0 siblings, 2 replies; 5+ messages in thread
From: Juerg Haefliger @ 2023-06-16 12:20 UTC (permalink / raw)
To: jk, joel, alistair, eajames, linux-fsi; +Cc: linux-kernel, Juerg Haefliger
The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
drivers/fsi/fsi-master-ast-cf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
index 5f608ef8b53c..1316bfd121fe 100644
--- a/drivers/fsi/fsi-master-ast-cf.c
+++ b/drivers/fsi/fsi-master-ast-cf.c
@@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
module_platform_driver(fsi_master_acf);
MODULE_LICENSE("GPL");
+
+MODULE_FIRMWARE(FW_FILE_NAME);
--
2.37.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
2023-06-16 12:20 [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro Juerg Haefliger
@ 2023-06-28 6:47 ` Greg KH
2023-06-28 7:29 ` Juerg Haefliger
2023-06-28 9:50 ` [PATCH v2] " Juerg Haefliger
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2023-06-28 6:47 UTC (permalink / raw)
To: Juerg Haefliger; +Cc: jk, joel, alistair, eajames, linux-fsi, linux-kernel
On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
> drivers/fsi/fsi-master-ast-cf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> index 5f608ef8b53c..1316bfd121fe 100644
> --- a/drivers/fsi/fsi-master-ast-cf.c
> +++ b/drivers/fsi/fsi-master-ast-cf.c
> @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
>
> module_platform_driver(fsi_master_acf);
> MODULE_LICENSE("GPL");
> +
> +MODULE_FIRMWARE(FW_FILE_NAME);
No need for the extra blank line, right?
And what commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
2023-06-28 6:47 ` Greg KH
@ 2023-06-28 7:29 ` Juerg Haefliger
2023-06-28 7:37 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Juerg Haefliger @ 2023-06-28 7:29 UTC (permalink / raw)
To: Greg KH; +Cc: jk, joel, alistair, eajames, linux-fsi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
On Wed, 28 Jun 2023 08:47:12 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> > The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> > information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > ---
> > drivers/fsi/fsi-master-ast-cf.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> > index 5f608ef8b53c..1316bfd121fe 100644
> > --- a/drivers/fsi/fsi-master-ast-cf.c
> > +++ b/drivers/fsi/fsi-master-ast-cf.c
> > @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
> >
> > module_platform_driver(fsi_master_acf);
> > MODULE_LICENSE("GPL");
> > +
> > +MODULE_FIRMWARE(FW_FILE_NAME);
>
> No need for the extra blank line, right?
Guess not.
> And what commit id does this fix?
6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
Want me to send a v2?
...Juerg
> thanks,
>
> greg k-h
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
2023-06-28 7:29 ` Juerg Haefliger
@ 2023-06-28 7:37 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2023-06-28 7:37 UTC (permalink / raw)
To: Juerg Haefliger; +Cc: jk, joel, alistair, eajames, linux-fsi, linux-kernel
On Wed, Jun 28, 2023 at 09:29:46AM +0200, Juerg Haefliger wrote:
> On Wed, 28 Jun 2023 08:47:12 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> > > The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> > > information via modinfo.
> > >
> > > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > > ---
> > > drivers/fsi/fsi-master-ast-cf.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> > > index 5f608ef8b53c..1316bfd121fe 100644
> > > --- a/drivers/fsi/fsi-master-ast-cf.c
> > > +++ b/drivers/fsi/fsi-master-ast-cf.c
> > > @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
> > >
> > > module_platform_driver(fsi_master_acf);
> > > MODULE_LICENSE("GPL");
> > > +
> > > +MODULE_FIRMWARE(FW_FILE_NAME);
> >
> > No need for the extra blank line, right?
>
> Guess not.
>
>
> > And what commit id does this fix?
>
> 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
>
> Want me to send a v2?
Please do and properly add the fixes line and the cc: stable line so
that it will get backported correctly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
2023-06-16 12:20 [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro Juerg Haefliger
2023-06-28 6:47 ` Greg KH
@ 2023-06-28 9:50 ` Juerg Haefliger
1 sibling, 0 replies; 5+ messages in thread
From: Juerg Haefliger @ 2023-06-28 9:50 UTC (permalink / raw)
To: juerg.haefliger
Cc: alistair, eajames, jk, joel, linux-fsi, linux-kernel, stable
The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.
Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
Cc: stable@vger.kernel.org # 4.19+
Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
v2:
- Remove empty line
- Add Fixes and Cc tags
---
drivers/fsi/fsi-master-ast-cf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
index 5f608ef8b53c..cde281ec89d7 100644
--- a/drivers/fsi/fsi-master-ast-cf.c
+++ b/drivers/fsi/fsi-master-ast-cf.c
@@ -1441,3 +1441,4 @@ static struct platform_driver fsi_master_acf = {
module_platform_driver(fsi_master_acf);
MODULE_LICENSE("GPL");
+MODULE_FIRMWARE(FW_FILE_NAME);
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-28 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-16 12:20 [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro Juerg Haefliger
2023-06-28 6:47 ` Greg KH
2023-06-28 7:29 ` Juerg Haefliger
2023-06-28 7:37 ` Greg KH
2023-06-28 9:50 ` [PATCH v2] " Juerg Haefliger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.