From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Linux Kernel Functional Testing <lkft@linaro.org>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
lkft-triage@lists.linaro.org,
"David S. Miller" <davem@davemloft.net>,
Nathan Chancellor <nathan@kernel.org>,
Saeed Mahameed <saeed@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Gal Pressman <gal@nvidia.com>, LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH net v1] ptp: Make max_phase_adjustment sysfs device attribute invisible when not supported
Date: Wed, 28 Jun 2023 13:38:50 -0700 [thread overview]
Message-ID: <20230628133850.0d01d503@kernel.org> (raw)
In-Reply-To: <7fa02bc1-64bd-483d-b3e9-f4ffe0bbb9fb@lunn.ch>
On Wed, 28 Jun 2023 03:16:43 +0200 Andrew Lunn wrote:
> > + } else if (attr == &dev_attr_max_phase_adjustment.attr) {
> > + if (!info->adjphase || !info->getmaxphase)
> > + mode = 0;
>
> Maybe it is time to turn this into a switch statement?
I don't think we can switch on pointers in C.
The patch is good as is, right?
(The tree we'll pick appropriately when applying.)
--
Mailing list info: https://lists.linux.it/listinfo/ltp
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>,
netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeed@kernel.org>, Gal Pressman <gal@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
lkft-triage@lists.linaro.org, LTP List <ltp@lists.linux.it>,
Nathan Chancellor <nathan@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH net v1] ptp: Make max_phase_adjustment sysfs device attribute invisible when not supported
Date: Wed, 28 Jun 2023 13:38:50 -0700 [thread overview]
Message-ID: <20230628133850.0d01d503@kernel.org> (raw)
In-Reply-To: <7fa02bc1-64bd-483d-b3e9-f4ffe0bbb9fb@lunn.ch>
On Wed, 28 Jun 2023 03:16:43 +0200 Andrew Lunn wrote:
> > + } else if (attr == &dev_attr_max_phase_adjustment.attr) {
> > + if (!info->adjphase || !info->getmaxphase)
> > + mode = 0;
>
> Maybe it is time to turn this into a switch statement?
I don't think we can switch on pointers in C.
The patch is good as is, right?
(The tree we'll pick appropriately when applying.)
next prev parent reply other threads:[~2023-06-29 9:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 23:21 [LTP] [PATCH net v1] ptp: Make max_phase_adjustment sysfs device attribute invisible when not supported Rahul Rameshbabu via ltp
2023-06-27 23:21 ` Rahul Rameshbabu
2023-06-27 23:33 ` [LTP] " Nathan Chancellor
2023-06-27 23:33 ` Nathan Chancellor
2023-06-28 1:16 ` [LTP] " Andrew Lunn
2023-06-28 1:16 ` Andrew Lunn
2023-06-28 2:22 ` [LTP] " Rahul Rameshbabu via ltp
2023-06-28 2:22 ` Rahul Rameshbabu
2023-06-28 14:35 ` [LTP] " Andrew Lunn
2023-06-28 17:48 ` Rahul Rameshbabu via ltp
2023-06-28 18:15 ` Andrew Lunn
2023-06-28 20:38 ` Jakub Kicinski [this message]
2023-06-28 20:38 ` Jakub Kicinski
2023-06-28 20:46 ` [LTP] " Andrew Lunn
2023-06-28 20:46 ` Andrew Lunn
2023-06-28 20:55 ` [LTP] " Rahul Rameshbabu via ltp
2023-06-29 18:06 ` Jakub Kicinski
2023-06-29 18:06 ` Jakub Kicinski
2023-06-30 3:33 ` [LTP] " Richard Cochran
2023-06-30 3:33 ` Richard Cochran
2023-06-30 3:32 ` [LTP] " Richard Cochran
2023-06-30 3:32 ` Richard Cochran
2023-07-03 5:10 ` [LTP] " Petr Vorel
2023-07-03 5:10 ` Petr Vorel
2023-07-03 12:53 ` Cyril Hrubis
2023-07-03 12:53 ` Cyril Hrubis
2023-07-03 20:40 ` patchwork-bot+netdevbpf
2023-07-03 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628133850.0d01d503@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=lkft-triage@lists.linaro.org \
--cc=lkft@linaro.org \
--cc=ltp@lists.linux.it \
--cc=nathan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeed@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.