[master/kirkstone][PATCH v4 0/8] Add meta-sysrepo recipes

[master/kirkstone][PATCH v4 0/8] Add meta-sysrepo recipes

[Ravi Gunasekaran]

This series adds the meta-sysrepo recipes to meta-arago-extras
layer and a new package group to support sysrepo.

Changes since v3:
----------------
Corrected patch [8/8] as it was failing to apply.

Changes since v2:
----------------
1) Updated nw-configurator.bb by limiting check sum to only
the license part of the source code

2) Added the recipes from [1] as separate patch.
Patches [2/8] to [7/8] introduced in this series

3) Removed "PACKAGE_ARCH" from the packagegroup-arago-tisdk-sysrepo.bb

[1] - https://github.com/sartura/meta-sysrepo

Changes since v1:
----------------
Added a new package group packagegroup-arago-tisdk-sysrepo instead of
using ARAGO_DEFAULT_IMAGE_EXTRA_INSTALL.

Ravi Gunasekaran (8):
  meta-arago-extras: sysrepo: Update checksum for nw-configurator
  meta-arago-extras: sysrepo: Add libssh recipe needed for sysrepo
  meta-arago-extras: sysrepo: Add libyang recipe needed for sysrepo
  meta-arago-extras: sysrepo: Add libnetconf recipe neede for sysrepo
  meta-arago-extras: sysrepo: Add libredblack needed for sysrepo
  meta-arago-extras: sysrepo: Add sysrepo and sysrepo plugins
  meta-arago-extras: sysrepo: Add netopeer2 recipe
  tisdk-default-image: Add package group for netopeer/sysrepo

 .../images/tisdk-default-image.bb             |  1 +
 .../packagegroup-arago-tisdk-sysrepo.bb       | 15 ++++++
 .../libnetconf2/libnetconf2_git.bb            | 24 +++++++++
 .../libredblack/libredblack_git.bb            | 21 ++++++++
 .../recipes-sysrepo/libssh/libssh_0.9.5.bb    | 35 +++++++++++++
 .../recipes-sysrepo/libyang/libyang_git.bb    | 23 +++++++++
 .../netopeer2-server/netopeer2-server         | 35 +++++++++++++
 .../netopeer2-server/netopeer2-server_git.bb  | 31 +++++++++++
 .../nw-configurator/nw-configurator.bb        |  5 +-
 .../0001-so-version.patch                     | 12 +++++
 .../sysrepo-plugins-common_git.bb             | 26 ++++++++++
 .../recipes-sysrepo/sysrepo/sysrepo/sysrepo   | 51 +++++++++++++++++++
 .../recipes-sysrepo/sysrepo/sysrepo_git.bb    | 34 +++++++++++++
 13 files changed, 311 insertions(+), 2 deletions(-)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-sysrepo.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/libnetconf2/libnetconf2_git.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/libyang/libyang_git.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server/netopeer2-server
 create mode 100644 meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server_git.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/0001-so-version.patch
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/sysrepo-plugins-common_git.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo/sysrepo
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo_git.bb

-- 
2.17.1

[master/kirkstone][PATCH v4 1/8] meta-arago-extras: sysrepo: Update checksum for nw-configurator

[Ravi Gunasekaran]

Instead of using the source file to compute the license checksum,
use the license text only from source file.

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No change

Changes since v2:
----------------
1) Corrected the license type
2) License checksum calculated based on the license header instead of the 
entire source file

Changes since v1:
---------------
No change

 .../recipes-sysrepo/nw-configurator/nw-configurator.bb       | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
index 5a152017..c5d9a86b 100644
--- a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
+++ b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
@@ -1,6 +1,7 @@
-LICENSE="GPLv2"
 DESCRIPTION = "Sysrepo based repo to configure EST"
-LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=a818a6cf4fbeeb21acc8b4e9956c08a4"
+
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://nw-configurator.c;beginline=1;endline=33;md5=3538caaf9bfb8372347877ad393660fa"
 
 SRC_URI = "file://nw-configurator.c"
 
-- 
2.17.1

[master/kirkstone][PATCH v4 2/8] meta-arago-extras: sysrepo: Add libssh recipe needed for sysrepo

[Ravi Gunasekaran]

libnetconf2 is needed to build sysrepo. And libnetconf2 depends on
libssh. So add receipe for libssh.

The recipe is taken as-is from the commit 09f73e7 ("update for honister")
from the public repo [1].

[1] - https://github.com/sartura/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No change

Changes since v2:
---------------
Newly introduced in this series

 .../recipes-sysrepo/libssh/libssh_0.9.5.bb    | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb

diff --git a/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
new file mode 100644
index 00000000..43a6827e
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
@@ -0,0 +1,35 @@
+SUMMARY = "Multiplatform C library implementing the SSHv2 and SSHv1 protocol"
+HOMEPAGE = "http://www.libssh.org"
+SECTION = "libs"
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=dabb4958b830e5df11d2b0ed8ea255a0"
+
+DEPENDS = "zlib openssl"
+
+SRC_URI = "git://git.libssh.org/projects/libssh.git;branch=stable-0.9"
+SRCREV = "0cceefd49d4d397eb21bd36e314ac87739da51ff"
+
+S = "${WORKDIR}/git"
+
+inherit cmake
+
+PACKAGECONFIG ??=""
+PACKAGECONFIG[gssapi] = "-DWITH_GSSAPI=1, -DWITH_GSSAPI=0, krb5, "
+
+ARM_INSTRUCTION_SET:armv5 = "arm"
+
+EXTRA_OECMAKE = " \
+    -DWITH_GCRYPT=0 \
+    -DWITH_PCAP=1 \
+    -DWITH_SFTP=1 \
+    -DWITH_ZLIB=1 \
+    -DLIB_SUFFIX=${@d.getVar('baselib').replace('lib', '')} \
+    "
+
+do_configure:prepend () {
+    # Disable building of examples
+    sed -i -e '/add_subdirectory(examples)/s/^/#DONOTWANT/' ${S}/CMakeLists.txt \
+        || bbfatal "Failed to disable examples"
+}
+
+TOOLCHAIN = "gcc"
-- 
2.17.1

[master/kirkstone][PATCH v4 3/8] meta-arago-extras: sysrepo: Add libyang recipe needed for sysrepo

[Ravi Gunasekaran]

libyang library is needed to build sysrepo and libnetconf2.
So add recipe for libyang.

The recipe is taken as-is from the commit 09f73e7 ("update for honister")
from the public repo [1].

[1] - https://github.com/sartura/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No change

Changes since v2:
---------------
Newly introduced in this series

 .../recipes-sysrepo/libyang/libyang_git.bb    | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-arago-extras/recipes-sysrepo/libyang/libyang_git.bb

diff --git a/meta-arago-extras/recipes-sysrepo/libyang/libyang_git.bb b/meta-arago-extras/recipes-sysrepo/libyang/libyang_git.bb
new file mode 100644
index 00000000..c984a252
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/libyang/libyang_git.bb
@@ -0,0 +1,23 @@
+SUMMARY = "YANG data modelling language parser and toolkit"
+DESCRIPTION = "libyang is YANG data modelling language parser and toolkit written (and providing API) in C. The library is used e.g. in libnetconf2, Netopeer2 or sysrepo projects."
+SECTION = "libs"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=f3916d7d8d42a6508d0ea418cfff10ad"
+
+SRC_URI = "git://github.com/CESNET/libyang.git;protocol=https;branch=devel"
+
+PV = "2.1.77+git${SRCPV}"
+SRCREV = "a804113c9bbac3e36c53221be469c1ca5af5b435"
+
+S = "${WORKDIR}/git"
+
+DEPENDS = "libpcre2"
+
+FILES:${PN} += "/usr/share/yang/modules/libyang/*"
+
+inherit cmake pkgconfig
+
+# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
+EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_BUILD_TYPE:String=Release "
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.17.1

[master/kirkstone][PATCH v4 4/8] meta-arago-extras: sysrepo: Add libnetconf recipe neede for sysrepo

[Ravi Gunasekaran]

libnetconf2 is needed to build sysrepo. Add the recipe for libnetconf2.

The recipe is taken as-is from the commit 09f73e7 ("update for honister")
from the public repo [1].

[1] - https://github.com/sartura/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No change

Changes since v2:
---------------
Newly introduced in this series

 .../libnetconf2/libnetconf2_git.bb            | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta-arago-extras/recipes-sysrepo/libnetconf2/libnetconf2_git.bb

diff --git a/meta-arago-extras/recipes-sysrepo/libnetconf2/libnetconf2_git.bb b/meta-arago-extras/recipes-sysrepo/libnetconf2/libnetconf2_git.bb
new file mode 100644
index 00000000..a534b9ac
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/libnetconf2/libnetconf2_git.bb
@@ -0,0 +1,24 @@
+SUMMARY = "libnetconf2 is a NETCONF library in C intended for building NETCONF clients and servers"
+DESCRIPTION = "The library provides functions to connect NETCONF client and server to each other via SSH and to send, receive and process NETCONF messages."
+SECTION = "libs"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=08a5578c9bab06fb2ae84284630b973f"
+
+SRC_URI = "git://github.com/CESNET/libnetconf2.git;protocol=https;branch=devel"
+
+PV = "2.1.34+git${SRCPV}"
+SRCREV = "91cd6d75722c65de5c005d908f6d645b48cee89b"
+
+S = "${WORKDIR}/git"
+
+DEPENDS = "libssh openssl libyang libxcrypt libpam"
+
+FILES:${PN} += "/usr/share/yang/modules/libnetconf2/*"
+
+inherit cmake pkgconfig
+
+# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
+#EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_BUILD_TYPE:String=Release -DLIBYANG_INCLUDE_DIR=/usr/include -DLIBYANG_LIBRARY=/usr/lib "
+EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_BUILD_TYPE:String=Release "
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.17.1

[master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Ravi Gunasekaran]

libredblack is needed to build sysrepo. Add recipe for libredblack.

The recipe is taken as-is from the commit 09f73e7 ("update for honister")
from the public repo [1].

[1] - https://github.com/sartura/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No change

Changes since v2:
---------------
Newly introduced in this series

 .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb

diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
new file mode 100644
index 00000000..ea51b618
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
@@ -0,0 +1,21 @@
+SUMMARY = "Library for handling red-black tree searching algorithm"
+DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
+
+SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
+
+PV = "1.0+git${SRCPV}"
+SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
+
+S = "${WORKDIR}/git"
+
+# NOTE: if this software is not capable of being built in a separate build directory
+# from the source, you should replace autotools with autotools-brokensep in the
+# inherit line
+inherit python3native autotools
+
+# Specify any options you want to pass to the configure script using EXTRA_OECONF:
+EXTRA_OECONF = " --without-rbgen "
+
+BBCLASSEXTEND = "native nativesdk"
-- 
2.17.1

[master/kirkstone][PATCH v4 6/8] meta-arago-extras: sysrepo: Add sysrepo and sysrepo plugins

[Ravi Gunasekaran]

NETCONF protocol is implemented via netopeer2/sysrepo.
Add the sysrepo recipe so that the NETCONF protocol can be realized
on devices supporting ethernet.

The recipe is taken as-is from the commit 09f73e7 ("update for honister")
from the public repo [1].

[1] - https://github.com/sartura/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No changes

Changes since v2:
---------------
Newly introduced in this series

 .../0001-so-version.patch                     | 12 +++++
 .../sysrepo-plugins-common_git.bb             | 26 ++++++++++
 .../recipes-sysrepo/sysrepo/sysrepo/sysrepo   | 51 +++++++++++++++++++
 .../recipes-sysrepo/sysrepo/sysrepo_git.bb    | 34 +++++++++++++
 4 files changed, 123 insertions(+)
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/0001-so-version.patch
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/sysrepo-plugins-common_git.bb
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo/sysrepo
 create mode 100644 meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo_git.bb

diff --git a/meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/0001-so-version.patch b/meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/0001-so-version.patch
new file mode 100644
index 00000000..0eabf6a9
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/0001-so-version.patch
@@ -0,0 +1,12 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index fd64b80..910510d 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -23,6 +23,7 @@ include_directories(${LIBYANG_INCLUDE_DIRS})
+ include_directories(${SYSREPO_INCLUDE_DIRS})
+
+ add_library(${PROJECT_NAME} SHARED ${SRPC_SOURCES})
++set_target_properties(${PROJECT_NAME} PROPERTIES VERSION 1.0.0 SOVERSION 1)
+
+ install(
+     TARGETS ${PROJECT_NAME}
diff --git a/meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/sysrepo-plugins-common_git.bb b/meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/sysrepo-plugins-common_git.bb
new file mode 100644
index 00000000..48f6bc35
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/sysrepo-plugins-common/sysrepo-plugins-common_git.bb
@@ -0,0 +1,26 @@
+SUMMARY = "Set of utilities/functionalities which can be used for easier build of sysrepo plugins."
+DESCRIPTION = ""
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=f91d5dfaae99cc1943a8eca222cafa5c"
+
+SRC_URI = "gitsm://github.com/telekom/sysrepo-plugins-common.git;protocol=https;branch=devel "
+SRC_URI += " file://0001-so-version.patch "
+FILESEXTRAPATHS:prepend := "${THISDIR}:"
+
+PV = "dev+git${SRCPV}"
+SRCREV = "20885de0d3bb95a05610fdb3a0f83d8f7c370fad"
+
+S = "${WORKDIR}/git"
+
+DEPENDS = "libyang sysrepo"
+
+FILES:${PN} += ""
+
+inherit cmake pkgconfig
+
+# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
+EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX:PATH=/usr "
+
+do_install:append () {
+    true
+}
diff --git a/meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo/sysrepo b/meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo/sysrepo
new file mode 100644
index 00000000..06881c68
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo/sysrepo
@@ -0,0 +1,51 @@
+#!/bin/sh
+
+# Source function library.
+. /etc/init.d/functions
+
+EXEC_PATH="/usr/bin"
+SYSREPOPLUGIND_EXEC="sysrepo-plugind"
+SERVER_OPTS=" -d -v 1"
+
+init_sysrepo() {
+    export NP2_MODULE_DIR="/usr/share/yang/modules/netopeer2"
+    export NP2_MODULE_PERMS="600"
+    export NP2_MODULE_OWNER="root"
+    export NP2_MODULE_GROUP="root"
+    if [ -x /usr/bin/sysrepoctl ]; then
+        sh /etc/netopeer2/scripts/setup.sh
+    fi
+    if [ -x /usr/bin/sysrepocfg ]; then
+        sh /etc/netopeer2/scripts/merge_hostkey.sh
+        sh /etc/netopeer2/scripts/merge_config.sh
+    fi
+    touch /etc/sysrepo/init
+}
+
+
+case "$1" in
+    start)
+        test -r /etc/sysrepo/init || init_sysrepo
+        start-stop-daemon --start --background --exec $EXEC_PATH/$SYSREPOPLUGIND_EXEC -- $SERVER_OPTS
+        ;;
+    stop)
+        start-stop-daemon --stop --quiet --exec $EXEC_PATH/$SYSREPOPLUGIND_EXEC
+        rm -rf /var/run/sysrepo-subscriptions/*
+        ;;
+    status)
+        status $SYSREPOPLUGIND_EXEC
+        ;;
+    reload)
+        echo "not supported"
+        ;;
+    restart)
+        $0 stop
+        $0 start
+        ;;
+    *)
+        echo "Usage: $0 {start|stop|status|restart}"
+        exit 1;;
+esac
+
+
+exit 0
diff --git a/meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo_git.bb b/meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo_git.bb
new file mode 100644
index 00000000..18da3ca3
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/sysrepo/sysrepo_git.bb
@@ -0,0 +1,34 @@
+# Recipe created by recipetool
+SUMMARY = "YANG-based configuration and operational state data store for Unix/Linux applications."
+DESCRIPTION = ""
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=ef345f161efb68c3836e6f5648b2312f"
+
+SRC_URI = "git://github.com/sysrepo/sysrepo.git;protocol=https;branch=devel file://sysrepo"
+
+PV = "2.2.71+git${SRCPV}"
+SRCREV = "b828f0ab4693c613cc66efd053a146e05854d5c8"
+
+S = "${WORKDIR}/git"
+
+DEPENDS = "libyang protobuf protobuf-c protobuf-c-native libredblack libev libnetconf2"
+
+FILES:${PN} += "/usr/share/yang/* /usr/lib/sysrepo-plugind/*"
+
+inherit cmake pkgconfig python3native python3-dir
+
+# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
+EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_BUILD_TYPE:String=Release -DBUILD_EXAMPLES:String=False -DENABLE_TESTS:String=False -DREPOSITORY_LOC:PATH=/etc/sysrepo  -DCALL_TARGET_BINS_DIRECTLY=False -DGEN_LANGUAGE_BINDINGS:String=False "
+
+BBCLASSEXTEND = "native nativesdk"
+
+do_install:append () {
+    install -d ${D}/etc/sysrepo/data/notifications
+    install -d ${D}/etc/sysrepo/yang
+    install -o root -g root ${S}/modules/ietf-netconf-notifications.yang ${D}/etc/sysrepo/yang/ietf-netconf-notifications@2012-02-06.yang
+    install -o root -g root ${S}/modules/ietf-netconf-with-defaults.yang ${D}/etc/sysrepo/yang/ietf-netconf-with-defaults@2011-06-01.yang
+    install -o root -g root ${S}/modules/ietf-netconf.yang ${D}/etc/sysrepo/yang/ietf-netconf@2011-06-01.yang
+    install -d ${D}/etc/init.d
+    install -m 0775 ${WORKDIR}/sysrepo ${D}/etc/init.d/
+    install -d ${D}/usr/lib/sysrepo/plugins
+}
-- 
2.17.1

[master/kirkstone][PATCH v4 7/8] meta-arago-extras: sysrepo: Add netopeer2 recipe

[Ravi Gunasekaran]

NETCONF protocol is implemented via netopeer2/sysrepo.
Add the netopeer2 recipe so that the NETCONF protocol can be realized
on devices supporting ethernet.

The recipe is taken as-is from the commit 09f73e7 ("update for honister")
from the public repo [1].

[1] - https://github.com/sartura/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
No changes

Changes since v2:
---------------
Newly introduced in this series

 .../netopeer2-server/netopeer2-server         | 35 +++++++++++++++++++
 .../netopeer2-server/netopeer2-server_git.bb  | 31 ++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server/netopeer2-server
 create mode 100644 meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server_git.bb

diff --git a/meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server/netopeer2-server b/meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server/netopeer2-server
new file mode 100644
index 00000000..7077df03
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server/netopeer2-server
@@ -0,0 +1,35 @@
+#!/bin/sh
+
+# Source function library.
+. /etc/init.d/functions
+
+EXEC_PATH="/usr/sbin"
+SERVER_EXEC="netopeer2-server"
+SERVER_OPTS=" -v 1"
+
+
+case "$1" in
+    start)
+        /etc/init.d/sysrepo start
+        start-stop-daemon --start --exec $EXEC_PATH/$SERVER_EXEC -- $SERVER_OPTS
+        ;;
+    stop)
+        start-stop-daemon --stop --quiet --exec $EXEC_PATH/$SERVER_EXEC
+        ;;
+    status)
+        status $SERVER_EXEC
+        ;;
+    reload)
+        echo "not supported"
+        ;;
+    restart)
+        $0 stop
+        $0 start
+        ;;
+    *)
+        echo "Usage: $0 {start|stop|status|restart}"
+        exit 1;;
+esac
+
+
+exit 0
diff --git a/meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server_git.bb b/meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server_git.bb
new file mode 100644
index 00000000..e4278d23
--- /dev/null
+++ b/meta-arago-extras/recipes-sysrepo/netopeer2-server/netopeer2-server_git.bb
@@ -0,0 +1,31 @@
+SUMMARY = "Netopeer2 is a set of tools implementing network configuration tools based on the NETCONF Protocol."
+DESCRIPTION = "Netopeer2 is based on the new generation of the NETCONF and YANG libraries - libyang and libnetconf2. The Netopeer server uses sysrepo as a NETCONF datastore implementation."
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=41daedff0b24958b2eba4f9086d782e1"
+
+SRC_URI = "git://github.com/CESNET/Netopeer2.git;protocol=https;branch=devel file://netopeer2-server"
+
+PV = "2.1.59+git${SRCPV}"
+SRCREV = "b81788d9a81770313a0eb7f88d4224726b3d6e15"
+
+S = "${WORKDIR}/git"
+
+DEPENDS = "libyang libnetconf2 sysrepo curl"
+RDEPENDS:${PN} += "bash curl"
+
+FILES:${PN} += "/usr/share/yang* /usr/share/netopeer2/* /usr/lib/sysrepo-plugind/*"
+
+inherit cmake pkgconfig
+
+# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
+EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE:String=Release -DINSTALL_MODULES=OFF -DGENERATE_HOSTKEY=OFF -DMERGE_LISTEN_CONFIG=OFF"
+
+do_install:append () {
+    install -d ${D}/etc/netopeer2/scripts
+    install -o root -g root ${S}/scripts/setup.sh ${D}/etc/netopeer2/scripts/setup.sh
+    install -o root -g root ${S}/scripts/merge_hostkey.sh ${D}/etc/netopeer2/scripts/merge_hostkey.sh
+    install -o root -g root ${S}/scripts/merge_config.sh ${D}/etc/netopeer2/scripts/merge_config.sh
+    install -d ${D}/etc/netopeer2
+    install -d ${D}/etc/init.d
+    install -m 0755 ${WORKDIR}/netopeer2-server ${D}/etc/init.d/
+}
-- 
2.17.1

[master/kirkstone][PATCH v4 8/8] tisdk-default-image: Add package group for netopeer/sysrepo

[Ravi Gunasekaran]

Add new package group for netopeer2, sysrepo, nw-configurator
and yang models.

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---

Changes since v3:
----------------
Fixed the patch as it was failing to apply cleanly

Changes since v2:
----------------
Removed "PACKAGE_ARCH" as this is not machine specific.

Changes since v1:
----------------
Added a new package group packagegroup-arago-tisdk-sysrepo instead of
using ARAGO_DEFAULT_IMAGE_EXTRA_INSTALL.

 .../recipes-core/images/tisdk-default-image.bb    |  1 +
 .../packagegroup-arago-tisdk-sysrepo.bb           | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-sysrepo.bb

diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
index bb825e09..7769c97c 100644
--- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
+++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
@@ -28,6 +28,7 @@ IMAGE_INSTALL += "\
     ti-analytics \
     ti-demos \
     ${ARAGO_DEFAULT_IMAGE_EXTRA_INSTALL} \
+    packagegroup-arago-tisdk-sysrepo \
 "
 
 export IMAGE_BASENAME = "tisdk-default-image"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-sysrepo.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-sysrepo.bb
new file mode 100644
index 00000000..c0bb599b
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-sysrepo.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Netopeer2 and Sysrepo packagegroup"
+LICENSE = "MIT"
+
+inherit packagegroup
+
+ARAGO_NETOPEER_SYSREPO = "\
+    sysrepo \
+    netopeer2-server \
+    nw-configurator \
+    tsn-yang-models \
+"
+
+RDEPENDS:${PN} = "\
+    ${ARAGO_NETOPEER_SYSREPO} \
+"
-- 
2.17.1

Re: [master/kirkstone][PATCH v4 2/8] meta-arago-extras: sysrepo: Add libssh recipe needed for sysrepo

[Andrew Davis]

On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
> libnetconf2 is needed to build sysrepo. And libnetconf2 depends on
> libssh. So add receipe for libssh.
> 

What is wrong with the version of libssh already in meta-oe?

Andrew

> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
> from the public repo [1].
> 
> [1] - https://github.com/sartura/meta-sysrepo
> 
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> 
> Changes since v3:
> ----------------
> No change
> 
> Changes since v2:
> ---------------
> Newly introduced in this series
> 
>   .../recipes-sysrepo/libssh/libssh_0.9.5.bb    | 35 +++++++++++++++++++
>   1 file changed, 35 insertions(+)
>   create mode 100644 meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
> 
> diff --git a/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
> new file mode 100644
> index 00000000..43a6827e
> --- /dev/null
> +++ b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
> @@ -0,0 +1,35 @@
> +SUMMARY = "Multiplatform C library implementing the SSHv2 and SSHv1 protocol"
> +HOMEPAGE = "http://www.libssh.org"
> +SECTION = "libs"
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=dabb4958b830e5df11d2b0ed8ea255a0"
> +
> +DEPENDS = "zlib openssl"
> +
> +SRC_URI = "git://git.libssh.org/projects/libssh.git;branch=stable-0.9"
> +SRCREV = "0cceefd49d4d397eb21bd36e314ac87739da51ff"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit cmake
> +
> +PACKAGECONFIG ??=""
> +PACKAGECONFIG[gssapi] = "-DWITH_GSSAPI=1, -DWITH_GSSAPI=0, krb5, "
> +
> +ARM_INSTRUCTION_SET:armv5 = "arm"
> +
> +EXTRA_OECMAKE = " \
> +    -DWITH_GCRYPT=0 \
> +    -DWITH_PCAP=1 \
> +    -DWITH_SFTP=1 \
> +    -DWITH_ZLIB=1 \
> +    -DLIB_SUFFIX=${@d.getVar('baselib').replace('lib', '')} \
> +    "
> +
> +do_configure:prepend () {
> +    # Disable building of examples
> +    sed -i -e '/add_subdirectory(examples)/s/^/#DONOTWANT/' ${S}/CMakeLists.txt \
> +        || bbfatal "Failed to disable examples"
> +}
> +
> +TOOLCHAIN = "gcc"

Re: [master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Andrew Davis]

On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
> libredblack is needed to build sysrepo. Add recipe for libredblack.
> 
> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
> from the public repo [1].
> 
> [1] - https://github.com/sartura/meta-sysrepo
> 
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> 
> Changes since v3:
> ----------------
> No change
> 
> Changes since v2:
> ---------------
> Newly introduced in this series
> 
>   .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
>   1 file changed, 21 insertions(+)
>   create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> 
> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> new file mode 100644
> index 00000000..ea51b618
> --- /dev/null
> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> @@ -0,0 +1,21 @@
> +SUMMARY = "Library for handling red-black tree searching algorithm"
> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
> +
> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
> +
> +PV = "1.0+git${SRCPV}"
> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
> +
> +S = "${WORKDIR}/git"
> +
> +# NOTE: if this software is not capable of being built in a separate build directory
> +# from the source, you should replace autotools with autotools-brokensep in the
> +# inherit line

This comment isn't needed.

I understand the 1:1 copy from the original repo, but after you should have another patch
that comes back and cleans these up. If they are to live in meta-arago they need to be up
to the standards.

Andrew

> +inherit python3native autotools
> +
> +# Specify any options you want to pass to the configure script using EXTRA_OECONF:
> +EXTRA_OECONF = " --without-rbgen "
> +
> +BBCLASSEXTEND = "native nativesdk"

Re: [master/kirkstone][PATCH v4 2/8] meta-arago-extras: sysrepo: Add libssh recipe needed for sysrepo

[Ravi Gunasekaran]

On 6/27/23 8:26 PM, Andrew Davis wrote:
> On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
>> libnetconf2 is needed to build sysrepo. And libnetconf2 depends on
>> libssh. So add receipe for libssh.
>>
> 
> What is wrong with the version of libssh already in meta-oe?

The recommended version of libssh for libnetconf2 is 0.9. [1]
While the version of libssh in meta-oe is 0.8

[1] - https://github.com/CESNET/libnetconf2

> 
> Andrew
> 
>> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
>> from the public repo [1].
>>
>> [1] - https://github.com/sartura/meta-sysrepo
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>
>> Changes since v3:
>> ----------------
>> No change
>>
>> Changes since v2:
>> ---------------
>> Newly introduced in this series
>>
>>   .../recipes-sysrepo/libssh/libssh_0.9.5.bb    | 35 +++++++++++++++++++
>>   1 file changed, 35 insertions(+)
>>   create mode 100644 meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
>>
>> diff --git a/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
>> new file mode 100644
>> index 00000000..43a6827e
>> --- /dev/null
>> +++ b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
>> @@ -0,0 +1,35 @@
>> +SUMMARY = "Multiplatform C library implementing the SSHv2 and SSHv1 protocol"
>> +HOMEPAGE = "http://www.libssh.org"
>> +SECTION = "libs"
>> +LICENSE = "LGPLv2.1"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=dabb4958b830e5df11d2b0ed8ea255a0"
>> +
>> +DEPENDS = "zlib openssl"
>> +
>> +SRC_URI = "git://git.libssh.org/projects/libssh.git;branch=stable-0.9"
>> +SRCREV = "0cceefd49d4d397eb21bd36e314ac87739da51ff"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +inherit cmake
>> +
>> +PACKAGECONFIG ??=""
>> +PACKAGECONFIG[gssapi] = "-DWITH_GSSAPI=1, -DWITH_GSSAPI=0, krb5, "
>> +
>> +ARM_INSTRUCTION_SET:armv5 = "arm"
>> +
>> +EXTRA_OECMAKE = " \
>> +    -DWITH_GCRYPT=0 \
>> +    -DWITH_PCAP=1 \
>> +    -DWITH_SFTP=1 \
>> +    -DWITH_ZLIB=1 \
>> +    -DLIB_SUFFIX=${@d.getVar('baselib').replace('lib', '')} \
>> +    "
>> +
>> +do_configure:prepend () {
>> +    # Disable building of examples
>> +    sed -i -e '/add_subdirectory(examples)/s/^/#DONOTWANT/' ${S}/CMakeLists.txt \
>> +        || bbfatal "Failed to disable examples"
>> +}
>> +
>> +TOOLCHAIN = "gcc"

-- 
Regards,
Ravi

Re: [master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Ravi Gunasekaran]

Andrew,

On 6/27/23 8:32 PM, Andrew Davis wrote:
> On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
>> libredblack is needed to build sysrepo. Add recipe for libredblack.
>>
>> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
>> from the public repo [1].
>>
>> [1] - https://github.com/sartura/meta-sysrepo
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>
>> Changes since v3:
>> ----------------
>> No change
>>
>> Changes since v2:
>> ---------------
>> Newly introduced in this series
>>
>>   .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
>>   1 file changed, 21 insertions(+)
>>   create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>
>> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>> new file mode 100644
>> index 00000000..ea51b618
>> --- /dev/null
>> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>> @@ -0,0 +1,21 @@
>> +SUMMARY = "Library for handling red-black tree searching algorithm"
>> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
>> +LICENSE = "LGPLv2.1"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
>> +
>> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
>> +
>> +PV = "1.0+git${SRCPV}"
>> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +# NOTE: if this software is not capable of being built in a separate build directory
>> +# from the source, you should replace autotools with autotools-brokensep in the
>> +# inherit line
> 
> This comment isn't needed.
> 
> I understand the 1:1 copy from the original repo, but after you should have another patch
> that comes back and cleans these up. If they are to live in meta-arago they need to be up
> to the standards.

Understood. 
I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending
the next version, I will add another patch in the series to remove this "Note".
Incase the series is acceptable, then I will send out a separate patch to remove the "Note"

> 
> Andrew
> 
>> +inherit python3native autotools
>> +
>> +# Specify any options you want to pass to the configure script using EXTRA_OECONF:
>> +EXTRA_OECONF = " --without-rbgen "
>> +
>> +BBCLASSEXTEND = "native nativesdk"

-- 
Regards,
Ravi

Re: [master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Ryan Eatmon]

On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote:
> Andrew,
> 
> On 6/27/23 8:32 PM, Andrew Davis wrote:
>> On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
>>> libredblack is needed to build sysrepo. Add recipe for libredblack.
>>>
>>> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
>>> from the public repo [1].
>>>
>>> [1] - https://github.com/sartura/meta-sysrepo
>>>
>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>> ---
>>>
>>> Changes since v3:
>>> ----------------
>>> No change
>>>
>>> Changes since v2:
>>> ---------------
>>> Newly introduced in this series
>>>
>>>    .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
>>>    1 file changed, 21 insertions(+)
>>>    create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>>
>>> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>> new file mode 100644
>>> index 00000000..ea51b618
>>> --- /dev/null
>>> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>> @@ -0,0 +1,21 @@
>>> +SUMMARY = "Library for handling red-black tree searching algorithm"
>>> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
>>> +LICENSE = "LGPLv2.1"
>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
>>> +
>>> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
>>> +
>>> +PV = "1.0+git${SRCPV}"
>>> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +# NOTE: if this software is not capable of being built in a separate build directory
>>> +# from the source, you should replace autotools with autotools-brokensep in the
>>> +# inherit line
>>
>> This comment isn't needed.
>>
>> I understand the 1:1 copy from the original repo, but after you should have another patch
>> that comes back and cleans these up. If they are to live in meta-arago they need to be up
>> to the standards.
> 
> Understood.
> I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending
> the next version, I will add another patch in the series to remove this "Note".
> Incase the series is acceptable, then I will send out a separate patch to remove the "Note"


What you have is fine for accepting this series.  Just submit a new 
patch that cleans it up.


>>
>> Andrew
>>
>>> +inherit python3native autotools
>>> +
>>> +# Specify any options you want to pass to the configure script using EXTRA_OECONF:
>>> +EXTRA_OECONF = " --without-rbgen "
>>> +
>>> +BBCLASSEXTEND = "native nativesdk"
> 

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

Re: [master/kirkstone][PATCH v4 1/8] meta-arago-extras: sysrepo: Update checksum for nw-configurator

[Denys Dmytriyenko]

On Tue, Jun 27, 2023 at 08:12:42PM +0530, Ravi Gunasekaran wrote:
> Instead of using the source file to compute the license checksum,
> use the license text only from source file.
> 
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> 
> Changes since v3:
> ----------------
> No change
> 
> Changes since v2:
> ----------------
> 1) Corrected the license type
> 2) License checksum calculated based on the license header instead of the 
> entire source file
> 
> Changes since v1:
> ---------------
> No change
> 
>  .../recipes-sysrepo/nw-configurator/nw-configurator.bb       | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
> index 5a152017..c5d9a86b 100644
> --- a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
> +++ b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
> @@ -1,6 +1,7 @@
> -LICENSE="GPLv2"
>  DESCRIPTION = "Sysrepo based repo to configure EST"
> -LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=a818a6cf4fbeeb21acc8b4e9956c08a4"
> +
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://nw-configurator.c;beginline=1;endline=33;md5=3538caaf9bfb8372347877ad393660fa"

Thanks, this is a move in the right direction!

However, you also changed the LICENSE identifier w/o explaining the reason in 
the commit message! This is rather critical... I checked the nw-configurator.c 
and indeed GPLv2 was totally wrong, but you have to explain the change anyway. 
Going forward there will be a new requirement for Yocto compliance to properly 
explain license changes like that and there's a new field "License-Update:"
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Describing_license_changes


>  SRC_URI = "file://nw-configurator.c"

Re: [master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Denys Dmytriyenko]

On Wed, Jun 28, 2023 at 10:52:26AM -0500, Ryan Eatmon wrote:
> 
> 
> On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote:
> >Andrew,
> >
> >On 6/27/23 8:32 PM, Andrew Davis wrote:
> >>On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
> >>>libredblack is needed to build sysrepo. Add recipe for libredblack.
> >>>
> >>>The recipe is taken as-is from the commit 09f73e7 ("update for honister")
> >>>from the public repo [1].
> >>>
> >>>[1] - https://github.com/sartura/meta-sysrepo
> >>>
> >>>Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> >>>---
> >>>
> >>>Changes since v3:
> >>>----------------
> >>>No change
> >>>
> >>>Changes since v2:
> >>>---------------
> >>>Newly introduced in this series
> >>>
> >>>   .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
> >>>   1 file changed, 21 insertions(+)
> >>>   create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> >>>
> >>>diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> >>>new file mode 100644
> >>>index 00000000..ea51b618
> >>>--- /dev/null
> >>>+++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> >>>@@ -0,0 +1,21 @@
> >>>+SUMMARY = "Library for handling red-black tree searching algorithm"
> >>>+DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
> >>>+LICENSE = "LGPLv2.1"
> >>>+LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
> >>>+
> >>>+SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
> >>>+
> >>>+PV = "1.0+git${SRCPV}"
> >>>+SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
> >>>+
> >>>+S = "${WORKDIR}/git"
> >>>+
> >>>+# NOTE: if this software is not capable of being built in a separate build directory
> >>>+# from the source, you should replace autotools with autotools-brokensep in the
> >>>+# inherit line
> >>
> >>This comment isn't needed.
> >>
> >>I understand the 1:1 copy from the original repo, but after you should have another patch
> >>that comes back and cleans these up. If they are to live in meta-arago they need to be up
> >>to the standards.
> >
> >Understood.
> >I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending
> >the next version, I will add another patch in the series to remove this "Note".
> >Incase the series is acceptable, then I will send out a separate patch to remove the "Note"
> 
> 
> What you have is fine for accepting this series.  Just submit a new
> patch that cleans it up.

+1 here. Good enough for merging, please address remaining comments in the 
follow up patches. Thanks.

-- 
Denys

Re: [master/kirkstone][PATCH v4 2/8] meta-arago-extras: sysrepo: Add libssh recipe needed for sysrepo

[Denys Dmytriyenko]

On Wed, Jun 28, 2023 at 09:47:36AM +0530, Ravi Gunasekaran wrote:
> 
> 
> On 6/27/23 8:26 PM, Andrew Davis wrote:
> > On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
> >> libnetconf2 is needed to build sysrepo. And libnetconf2 depends on
> >> libssh. So add receipe for libssh.
> >>
> > 
> > What is wrong with the version of libssh already in meta-oe?
> 
> The recommended version of libssh for libnetconf2 is 0.9. [1]
> While the version of libssh in meta-oe is 0.8
> 
> [1] - https://github.com/CESNET/libnetconf2

Kirkstone or master?



> >> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
> >> from the public repo [1].
> >>
> >> [1] - https://github.com/sartura/meta-sysrepo
> >>
> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> >> ---
> >>
> >> Changes since v3:
> >> ----------------
> >> No change
> >>
> >> Changes since v2:
> >> ---------------
> >> Newly introduced in this series
> >>
> >>   .../recipes-sysrepo/libssh/libssh_0.9.5.bb    | 35 +++++++++++++++++++
> >>   1 file changed, 35 insertions(+)
> >>   create mode 100644 meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
> >>
> >> diff --git a/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
> >> new file mode 100644
> >> index 00000000..43a6827e
> >> --- /dev/null
> >> +++ b/meta-arago-extras/recipes-sysrepo/libssh/libssh_0.9.5.bb
> >> @@ -0,0 +1,35 @@
> >> +SUMMARY = "Multiplatform C library implementing the SSHv2 and SSHv1 protocol"
> >> +HOMEPAGE = "http://www.libssh.org"
> >> +SECTION = "libs"
> >> +LICENSE = "LGPLv2.1"
> >> +LIC_FILES_CHKSUM = "file://COPYING;md5=dabb4958b830e5df11d2b0ed8ea255a0"
> >> +
> >> +DEPENDS = "zlib openssl"
> >> +
> >> +SRC_URI = "git://git.libssh.org/projects/libssh.git;branch=stable-0.9"
> >> +SRCREV = "0cceefd49d4d397eb21bd36e314ac87739da51ff"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +inherit cmake
> >> +
> >> +PACKAGECONFIG ??=""
> >> +PACKAGECONFIG[gssapi] = "-DWITH_GSSAPI=1, -DWITH_GSSAPI=0, krb5, "
> >> +
> >> +ARM_INSTRUCTION_SET:armv5 = "arm"
> >> +
> >> +EXTRA_OECMAKE = " \
> >> +    -DWITH_GCRYPT=0 \
> >> +    -DWITH_PCAP=1 \
> >> +    -DWITH_SFTP=1 \
> >> +    -DWITH_ZLIB=1 \
> >> +    -DLIB_SUFFIX=${@d.getVar('baselib').replace('lib', '')} \
> >> +    "
> >> +
> >> +do_configure:prepend () {
> >> +    # Disable building of examples
> >> +    sed -i -e '/add_subdirectory(examples)/s/^/#DONOTWANT/' ${S}/CMakeLists.txt \
> >> +        || bbfatal "Failed to disable examples"
> >> +}
> >> +
> >> +TOOLCHAIN = "gcc"

Re: [meta-arago] [master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Denys Dmytriyenko]

On Wed, Jun 28, 2023 at 01:56:06PM -0400, Denys Dmytriyenko wrote:
> On Wed, Jun 28, 2023 at 10:52:26AM -0500, Ryan Eatmon wrote:
> > 
> > 
> > On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote:
> > >Andrew,
> > >
> > >On 6/27/23 8:32 PM, Andrew Davis wrote:
> > >>On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
> > >>>libredblack is needed to build sysrepo. Add recipe for libredblack.
> > >>>
> > >>>The recipe is taken as-is from the commit 09f73e7 ("update for honister")
> > >>>from the public repo [1].
> > >>>
> > >>>[1] - https://github.com/sartura/meta-sysrepo
> > >>>
> > >>>Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> > >>>---
> > >>>
> > >>>Changes since v3:
> > >>>----------------
> > >>>No change
> > >>>
> > >>>Changes since v2:
> > >>>---------------
> > >>>Newly introduced in this series
> > >>>
> > >>>   .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
> > >>>   1 file changed, 21 insertions(+)
> > >>>   create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> > >>>
> > >>>diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> > >>>new file mode 100644
> > >>>index 00000000..ea51b618
> > >>>--- /dev/null
> > >>>+++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
> > >>>@@ -0,0 +1,21 @@
> > >>>+SUMMARY = "Library for handling red-black tree searching algorithm"
> > >>>+DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
> > >>>+LICENSE = "LGPLv2.1"
> > >>>+LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
> > >>>+
> > >>>+SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
> > >>>+
> > >>>+PV = "1.0+git${SRCPV}"
> > >>>+SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
> > >>>+
> > >>>+S = "${WORKDIR}/git"
> > >>>+
> > >>>+# NOTE: if this software is not capable of being built in a separate build directory
> > >>>+# from the source, you should replace autotools with autotools-brokensep in the
> > >>>+# inherit line
> > >>
> > >>This comment isn't needed.
> > >>
> > >>I understand the 1:1 copy from the original repo, but after you should have another patch
> > >>that comes back and cleans these up. If they are to live in meta-arago they need to be up
> > >>to the standards.
> > >
> > >Understood.
> > >I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending
> > >the next version, I will add another patch in the series to remove this "Note".
> > >Incase the series is acceptable, then I will send out a separate patch to remove the "Note"
> > 
> > 
> > What you have is fine for accepting this series.  Just submit a new
> > patch that cleans it up.
> 
> +1 here. Good enough for merging, please address remaining comments in the 
> follow up patches. Thanks.

BTW, one more thing to fix in the follow up updates:

WARNING: URL: git://github.com/sysrepo/libredblack.git;protocol=https does not 
set any branch parameter. The future default branch used by tools and 
repositories is uncertain and we will therefore soon require this is set in 
all git urls.

Re: [meta-arago] [master/kirkstone][PATCH v4 5/8] meta-arago-extras: sysrepo: Add libredblack needed for sysrepo

[Ravi Gunasekaran]

On 6/29/23 4:17 AM, Denys Dmytriyenko wrote:
> On Wed, Jun 28, 2023 at 01:56:06PM -0400, Denys Dmytriyenko wrote:
>> On Wed, Jun 28, 2023 at 10:52:26AM -0500, Ryan Eatmon wrote:
>>>
>>>
>>> On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote:
>>>> Andrew,
>>>>
>>>> On 6/27/23 8:32 PM, Andrew Davis wrote:
>>>>> On 6/27/23 9:42 AM, Ravi Gunasekaran wrote:
>>>>>> libredblack is needed to build sysrepo. Add recipe for libredblack.
>>>>>>
>>>>>> The recipe is taken as-is from the commit 09f73e7 ("update for honister")
>>>>> >from the public repo [1].
>>>>>>
>>>>>> [1] - https://github.com/sartura/meta-sysrepo
>>>>>>
>>>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>>>>> ---
>>>>>>
>>>>>> Changes since v3:
>>>>>> ----------------
>>>>>> No change
>>>>>>
>>>>>> Changes since v2:
>>>>>> ---------------
>>>>>> Newly introduced in this series
>>>>>>
>>>>>>   .../libredblack/libredblack_git.bb            | 21 +++++++++++++++++++
>>>>>>   1 file changed, 21 insertions(+)
>>>>>>   create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>>>>>
>>>>>> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>>>>> new file mode 100644
>>>>>> index 00000000..ea51b618
>>>>>> --- /dev/null
>>>>>> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb
>>>>>> @@ -0,0 +1,21 @@
>>>>>> +SUMMARY = "Library for handling red-black tree searching algorithm"
>>>>>> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm."
>>>>>> +LICENSE = "LGPLv2.1"
>>>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99"
>>>>>> +
>>>>>> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https"
>>>>>> +
>>>>>> +PV = "1.0+git${SRCPV}"
>>>>>> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d"
>>>>>> +
>>>>>> +S = "${WORKDIR}/git"
>>>>>> +
>>>>>> +# NOTE: if this software is not capable of being built in a separate build directory
>>>>>> +# from the source, you should replace autotools with autotools-brokensep in the
>>>>>> +# inherit line
>>>>>
>>>>> This comment isn't needed.
>>>>>
>>>>> I understand the 1:1 copy from the original repo, but after you should have another patch
>>>>> that comes back and cleans these up. If they are to live in meta-arago they need to be up
>>>>> to the standards.
>>>>
>>>> Understood.
>>>> I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending
>>>> the next version, I will add another patch in the series to remove this "Note".
>>>> Incase the series is acceptable, then I will send out a separate patch to remove the "Note"
>>>
>>>
>>> What you have is fine for accepting this series.  Just submit a new
>>> patch that cleans it up.
>>
>> +1 here. Good enough for merging, please address remaining comments in the 
>> follow up patches. Thanks.
> 
> BTW, one more thing to fix in the follow up updates:
> 
> WARNING: URL: git://github.com/sysrepo/libredblack.git;protocol=https does not 
> set any branch parameter. The future default branch used by tools and 
> repositories is uncertain and we will therefore soon require this is set in 
> all git urls.

Thanks for merging the patches to kirkstone-next.
I will post a follow up series fixing the comments.

-- 
Regards,
Ravi

Re: [master/kirkstone][PATCH v4 1/8] meta-arago-extras: sysrepo: Update checksum for nw-configurator

[Ravi Gunasekaran]

On 6/28/23 10:37 PM, Denys Dmytriyenko wrote:
> On Tue, Jun 27, 2023 at 08:12:42PM +0530, Ravi Gunasekaran wrote:
>> Instead of using the source file to compute the license checksum,
>> use the license text only from source file.
>>
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>
>> Changes since v3:
>> ----------------
>> No change
>>
>> Changes since v2:
>> ----------------
>> 1) Corrected the license type
>> 2) License checksum calculated based on the license header instead of the 
>> entire source file
>>
>> Changes since v1:
>> ---------------
>> No change
>>
>>  .../recipes-sysrepo/nw-configurator/nw-configurator.bb       | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
>> index 5a152017..c5d9a86b 100644
>> --- a/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
>> +++ b/meta-arago-extras/recipes-sysrepo/nw-configurator/nw-configurator.bb
>> @@ -1,6 +1,7 @@
>> -LICENSE="GPLv2"
>>  DESCRIPTION = "Sysrepo based repo to configure EST"
>> -LIC_FILES_CHKSUM = "file://nw-configurator.c;md5=a818a6cf4fbeeb21acc8b4e9956c08a4"
>> +
>> +LICENSE = "BSD-3-Clause"
>> +LIC_FILES_CHKSUM = "file://nw-configurator.c;beginline=1;endline=33;md5=3538caaf9bfb8372347877ad393660fa"
> 
> Thanks, this is a move in the right direction!
> 
> However, you also changed the LICENSE identifier w/o explaining the reason in 
> the commit message! This is rather critical... I checked the nw-configurator.c 
> and indeed GPLv2 was totally wrong, but you have to explain the change anyway. 
> Going forward there will be a new requirement for Yocto compliance to properly 
> explain license changes like that and there's a new field "License-Update:"
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Describing_license_changes
> 

Noted. In future, I will add such reasoning in the commit message itself.

> 
>>  SRC_URI = "file://nw-configurator.c"

-- 
Regards,
Ravi