From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Thomas Witt <thomas@witt.link>
Cc: Thomas Witt <kernel@witt.link>,
Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Vidya Sagar <vidyas@nvidia.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Michael Bottini <michael.a.bottini@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
Tasev Nikola <tasev.stefanoska@skynet.be>,
Mark Enriquez <enriquezmark36@gmail.com>,
Koba Ko <koba.ko@canonical.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore
Date: Thu, 29 Jun 2023 13:23:58 +0300 [thread overview]
Message-ID: <20230629102358.GP14638@black.fi.intel.com> (raw)
In-Reply-To: <4b47ec58-dc34-1129-4a50-baf2b84b0f53@witt.link>
On Thu, Jun 29, 2023 at 11:47:01AM +0200, Thomas Witt wrote:
> On 28/06/2023 12:59, Mika Westerberg wrote:
> > I wonder if the patch actually helps here now because the reason we want
> > to add it back is that it allows the CPU to enter lower power states and
> > thus reducing the power consumption in S2idle too. Do you observe that
> > when you have the patch applied?
>
> No joy. I did not check what its actually doing, but the computer takes
> about 150mA over the charger at idle with screen off and 140mA in suspend.
> With mem_sleep set to "deep", it takes about 20mA in suspend. All with the
> battery at 100%, at 19.7V.
>
> So I guess I want to keep the "deep" setting in my cmdline.
Okay thanks a lot for checking! Back to drawing board then...
next prev parent reply other threads:[~2023-06-29 10:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 6:24 [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore Mika Westerberg
2023-06-27 9:53 ` Thomas Witt
2023-06-27 10:04 ` Mika Westerberg
2023-06-27 20:41 ` Bjorn Helgaas
2023-06-28 6:46 ` Mika Westerberg
2023-06-28 10:24 ` Thomas Witt
2023-06-28 10:59 ` Mika Westerberg
2023-06-28 12:30 ` Mika Westerberg
2023-06-29 9:47 ` Thomas Witt
2023-06-29 10:23 ` Mika Westerberg [this message]
2023-06-29 14:24 ` David E. Box
2023-06-30 10:41 ` Mika Westerberg
2023-06-30 16:58 ` Thomas Witt
2023-07-05 20:53 ` David E. Box
2023-07-06 19:14 ` Thomas Witt
2023-07-31 15:01 ` Mika Westerberg
2023-08-05 7:57 ` Thomas Witt
2023-08-07 7:58 ` Mika Westerberg
2023-08-10 23:44 ` David E. Box
2023-06-28 12:16 ` Mario Limonciello
2023-06-28 12:38 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629102358.GP14638@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=enriquezmark36@gmail.com \
--cc=helgaas@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=kernel@witt.link \
--cc=koba.ko@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=michael.a.bottini@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tasev.stefanoska@skynet.be \
--cc=thomas@witt.link \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.