All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Thomas Witt <thomas@witt.link>
Cc: david.e.box@linux.intel.com, Thomas Witt <kernel@witt.link>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Vidya Sagar <vidyas@nvidia.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Tasev Nikola <tasev.stefanoska@skynet.be>,
	Mark Enriquez <enriquezmark36@gmail.com>,
	Koba Ko <koba.ko@canonical.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore
Date: Mon, 31 Jul 2023 18:01:28 +0300	[thread overview]
Message-ID: <20230731150128.GK14638@black.fi.intel.com> (raw)
In-Reply-To: <6673c6a1-16ba-aaa4-707a-70d92d9751f6@witt.link>

Hi Thomas,

On Thu, Jul 06, 2023 at 09:14:27PM +0200, Thomas Witt wrote:
> On 05/07/2023 22:53, David E. Box wrote:
> > Mika is now out on extended vacation. We still need a solution that will enable
> > the L1 substate save/restore without breaking your system. I'd like to try to
> > get the power consumption lowered on your system while suspended with s2idle.
> > The s0ix self test script will really help to tell us where to start. You can
> > provide the results in the bugzilla.
> > 
> > The other thing we can do is find out why it only breaks under S3. It could be
> > timing related, so I've attached another patch to the bugzilla to test this.
> > 
> > https://bugzilla.kernel.org/attachment.cgi?id=304553
> > 
> > Please let me know if it works. Thanks.
> > 
> > David
> 
> Hi David,
> 
> I tried your patch, and I see no difference from Mika's. Still not coming
> back from suspend.

Thanks for trying that. Did you manage to try out the S0ix script David
suggested? That should show us hopefully what is draining the battery in
s2idle.

  reply	other threads:[~2023-07-31 15:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  6:24 [PATCH] PCI/ASPM: Add back L1 PM Substate save and restore Mika Westerberg
2023-06-27  9:53 ` Thomas Witt
2023-06-27 10:04   ` Mika Westerberg
2023-06-27 20:41     ` Bjorn Helgaas
2023-06-28  6:46       ` Mika Westerberg
2023-06-28 10:24         ` Thomas Witt
2023-06-28 10:59           ` Mika Westerberg
2023-06-28 12:30             ` Mika Westerberg
2023-06-29  9:47             ` Thomas Witt
2023-06-29 10:23               ` Mika Westerberg
2023-06-29 14:24               ` David E. Box
2023-06-30 10:41                 ` Mika Westerberg
2023-06-30 16:58                   ` Thomas Witt
2023-07-05 20:53                     ` David E. Box
2023-07-06 19:14                       ` Thomas Witt
2023-07-31 15:01                         ` Mika Westerberg [this message]
2023-08-05  7:57                           ` Thomas Witt
2023-08-07  7:58                             ` Mika Westerberg
2023-08-10 23:44                               ` David E. Box
2023-06-28 12:16         ` Mario Limonciello
2023-06-28 12:38           ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731150128.GK14638@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=david.e.box@linux.intel.com \
    --cc=enriquezmark36@gmail.com \
    --cc=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=kernel@witt.link \
    --cc=koba.ko@canonical.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tasev.stefanoska@skynet.be \
    --cc=thomas@witt.link \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.