From: Roman Mamedov <rm@romanrm.net>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Naohiro Aota <naohiro.aota@wdc.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: zoned: do not enable async discard
Date: Thu, 29 Jun 2023 16:25:18 +0500 [thread overview]
Message-ID: <20230629162518.164ca443@nvm> (raw)
In-Reply-To: <e803b649-299b-05b6-6528-06437548e974@kernel.org>
On Thu, 29 Jun 2023 18:15:05 +0900
Damien Le Moal <dlemoal@kernel.org> wrote:
> > + if (btrfs_test_opt(info, DISCARD_ASYNC)) {
> > + btrfs_warn(info, "zoned: disabling async discard as it is not supported");
>
> The "not supported" mention here kind of imply that we are not finished with
> this support yet. So may be a simple: "zoned: ignoring async discard" would
> suffice ?
IMO "not supported" does not imply "not supported yet". To me the message
reads more like "not supported by definition" (of zoned), i.e. no
misunderstanding.
--
With respect,
Roman
next prev parent reply other threads:[~2023-06-29 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 8:37 [PATCH v2] btrfs: zoned: do not enable async discard Naohiro Aota
2023-06-29 9:15 ` Damien Le Moal
2023-06-29 11:25 ` Roman Mamedov [this message]
2023-06-30 0:00 ` Damien Le Moal
2023-07-06 12:43 ` Christoph Hellwig
2023-07-12 16:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629162518.164ca443@nvm \
--to=rm@romanrm.net \
--cc=dlemoal@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.