All of lore.kernel.org
 help / color / mirror / Atom feed
* [android-common:android-4.14-stable 2/2] fs/verity/enable.c:26:9: error: implicit declaration of function 'find_get_page_flags'
@ 2023-06-30 17:19 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-06-30 17:19 UTC (permalink / raw)
  To: cros-kernel-buildreports; +Cc: oe-kbuild-all

tree:   https://android.googlesource.com/kernel/common android-4.14-stable
head:   e8c1340cbb0f24693dd9056f8d5a7808e4597b80
commit: 285fc83a087180f0bc30b75285d4bc2cdcceae06 [2/2] BACKPORT: fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY
config: x86_64-randconfig-x003-20230629 (https://download.01.org/0day-ci/archive/20230701/202307010156.FUvAeJBv-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230701/202307010156.FUvAeJBv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307010156.FUvAeJBv-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/verity/enable.c:26:9: error: implicit declaration of function 'find_get_page_flags' [-Werror,-Wimplicit-function-declaration]
           page = find_get_page_flags(filp->f_mapping, index, FGP_ACCESSED);
                  ^
>> fs/verity/enable.c:26:53: error: use of undeclared identifier 'FGP_ACCESSED'
           page = find_get_page_flags(filp->f_mapping, index, FGP_ACCESSED);
                                                              ^
>> fs/verity/enable.c:33:10: error: implicit declaration of function 'read_mapping_page' [-Werror,-Wimplicit-function-declaration]
                   page = read_mapping_page(filp->f_mapping, index, NULL);
                          ^
>> fs/verity/enable.c:33:8: error: incompatible integer to pointer conversion assigning to 'struct page *' from 'int' [-Wint-conversion]
                   page = read_mapping_page(filp->f_mapping, index, NULL);
                        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   4 errors generated.


vim +/find_get_page_flags +26 fs/verity/enable.c

46af35239934d8 Eric Biggers 2019-07-22  15  
693ad1e5b397bb Eric Biggers 2020-01-06  16  /*
693ad1e5b397bb Eric Biggers 2020-01-06  17   * Read a file data page for Merkle tree construction.  Do aggressive readahead,
693ad1e5b397bb Eric Biggers 2020-01-06  18   * since we're sequentially reading the entire file.
693ad1e5b397bb Eric Biggers 2020-01-06  19   */
693ad1e5b397bb Eric Biggers 2020-01-06  20  static struct page *read_file_data_page(struct file *filp, pgoff_t index,
693ad1e5b397bb Eric Biggers 2020-01-06  21  					struct file_ra_state *ra,
693ad1e5b397bb Eric Biggers 2020-01-06  22  					unsigned long remaining_pages)
693ad1e5b397bb Eric Biggers 2020-01-06  23  {
693ad1e5b397bb Eric Biggers 2020-01-06  24  	struct page *page;
693ad1e5b397bb Eric Biggers 2020-01-06  25  
693ad1e5b397bb Eric Biggers 2020-01-06 @26  	page = find_get_page_flags(filp->f_mapping, index, FGP_ACCESSED);
693ad1e5b397bb Eric Biggers 2020-01-06  27  	if (!page || !PageUptodate(page)) {
693ad1e5b397bb Eric Biggers 2020-01-06  28  		if (page)
693ad1e5b397bb Eric Biggers 2020-01-06  29  			put_page(page);
693ad1e5b397bb Eric Biggers 2020-01-06  30  		else
693ad1e5b397bb Eric Biggers 2020-01-06  31  			page_cache_sync_readahead(filp->f_mapping, ra, filp,
693ad1e5b397bb Eric Biggers 2020-01-06  32  						  index, remaining_pages);
693ad1e5b397bb Eric Biggers 2020-01-06 @33  		page = read_mapping_page(filp->f_mapping, index, NULL);
693ad1e5b397bb Eric Biggers 2020-01-06  34  		if (IS_ERR(page))
693ad1e5b397bb Eric Biggers 2020-01-06  35  			return page;
693ad1e5b397bb Eric Biggers 2020-01-06  36  	}
693ad1e5b397bb Eric Biggers 2020-01-06  37  	if (PageReadahead(page))
693ad1e5b397bb Eric Biggers 2020-01-06  38  		page_cache_async_readahead(filp->f_mapping, ra, filp, page,
693ad1e5b397bb Eric Biggers 2020-01-06  39  					   index, remaining_pages);
693ad1e5b397bb Eric Biggers 2020-01-06  40  	return page;
693ad1e5b397bb Eric Biggers 2020-01-06  41  }
693ad1e5b397bb Eric Biggers 2020-01-06  42  

:::::: The code at line 26 was first introduced by commit
:::::: 693ad1e5b397bbc6c7fb971c8406426a5f21c8c1 fs-verity: implement readahead for FS_IOC_ENABLE_VERITY

:::::: TO: Eric Biggers <ebiggers@google.com>
:::::: CC: Jaegeuk Kim <jaegeuk@google.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-30 17:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-30 17:19 [android-common:android-4.14-stable 2/2] fs/verity/enable.c:26:9: error: implicit declaration of function 'find_get_page_flags' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.