From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size
Date: Tue, 4 Jul 2023 10:35:02 +0200 [thread overview]
Message-ID: <20230704103502.299ac7de@xps-13> (raw)
In-Reply-To: <20230628092937.538683-2-AVKrasnov@sberdevices.ru>
Hi Arseniy,
AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:35 +0300:
> Meson NAND supports both 512B and 1024B ECC step size, so replace
> 'const' for only 1024B step size with enum for both sizes.
>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> ---
> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> index 3bec8af91bbb..d42daa285d17 100644
> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> @@ -49,7 +49,7 @@ patternProperties:
> const: hw
>
> nand-ecc-step-size:
> - const: 1024
> + enum: [512, 1024]
I believe you should as well mention the default value.
> nand-ecc-strength:
> enum: [8, 16, 24, 30, 40, 50, 60]
> @@ -93,6 +93,7 @@ examples:
> nand@0 {
> reg = <0>;
> nand-rb = <0>;
> + nand-ecc-step-size = <1024>;
And I don't think this line is really required, but I don't mind.
> };
> };
>
Thanks,
Miquèl
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size
Date: Tue, 4 Jul 2023 10:35:02 +0200 [thread overview]
Message-ID: <20230704103502.299ac7de@xps-13> (raw)
In-Reply-To: <20230628092937.538683-2-AVKrasnov@sberdevices.ru>
Hi Arseniy,
AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:35 +0300:
> Meson NAND supports both 512B and 1024B ECC step size, so replace
> 'const' for only 1024B step size with enum for both sizes.
>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> ---
> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> index 3bec8af91bbb..d42daa285d17 100644
> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> @@ -49,7 +49,7 @@ patternProperties:
> const: hw
>
> nand-ecc-step-size:
> - const: 1024
> + enum: [512, 1024]
I believe you should as well mention the default value.
> nand-ecc-strength:
> enum: [8, 16, 24, 30, 40, 50, 60]
> @@ -93,6 +93,7 @@ examples:
> nand@0 {
> reg = <0>;
> nand-rb = <0>;
> + nand-ecc-step-size = <1024>;
And I don't think this line is really required, but I don't mind.
> };
> };
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size
Date: Tue, 4 Jul 2023 10:35:02 +0200 [thread overview]
Message-ID: <20230704103502.299ac7de@xps-13> (raw)
In-Reply-To: <20230628092937.538683-2-AVKrasnov@sberdevices.ru>
Hi Arseniy,
AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:35 +0300:
> Meson NAND supports both 512B and 1024B ECC step size, so replace
> 'const' for only 1024B step size with enum for both sizes.
>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> ---
> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> index 3bec8af91bbb..d42daa285d17 100644
> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> @@ -49,7 +49,7 @@ patternProperties:
> const: hw
>
> nand-ecc-step-size:
> - const: 1024
> + enum: [512, 1024]
I believe you should as well mention the default value.
> nand-ecc-strength:
> enum: [8, 16, 24, 30, 40, 50, 60]
> @@ -93,6 +93,7 @@ examples:
> nand@0 {
> reg = <0>;
> nand-rb = <0>;
> + nand-ecc-step-size = <1024>;
And I don't think this line is really required, but I don't mind.
> };
> };
>
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
Cc: Liang Yang <liang.yang@amlogic.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size
Date: Tue, 4 Jul 2023 10:35:02 +0200 [thread overview]
Message-ID: <20230704103502.299ac7de@xps-13> (raw)
In-Reply-To: <20230628092937.538683-2-AVKrasnov@sberdevices.ru>
Hi Arseniy,
AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:35 +0300:
> Meson NAND supports both 512B and 1024B ECC step size, so replace
> 'const' for only 1024B step size with enum for both sizes.
>
> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
> ---
> Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> index 3bec8af91bbb..d42daa285d17 100644
> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml
> @@ -49,7 +49,7 @@ patternProperties:
> const: hw
>
> nand-ecc-step-size:
> - const: 1024
> + enum: [512, 1024]
I believe you should as well mention the default value.
> nand-ecc-strength:
> enum: [8, 16, 24, 30, 40, 50, 60]
> @@ -93,6 +93,7 @@ examples:
> nand@0 {
> reg = <0>;
> nand-rb = <0>;
> + nand-ecc-step-size = <1024>;
And I don't think this line is really required, but I don't mind.
> };
> };
>
Thanks,
Miquèl
next prev parent reply other threads:[~2023-07-04 8:35 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 9:29 [RFC PATCH v1 0/2] support 512B ECC step size for Meson NAND Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-29 16:19 ` Rob Herring
2023-06-29 16:19 ` Rob Herring
2023-06-29 16:19 ` Rob Herring
2023-06-29 16:19 ` Rob Herring
2023-07-04 8:35 ` Miquel Raynal [this message]
2023-07-04 8:35 ` Miquel Raynal
2023-07-04 8:35 ` Miquel Raynal
2023-07-04 8:35 ` Miquel Raynal
2023-06-28 9:29 ` [RFC PATCH v1 2/2] mtd: rawnand: " Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-06-28 9:29 ` Arseniy Krasnov
2023-07-04 8:36 ` Miquel Raynal
2023-07-04 8:36 ` Miquel Raynal
2023-07-04 8:36 ` Miquel Raynal
2023-07-04 8:36 ` Miquel Raynal
2023-07-04 9:23 ` Arseniy Krasnov
2023-07-04 9:23 ` Arseniy Krasnov
2023-07-04 9:23 ` Arseniy Krasnov
2023-07-04 9:23 ` Arseniy Krasnov
2023-07-04 9:41 ` Miquel Raynal
2023-07-04 9:41 ` Miquel Raynal
2023-07-04 9:41 ` Miquel Raynal
2023-07-04 9:41 ` Miquel Raynal
2023-07-04 9:46 ` Arseniy Krasnov
2023-07-04 9:46 ` Arseniy Krasnov
2023-07-04 9:46 ` Arseniy Krasnov
2023-07-04 9:46 ` Arseniy Krasnov
2023-07-04 9:56 ` Miquel Raynal
2023-07-04 9:56 ` Miquel Raynal
2023-07-04 9:56 ` Miquel Raynal
2023-07-04 9:56 ` Miquel Raynal
2023-07-04 10:21 ` Arseniy Krasnov
2023-07-04 10:21 ` Arseniy Krasnov
2023-07-04 10:21 ` Arseniy Krasnov
2023-07-04 10:21 ` Arseniy Krasnov
2023-07-04 13:41 ` Miquel Raynal
2023-07-04 13:41 ` Miquel Raynal
2023-07-04 13:41 ` Miquel Raynal
2023-07-04 13:41 ` Miquel Raynal
2023-07-04 15:07 ` Arseniy Krasnov
2023-07-04 15:07 ` Arseniy Krasnov
2023-07-04 15:07 ` Arseniy Krasnov
2023-07-04 15:07 ` Arseniy Krasnov
2023-07-04 15:32 ` Miquel Raynal
2023-07-04 15:32 ` Miquel Raynal
2023-07-04 15:32 ` Miquel Raynal
2023-07-04 15:32 ` Miquel Raynal
2023-07-04 17:07 ` Arseniy Krasnov
2023-07-04 17:07 ` Arseniy Krasnov
2023-07-04 17:07 ` Arseniy Krasnov
2023-07-04 17:07 ` Arseniy Krasnov
2023-07-06 16:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704103502.299ac7de@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=AVKrasnov@sberdevices.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.