All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Albershteyn <aalbersh@redhat.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: zlang@redhat.com, linux-xfs@vger.kernel.org,
	fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 4/5] xfs/041: force create files on the data device
Date: Tue, 4 Jul 2023 16:22:49 +0200	[thread overview]
Message-ID: <20230704142249.bys4vlk5iryewd3z@aalbersh.remote.csb> (raw)
In-Reply-To: <168840383563.1317961.17059869339313726876.stgit@frogsfrogsfrogs>

On 2023-07-03 10:03:55, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Since we're testing growfs of the data device, we should create the
> files there, even if the mkfs configuration enables rtinherit on the
> root dir.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  tests/xfs/041 |    3 +++
>  1 file changed, 3 insertions(+)
> 
> 
> diff --git a/tests/xfs/041 b/tests/xfs/041
> index 05de5578ff..21b3afe7ce 100755
> --- a/tests/xfs/041
> +++ b/tests/xfs/041
> @@ -46,6 +46,9 @@ bsize=`_scratch_mkfs_xfs -dsize=${agsize}m,agcount=1 2>&1 | _filter_mkfs 2>&1 \
>  onemeginblocks=`expr 1048576 / $bsize`
>  _scratch_mount
>  
> +# We're growing the data device, so force new file creation there
> +_xfs_force_bdev data $SCRATCH_MNT
> +
>  echo "done"
>  
>  # full allocation group -> partial; partial -> expand partial + new partial;
> 

Looks good to me:
Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>

-- 
- Andrey


  reply	other threads:[~2023-07-04 14:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 17:03 [PATCHSET 0/5] fstests: random fixes for v2023.06.18 Darrick J. Wong
2023-07-03 17:03 ` [PATCH 1/5] xfs/529: fix bogus failure when realtime is configured Darrick J. Wong
2023-07-04 13:52   ` Andrey Albershteyn
2023-07-03 17:03 ` [PATCH 2/5] xfs/569: skip post-test fsck run Darrick J. Wong
2023-07-04 14:18   ` Andrey Albershteyn
2023-07-03 17:03 ` [PATCH 3/5] xfs/439: amend test to work with new log geometry validation Darrick J. Wong
2023-07-05  6:37   ` Zorro Lang
2023-07-05 15:37     ` Darrick J. Wong
2023-07-05 15:38   ` [PATCH v1.1 " Darrick J. Wong
2023-07-06  7:57     ` Zorro Lang
2023-07-03 17:03 ` [PATCH 4/5] xfs/041: force create files on the data device Darrick J. Wong
2023-07-04 14:22   ` Andrey Albershteyn [this message]
2023-07-03 17:04 ` [PATCH 5/5] xfs: test growfs of the realtime device Darrick J. Wong
2023-07-04 14:03   ` Andrey Albershteyn
2023-07-04 14:23     ` Andrey Albershteyn
2023-07-04 15:52     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230704142249.bys4vlk5iryewd3z@aalbersh.remote.csb \
    --to=aalbersh@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.