From: "Darrick J. Wong" <djwong@kernel.org>
To: zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCH v1.1 3/5] xfs/439: amend test to work with new log geometry validation
Date: Wed, 5 Jul 2023 08:38:19 -0700 [thread overview]
Message-ID: <20230705153819.GS11441@frogsfrogsfrogs> (raw)
In-Reply-To: <168840383001.1317961.12926483978316384291.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
An upcoming patch moves more log validation checks to the superblock
verifier, so update this test as needed.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
v2: annotate which commits this tests is testing
---
tests/xfs/439 | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tests/xfs/439 b/tests/xfs/439
index b7929493d1..cb6fb37918 100755
--- a/tests/xfs/439
+++ b/tests/xfs/439
@@ -20,8 +20,14 @@ _begin_fstest auto quick fuzzers log
# real QA test starts here
_supported_fs xfs
_require_scratch_nocheck
-# We corrupt XFS on purpose, and check if assert failures would crash system.
-_require_no_xfs_bug_on_assert
+
+# We corrupt XFS on purpose, and check if assert failures would crash the
+# system when trying to xfs_log_mount. Hence this is a regression test for:
+_fixed_by_git_commit kernel 9c92ee208b1f "xfs: validate sb_logsunit is a multiple of the fs blocksize"
+
+# This used to be _require_no_xfs_bug_on_assert, but now we've fixed the sb
+# verifier to reject this before xfs_log_mount gets to it:
+_fixed_by_git_commit kernel f1e1765aad7d "xfs: journal geometry is not properly bounds checked"
rm -f "$seqres.full"
@@ -33,7 +39,7 @@ blksz=$(_scratch_xfs_get_sb_field blocksize)
_scratch_xfs_set_sb_field logsunit $((blksz - 1)) >> $seqres.full 2>&1
# Check if logsunit is set correctly
-lsunit=$(_scratch_xfs_get_sb_field logsunit)
+lsunit=$(_scratch_xfs_get_sb_field logsunit 2>/dev/null)
[ $lsunit -ne $((blksz - 1)) ] && _notrun "failed to set sb_logsunit"
# Mount and writing log may trigger a crash on buggy kernel
next prev parent reply other threads:[~2023-07-05 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 17:03 [PATCHSET 0/5] fstests: random fixes for v2023.06.18 Darrick J. Wong
2023-07-03 17:03 ` [PATCH 1/5] xfs/529: fix bogus failure when realtime is configured Darrick J. Wong
2023-07-04 13:52 ` Andrey Albershteyn
2023-07-03 17:03 ` [PATCH 2/5] xfs/569: skip post-test fsck run Darrick J. Wong
2023-07-04 14:18 ` Andrey Albershteyn
2023-07-03 17:03 ` [PATCH 3/5] xfs/439: amend test to work with new log geometry validation Darrick J. Wong
2023-07-05 6:37 ` Zorro Lang
2023-07-05 15:37 ` Darrick J. Wong
2023-07-05 15:38 ` Darrick J. Wong [this message]
2023-07-06 7:57 ` [PATCH v1.1 " Zorro Lang
2023-07-03 17:03 ` [PATCH 4/5] xfs/041: force create files on the data device Darrick J. Wong
2023-07-04 14:22 ` Andrey Albershteyn
2023-07-03 17:04 ` [PATCH 5/5] xfs: test growfs of the realtime device Darrick J. Wong
2023-07-04 14:03 ` Andrey Albershteyn
2023-07-04 14:23 ` Andrey Albershteyn
2023-07-04 15:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705153819.GS11441@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.