From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-fbdev@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Inki Dae <inki.dae@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH 06/10] drm/exynos: Set fbdev flags
Date: Tue, 4 Jul 2023 17:50:03 +0200 [thread overview]
Message-ID: <20230704160133.20261-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20230704160133.20261-1-tzimmermann@suse.de>
Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with
FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should
be accessed with the CPU's regular memory ops.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 7ca3424b59ce..28dc398d6e10 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -72,6 +72,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
return PTR_ERR(fbi);
}
+ fbi->flags = FBINFO_FLAG_DEFAULT;
fbi->fbops = &exynos_drm_fb_ops;
drm_fb_helper_fill_info(fbi, helper, sizes);
@@ -79,6 +80,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
offset = fbi->var.xoffset * fb->format->cpp[0];
offset += fbi->var.yoffset * fb->pitches[0];
+ fbi->flags |= FBINFO_VIRTFB;
fbi->screen_buffer = exynos_gem->kvaddr + offset;
fbi->screen_size = size;
fbi->fix.smem_len = size;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-fbdev@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Inki Dae <inki.dae@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH 06/10] drm/exynos: Set fbdev flags
Date: Tue, 4 Jul 2023 17:50:03 +0200 [thread overview]
Message-ID: <20230704160133.20261-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20230704160133.20261-1-tzimmermann@suse.de>
Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with
FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should
be accessed with the CPU's regular memory ops.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 7ca3424b59ce..28dc398d6e10 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -72,6 +72,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
return PTR_ERR(fbi);
}
+ fbi->flags = FBINFO_FLAG_DEFAULT;
fbi->fbops = &exynos_drm_fb_ops;
drm_fb_helper_fill_info(fbi, helper, sizes);
@@ -79,6 +80,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
offset = fbi->var.xoffset * fb->format->cpp[0];
offset += fbi->var.yoffset * fb->pitches[0];
+ fbi->flags |= FBINFO_VIRTFB;
fbi->screen_buffer = exynos_gem->kvaddr + offset;
fbi->screen_size = size;
fbi->fix.smem_len = size;
--
2.41.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: javierm@redhat.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org
Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
dri-devel@lists.freedesktop.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] drm/exynos: Set fbdev flags
Date: Tue, 4 Jul 2023 17:50:03 +0200 [thread overview]
Message-ID: <20230704160133.20261-7-tzimmermann@suse.de> (raw)
In-Reply-To: <20230704160133.20261-1-tzimmermann@suse.de>
Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with
FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should
be accessed with the CPU's regular memory ops.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 7ca3424b59ce..28dc398d6e10 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -72,6 +72,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
return PTR_ERR(fbi);
}
+ fbi->flags = FBINFO_FLAG_DEFAULT;
fbi->fbops = &exynos_drm_fb_ops;
drm_fb_helper_fill_info(fbi, helper, sizes);
@@ -79,6 +80,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
offset = fbi->var.xoffset * fb->format->cpp[0];
offset += fbi->var.yoffset * fb->pitches[0];
+ fbi->flags |= FBINFO_VIRTFB;
fbi->screen_buffer = exynos_gem->kvaddr + offset;
fbi->screen_size = size;
fbi->fix.smem_len = size;
--
2.41.0
next prev parent reply other threads:[~2023-07-04 16:01 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 15:49 [PATCH 00/10] drm: Improve fbdev emulation for DMA-able framebuffers Thomas Zimmermann
2023-07-04 15:49 ` Thomas Zimmermann
2023-07-04 15:49 ` Thomas Zimmermann
2023-07-04 15:49 ` [PATCH 01/10] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory Thomas Zimmermann
2023-07-04 15:49 ` Thomas Zimmermann
2023-07-04 15:49 ` Thomas Zimmermann
2023-07-05 8:23 ` Javier Martinez Canillas
2023-07-05 8:23 ` Javier Martinez Canillas
2023-07-05 8:23 ` Javier Martinez Canillas
2023-07-05 9:08 ` Thomas Zimmermann
2023-07-05 9:08 ` Thomas Zimmermann
2023-07-05 9:13 ` Javier Martinez Canillas
2023-07-05 9:13 ` Javier Martinez Canillas
2023-07-04 15:49 ` [PATCH 02/10] drm/fbdev-dma: Use fbdev DMA helpers Thomas Zimmermann
2023-07-04 15:49 ` Thomas Zimmermann
2023-07-04 15:49 ` Thomas Zimmermann
2023-07-05 8:24 ` Javier Martinez Canillas
2023-07-05 8:24 ` Javier Martinez Canillas
2023-07-05 8:24 ` Javier Martinez Canillas
2023-07-04 15:50 ` [PATCH 03/10] drm/tegra: " Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 8:24 ` Javier Martinez Canillas
2023-07-05 8:24 ` Javier Martinez Canillas
2023-07-05 8:24 ` Javier Martinez Canillas
2023-07-04 15:50 ` [PATCH 04/10] drm/tegra: Set fbdev flags Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 8:34 ` Javier Martinez Canillas
2023-07-05 8:34 ` Javier Martinez Canillas
2023-07-05 8:34 ` Javier Martinez Canillas
2023-07-05 9:19 ` Thomas Zimmermann
2023-07-05 9:19 ` Thomas Zimmermann
2023-07-05 9:19 ` Thomas Zimmermann
2023-07-05 9:34 ` Javier Martinez Canillas
2023-07-05 9:34 ` Javier Martinez Canillas
2023-07-05 9:34 ` Javier Martinez Canillas
2023-07-06 12:44 ` Thomas Zimmermann
2023-07-06 12:44 ` Thomas Zimmermann
2023-07-06 12:44 ` Thomas Zimmermann
2023-07-04 15:50 ` [PATCH 05/10] drm/exynos: Use fbdev DMA helpers Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 2:10 ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-07-05 2:10 ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-07-05 2:10 ` 대인기/Tizen Platform Lab(SR)/삼성전자
2023-07-05 8:38 ` Javier Martinez Canillas
2023-07-05 8:38 ` Javier Martinez Canillas
2023-07-05 8:38 ` Javier Martinez Canillas
2023-07-04 15:50 ` Thomas Zimmermann [this message]
2023-07-04 15:50 ` [PATCH 06/10] drm/exynos: Set fbdev flags Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 8:49 ` Javier Martinez Canillas
2023-07-05 8:49 ` Javier Martinez Canillas
2023-07-05 8:49 ` Javier Martinez Canillas
2023-07-05 9:31 ` Thomas Zimmermann
2023-07-05 9:31 ` Thomas Zimmermann
2023-07-05 9:31 ` Thomas Zimmermann
2023-07-05 9:53 ` Javier Martinez Canillas
2023-07-05 9:53 ` Javier Martinez Canillas
2023-07-05 9:53 ` Javier Martinez Canillas
2023-07-04 15:50 ` [PATCH 07/10] drm/omapdrm: Set VM flags in GEM-object mmap function Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 9:03 ` Javier Martinez Canillas
2023-07-05 9:03 ` Javier Martinez Canillas
2023-07-05 9:03 ` Javier Martinez Canillas
2023-07-04 15:50 ` [PATCH 08/10] drm/omapdrm: Use GEM mmap for fbdev emulation Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 9:05 ` Javier Martinez Canillas
2023-07-05 9:05 ` Javier Martinez Canillas
2023-07-05 9:05 ` Javier Martinez Canillas
2023-07-04 15:50 ` [PATCH 09/10] drm/omapdrm: Set fbdev flags Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 9:07 ` Javier Martinez Canillas
2023-07-05 9:07 ` Javier Martinez Canillas
2023-07-05 9:07 ` Javier Martinez Canillas
2023-07-04 15:50 ` [PATCH 10/10] fbdev: Remove FB_DEFAULT_SYS_OPS Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-04 15:50 ` Thomas Zimmermann
2023-07-05 9:07 ` Javier Martinez Canillas
2023-07-05 9:07 ` Javier Martinez Canillas
2023-07-05 9:07 ` Javier Martinez Canillas
2023-07-05 8:30 ` [PATCH 00/10] drm: Improve fbdev emulation for DMA-able framebuffers Maxime Ripard
2023-07-05 8:30 ` Maxime Ripard
2023-07-05 8:30 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704160133.20261-7-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=alim.akhtar@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.