From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>, Yue Wang <yue.wang@amlogic.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Srikanth Thokala <srikanth.thokala@intel.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] PCI: meson: Remove cast between incompatible function type
Date: Wed, 5 Jul 2023 01:16:00 +0900 [thread overview]
Message-ID: <20230704161600.GA435329@rocinante> (raw)
In-Reply-To: <20230629165956.237832-1-kwilczynski@kernel.org>
Hello,
> Rather than casting void(*)(struct clk *) to void (*)(void *), that
> forces conversion to an incompatible function type, replace the cast
> with a small local stub function with a signature that matches what
> the devm_add_action_or_reset() function expects.
>
> The sub function takes a void *, then passes it directly to
> clk_disable_unprepare(), which handles the more specific type.
>
> Reported by clang when building with warnings enabled:
>
> drivers/pci/controller/dwc/pci-meson.c:191:6: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
> (void (*) (void *))clk_disable_unprepare,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> No functional changes are intended.
Applied to controller/remove-void-cast, thank you everyone!
[01/03] PCI: meson: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/60fce60ab7b6
[02/03] PCI: keembay: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/43a2eef7cbba
[03/03] PCI: microchip: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/9e4811ce626f
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>, Yue Wang <yue.wang@amlogic.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Srikanth Thokala <srikanth.thokala@intel.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] PCI: meson: Remove cast between incompatible function type
Date: Wed, 5 Jul 2023 01:16:00 +0900 [thread overview]
Message-ID: <20230704161600.GA435329@rocinante> (raw)
In-Reply-To: <20230629165956.237832-1-kwilczynski@kernel.org>
Hello,
> Rather than casting void(*)(struct clk *) to void (*)(void *), that
> forces conversion to an incompatible function type, replace the cast
> with a small local stub function with a signature that matches what
> the devm_add_action_or_reset() function expects.
>
> The sub function takes a void *, then passes it directly to
> clk_disable_unprepare(), which handles the more specific type.
>
> Reported by clang when building with warnings enabled:
>
> drivers/pci/controller/dwc/pci-meson.c:191:6: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
> (void (*) (void *))clk_disable_unprepare,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> No functional changes are intended.
Applied to controller/remove-void-cast, thank you everyone!
[01/03] PCI: meson: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/60fce60ab7b6
[02/03] PCI: keembay: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/43a2eef7cbba
[03/03] PCI: microchip: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/9e4811ce626f
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>, Yue Wang <yue.wang@amlogic.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Srikanth Thokala <srikanth.thokala@intel.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] PCI: meson: Remove cast between incompatible function type
Date: Wed, 5 Jul 2023 01:16:00 +0900 [thread overview]
Message-ID: <20230704161600.GA435329@rocinante> (raw)
In-Reply-To: <20230629165956.237832-1-kwilczynski@kernel.org>
Hello,
> Rather than casting void(*)(struct clk *) to void (*)(void *), that
> forces conversion to an incompatible function type, replace the cast
> with a small local stub function with a signature that matches what
> the devm_add_action_or_reset() function expects.
>
> The sub function takes a void *, then passes it directly to
> clk_disable_unprepare(), which handles the more specific type.
>
> Reported by clang when building with warnings enabled:
>
> drivers/pci/controller/dwc/pci-meson.c:191:6: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
> (void (*) (void *))clk_disable_unprepare,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> No functional changes are intended.
Applied to controller/remove-void-cast, thank you everyone!
[01/03] PCI: meson: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/60fce60ab7b6
[02/03] PCI: keembay: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/43a2eef7cbba
[03/03] PCI: microchip: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/9e4811ce626f
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>, Yue Wang <yue.wang@amlogic.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Srikanth Thokala <srikanth.thokala@intel.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/3] PCI: meson: Remove cast between incompatible function type
Date: Wed, 5 Jul 2023 01:16:00 +0900 [thread overview]
Message-ID: <20230704161600.GA435329@rocinante> (raw)
In-Reply-To: <20230629165956.237832-1-kwilczynski@kernel.org>
Hello,
> Rather than casting void(*)(struct clk *) to void (*)(void *), that
> forces conversion to an incompatible function type, replace the cast
> with a small local stub function with a signature that matches what
> the devm_add_action_or_reset() function expects.
>
> The sub function takes a void *, then passes it directly to
> clk_disable_unprepare(), which handles the more specific type.
>
> Reported by clang when building with warnings enabled:
>
> drivers/pci/controller/dwc/pci-meson.c:191:6: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
> (void (*) (void *))clk_disable_unprepare,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> No functional changes are intended.
Applied to controller/remove-void-cast, thank you everyone!
[01/03] PCI: meson: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/60fce60ab7b6
[02/03] PCI: keembay: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/43a2eef7cbba
[03/03] PCI: microchip: Remove cast between incompatible function type
https://git.kernel.org/pci/pci/c/9e4811ce626f
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-04 16:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 16:59 [PATCH 1/3] PCI: meson: Remove cast between incompatible function type Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` [PATCH 2/3] PCI: keembay: " Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-30 10:20 ` Thokala, Srikanth
2023-06-30 10:20 ` Thokala, Srikanth
2023-06-30 10:20 ` Thokala, Srikanth
2023-06-30 10:20 ` Thokala, Srikanth
2023-06-29 16:59 ` [PATCH 3/3] PCI: microchip: " Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 16:59 ` Krzysztof Wilczyński
2023-06-29 20:30 ` Conor Dooley
2023-06-29 20:30 ` Conor Dooley
2023-06-29 20:30 ` Conor Dooley
2023-06-29 20:30 ` Conor Dooley
2023-06-29 20:47 ` Krzysztof Wilczyński
2023-06-29 20:47 ` Krzysztof Wilczyński
2023-06-29 20:47 ` Krzysztof Wilczyński
2023-06-29 20:47 ` Krzysztof Wilczyński
2023-06-30 7:49 ` [PATCH 1/3] PCI: meson: " Neil Armstrong
2023-06-30 7:49 ` Neil Armstrong
2023-06-30 7:49 ` Neil Armstrong
2023-06-30 7:49 ` Neil Armstrong
2023-07-04 16:16 ` Krzysztof Wilczyński [this message]
2023-07-04 16:16 ` Krzysztof Wilczyński
2023-07-04 16:16 ` Krzysztof Wilczyński
2023-07-04 16:16 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704161600.GA435329@rocinante \
--to=kwilczynski@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=srikanth.thokala@intel.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.